From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1K91zD-0003vl-Nr for mharc-grub-devel@gnu.org; Wed, 18 Jun 2008 14:02:23 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K91zB-0003vc-Vm for grub-devel@gnu.org; Wed, 18 Jun 2008 14:02:22 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K91zA-0003vQ-FU for grub-devel@gnu.org; Wed, 18 Jun 2008 14:02:21 -0400 Received: from [199.232.76.173] (port=42214 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K91zA-0003vN-Co for grub-devel@gnu.org; Wed, 18 Jun 2008 14:02:20 -0400 Received: from c60.cesmail.net ([216.154.195.49]:59289) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1K91zA-0004AQ-4Q for grub-devel@gnu.org; Wed, 18 Jun 2008 14:02:20 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 18 Jun 2008 14:02:18 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id AAF66619058 for ; Wed, 18 Jun 2008 14:02:18 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080618174607.GE25553@thorin> References: <20080617104448.2b43f109@gibibit.com> <20080617203710.GA31785@thorin> <20080617153154.143e2e20@gibibit.com> <20080618174607.GE25553@thorin> Content-Type: text/plain; charset=UTF-8 Date: Wed, 18 Jun 2008 14:02:17 -0400 Message-Id: <1213812137.2688.14.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 8bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Tidy up 'make' output X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jun 2008 18:02:22 -0000 On Wed, 2008-06-18 at 19:46 +0200, Robert Millan wrote: > On Tue, Jun 17, 2008 at 03:31:54PM -0700, Colin D Bennett wrote: > > I'm all for warning-free code, but if we try to > > use -Werror, the code won't even begin to compile in the current state. > > Of course, I wasn't proposing to add -Werror in the current state and just > throw the hot potato into everyone ;-) > > Ideally, someone (or all of us ;-)) could do the work to eliminate those > warnings, then add -Werror, and at that point it's the responsibility of > every contributor that new code is warning-free. There will be some combinations of gcc and libraries that will produce warnings. It should be easy to turn off -Werror on the make command line if necessary. > So is the proposed situation you don't like, or the path that would be > needed to archieve it? That's OK, but it's doesn't make build system changes unnecessary. The less noisy build system will help find other messages that -Werror won't catch, such as linker warnings. It will help understand what is happening and what is potentially wrong or suboptimal. For example, I'm seeing warnings from xfs.c that nobody is fixing. I can fix the warning by changing the code so that it does exactly what it's doing now but doesn't cause a warning. The problem is, I don't see corresponding structures in the Linux xfs code. I don't have time to investigate xfs implementation to see if I'm possibly hiding a bug. I can imagine that somebody knows more about xfs but doesn't see the warning. Once we make the warning visible, maybe that person will have a look and make a better patch. It's also possible that somebody who want to install GRUB in xfs will be extra cautious when seeing the warning. It's actually a good thing. Sure, not having the warning will be even better. -- Regards, Pavel Roskin