All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Javier Martín" <lordhabbit@gmail.com>
To: grub-devel@gnu.org
Subject: [PATCH] Small fix in i386 grub-setup
Date: Thu, 19 Jun 2008 13:22:11 +0200	[thread overview]
Message-ID: <1213874531.10018.5.camel@localhost> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 372 bytes --]

Hi there - I have found that a grub-setup in i386 recently got borked,
and now inserts the core.img filename twice in the path while looking
for it the second time: the program tried to find the file
"/boot/grubcore.img/core.img" which is obviously wrong. This is a fix,
or so I think - it seems the right thing given the function prototype
and it works for me.



[-- Attachment #1.2: grub_setup.diff --]
[-- Type: text/x-patch, Size: 679 bytes --]

Index: util/i386/pc/grub-setup.c
===================================================================
RCS file: /sources/grub/grub2/util/i386/pc/grub-setup.c,v
retrieving revision 1.37
diff -u -r1.37 grub-setup.c
--- util/i386/pc/grub-setup.c	18 Jun 2008 17:35:26 -0000	1.37
+++ util/i386/pc/grub-setup.c	19 Jun 2008 11:19:57 -0000
@@ -368,7 +368,7 @@
   
   /* Make sure that GRUB reads the identical image as the OS.  */
   tmp_img = xmalloc (core_size);
-  core_path = grub_util_get_path (DEFAULT_DIRECTORY "core.img", core_file);
+  core_path = grub_util_get_path (DEFAULT_DIRECTORY, core_file);
   
   /* It is a Good Thing to sync two times.  */
   sync ();

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

             reply	other threads:[~2008-06-19 11:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-19 11:22 Javier Martín [this message]
2008-06-19 12:21 ` [PATCH] Small fix in i386 grub-setup Robert Millan
2008-06-19 13:36   ` Javier Martín
2008-06-21 14:14     ` Robert Millan
2008-06-19 13:46   ` Javier Martín
2008-06-21 14:13     ` Robert Millan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213874531.10018.5.camel@localhost \
    --to=lordhabbit@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.