From: Ben Nizette <bn@niasdigital.com>
To: Joel Becker <Joel.Becker@oracle.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"Luis R. Rodriguez" <mcgrof@gmail.com>,
linux-wireless <linux-wireless@vger.kernel.org>,
linux kernel <linux-kernel@vger.kernel.org>,
Greg KH <greg@kroah.com>, Satyam Sharma <ssatyam@cse.iitk.ac.in>,
Felix Fietkau <nbd@openwrt.org>, Al Viro <viro@ftp.linux.org.uk>,
"H. Peter Anvin" <hpa@kernel.org>
Subject: Re: [RFC PATCHES] Re: Is configfs the right solution for configuration based fs?
Date: Sat, 21 Jun 2008 11:03:49 +1000 [thread overview]
Message-ID: <1214010229.2336.88.camel@moss.renham> (raw)
In-Reply-To: <20080620213708.GC21416@mail.oracle.com>
On Fri, 2008-06-20 at 14:37 -0700, Joel Becker wrote:
> On Fri, Jun 20, 2008 at 07:22:56PM +1000, Ben Nizette wrote:
> > A version of my gpio-dev interface is attached. Bear in mind it was
> > never completed, it's full of known bugs but hey, might be useful for
> > you anyway :-)
>
> Looks good. Fits about what I would expect a configfs interface
> to look like, with simple show/store stuff. I can see where some macros
> would have shortened some bolierplate.
> Was there any other boilerplate you found cumbersome? I mean
> outside of defining attribute structs and the show/store_attr()
> trampoline functions? Let me know, so I can incorporate it.
>
You know, I think you've about covered the boilerplate work. Apart from
that, well it took me a millisecond to work out what the point of
config_{group,item}s was; I went in kinda expecting to see one struct
for directories and one for attributes. In fact I still not sure I can
explain the need for config_items separate from config_groups. Little
help? :-)
--Ben.
> Joel
>
next prev parent reply other threads:[~2008-06-21 1:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-08 21:25 Is configfs the right solution for configuration based fs? Luis R. Rodriguez
2008-06-09 2:28 ` Joel Becker
2008-06-11 9:04 ` Joel Becker
2008-06-09 9:03 ` Johannes Berg
2008-06-10 0:12 ` Ben Nizette
2008-06-10 8:01 ` Johannes Berg
2008-06-10 8:12 ` Luis R. Rodriguez
2008-06-10 22:12 ` Ben Nizette
2008-06-19 2:48 ` [RFC PATCHES] " Joel Becker
2008-06-20 6:19 ` Ben Nizette
2008-06-20 6:52 ` Joel Becker
2008-06-20 9:22 ` Ben Nizette
2008-06-20 21:37 ` Joel Becker
2008-06-21 1:03 ` Ben Nizette [this message]
2008-06-21 2:02 ` Joel Becker
2008-06-21 8:03 ` Ben Nizette
2008-06-21 8:44 ` Joel Becker
2008-06-21 11:44 ` Ben Nizette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214010229.2336.88.camel@moss.renham \
--to=bn@niasdigital.com \
--cc=Joel.Becker@oracle.com \
--cc=greg@kroah.com \
--cc=hpa@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@gmail.com \
--cc=nbd@openwrt.org \
--cc=ssatyam@cse.iitk.ac.in \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.