From: Dave Hansen <dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: Containers <containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org>
Subject: Re: [RFC][PATCH][cryo] Save/restore state of unnamed pipes
Date: Mon, 23 Jun 2008 16:30:28 -0700 [thread overview]
Message-ID: <1214263828.7576.10.camel@nimitz> (raw)
In-Reply-To: <485EC6E4.4080707-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
On Sun, 2008-06-22 at 17:40 -0400, Oren Laadan wrote:
> One issue with this approach is that the operation (checkpoint) becomes
> non-transparent to the "checkpointee"s: re-writing the data back into
> the pipe/fifo may generate a SIGIO at the read-side of the pipe/fifo, or
> an inotify event on the inode, without a real reason. This may confuse
> the application if its logic relies on "normal" behavior.
Yeah, I guess this is true, somewhat.
But, for something expecting to read from a pipe, they'll get a SIGIO
when the data is first written. If the signal has not yet been
delivered then we're fine because we won't generate *another* one.
If they've already received the signal and left the data in the pipe,
what harm does another SIGIO do? The kernel is free to give the app a
SIGIO for every single byte stuck in the pipe, right? So, what
difference does any number of SIGIOs make when there's data sitting in
the pipe unread?
As for inotify, yeah that might be an actual issue. It's probably good
to note this potential issue, and to watch for anyone doing inotifies on
a pipe fd when we get to checkpointing inotify.
Overall, seems like an awfully minor issue to me.
-- Dave
prev parent reply other threads:[~2008-06-23 23:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 21:29 [RFC][PATCH][cryo] Save/restore state of unnamed pipes sukadev-r/Jw6+rmf7HQT0dZR+AlfA
[not found] ` <20080617212950.GB11826-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-17 22:30 ` Serge E. Hallyn
[not found] ` <20080617223039.GB26942-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-17 22:55 ` sukadev-r/Jw6+rmf7HQT0dZR+AlfA
2008-06-17 23:31 ` Matt Helsley
[not found] ` <1213745472.16057.37.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-06-18 0:32 ` sukadev-r/Jw6+rmf7HQT0dZR+AlfA
[not found] ` <20080618003214.GA14699-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-18 2:04 ` Matt Helsley
[not found] ` <1213754646.16057.107.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-06-18 18:00 ` sukadev-r/Jw6+rmf7HQT0dZR+AlfA
[not found] ` <20080618180025.GA25261-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-18 19:57 ` Matt Helsley
[not found] ` <1213819055.28482.50.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-06-18 21:56 ` sukadev-r/Jw6+rmf7HQT0dZR+AlfA
[not found] ` <20080618215612.GA27603-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-18 22:38 ` Matt Helsley
[not found] ` <1213828689.28482.92.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-06-18 22:55 ` sukadev-r/Jw6+rmf7HQT0dZR+AlfA
2008-06-19 7:59 ` sukadev-r/Jw6+rmf7HQT0dZR+AlfA
[not found] ` <20080619075953.GA4295-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-19 23:46 ` Matt Helsley
[not found] ` <1213919160.28482.279.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-06-20 1:54 ` sukadev-r/Jw6+rmf7HQT0dZR+AlfA
[not found] ` <20080620015410.GA13775-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2008-06-20 2:48 ` Matt Helsley
2008-06-22 21:40 ` Oren Laadan
[not found] ` <485EC6E4.4080707-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
2008-06-23 23:30 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214263828.7576.10.camel@nimitz \
--to=dave-23vcf4htsmix0ybbhkvfkdbpr1lh4cv8@public.gmane.org \
--cc=containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org \
--cc=orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.