All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lg@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jarkko.nikula@nokia.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [asoc-dev][RFC/PATCH 0/2] Generic DAPM register	modifier widget
Date: Wed, 25 Jun 2008 13:01:20 +0100	[thread overview]
Message-ID: <1214395280.3877.61.camel@localhost.localdomain> (raw)
In-Reply-To: <1214394128-7062-1-git-send-email-jarkko.nikula@nokia.com>

On Wed, 2008-06-25 at 14:42 +0300, Jarkko Nikula wrote:
> Hi
> 
> At least tlv320aic3x codec has several use cases where multiple register
> bits are needed to change when widget power state changes and where
> these are not worth/safe to expose into user space. Like mic bias
> voltage.
> 
> Currently there is one use case for this multiple bit change in tlv320aic3x:
> 
> 	SND_SOC_DAPM_MICBIAS("Mic Bias AVDD", MICBIAS_CTRL, 6, 0),
> 	SND_SOC_DAPM_MICBIAS("Mic Bias AVDD", MICBIAS_CTRL, 7, 0),
> 
> There are two problems with that:
> 
> 1. Two widgets having the same name and thus snd_soc_dapm_add_route will
>    add only first one them into audio path
> 2. Even then bits aren't modified at once and thus some fault bit
>    configuration might be present while power state is changing.
> 
> So I came with this idea of generic register modifiers widget and event
> handler for it.
> 

Any chance you could also add a little text to
Docs/sound/alsa/soc/dapm.txt for this.

Thanks

Liam

  parent reply	other threads:[~2008-06-25 12:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 11:42 [asoc-dev][RFC/PATCH 0/2] Generic DAPM register modifier widget Jarkko Nikula
2008-06-25 11:42 ` [asoc-dev][RFC/PATCH 1/2] ASoC: Add support for generic " Jarkko Nikula
2008-06-25 11:59   ` Liam Girdwood
2008-06-25 11:42 ` [asoc-dev][RFC/PATCH 2/2] ASoC: TLV320AIC3X: Use register modifier widget for mic bias Jarkko Nikula
2008-06-25 12:00   ` Liam Girdwood
2008-06-25 12:01 ` Liam Girdwood [this message]
2008-06-25 12:15   ` [asoc-dev][RFC/PATCH 0/2] Generic DAPM register modifier widget Jarkko Nikula
2008-06-25 15:40     ` Liam Girdwood
2008-06-26 10:11       ` Jarkko Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214395280.3877.61.camel@localhost.localdomain \
    --to=lg@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=jarkko.nikula@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.