All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linville@tuxdriver.com, hintak_leung@yahoo.co.uk,
	linux-wireless@vger.kernel.org
Subject: Re: [RFC] rtl8187: Realtek 8187B wireless support with	product	id0x8197/0x8189
Date: Wed, 25 Jun 2008 16:12:35 -0400	[thread overview]
Message-ID: <1214424755.9990.11.camel@dv> (raw)
In-Reply-To: <48628D9A.5090502@lwfinger.net>

On Wed, 2008-06-25 at 13:25 -0500, Larry Finger wrote:

> For the review process, I have split the patch into 5 parts. Each step 
> compiles, thus bisection will be preserved. With this change, the 
> largest of the pieces is a little under 15KiB. Is this small enough? 
> Further splitting would be a lot more difficult.

That's very impressive, actually.  Still the combined amount of the
changes makes me nervous.

> As to the quality of the patch, it barely works on my device. RX seems 
> to be OK except for the wireless statistics, but I can associate only 
> about 1 try in 10. Once I get that problem squared away, then I can 
> work on the timing. I really would like to get this into 
> wireless-testing ASAP.

I really appreciate your efforts.

> I don't have an 8187 device either, and will have to rely on someone 
> else for that part of the testing.

I've just bought a WiBee on eBay, which is said to be rtl8187 based.
Perhaps I'll be able to test it a week from now.

-- 
Regards,
Pavel Roskin

      reply	other threads:[~2008-06-25 20:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 16:59 [RFC] rtl8187: Realtek 8187B wireless support with product id0x8197/0x8189 Larry.Finger
2008-06-25 17:07 ` Johannes Berg
2008-06-25 17:21   ` Pavel Roskin
2008-06-25 17:36 ` Pavel Roskin
2008-06-25 17:44   ` Larry Finger
2008-06-25 17:57     ` Pavel Roskin
2008-06-25 18:25       ` Larry Finger
2008-06-25 20:12         ` Pavel Roskin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214424755.9990.11.camel@dv \
    --to=proski@gnu.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=hintak_leung@yahoo.co.uk \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.