From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KBfsi-0005WY-Fe for mharc-grub-devel@gnu.org; Wed, 25 Jun 2008 21:02:36 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KBfsh-0005V2-75 for grub-devel@gnu.org; Wed, 25 Jun 2008 21:02:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KBfsf-0005TN-Cv for grub-devel@gnu.org; Wed, 25 Jun 2008 21:02:34 -0400 Received: from [199.232.76.173] (port=57249 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KBfsf-0005TK-8D for grub-devel@gnu.org; Wed, 25 Jun 2008 21:02:33 -0400 Received: from ug-out-1314.google.com ([66.249.92.171]:40357) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KBfse-0003Xy-Ur for grub-devel@gnu.org; Wed, 25 Jun 2008 21:02:33 -0400 Received: by ug-out-1314.google.com with SMTP id l31so188974ugc.48 for ; Wed, 25 Jun 2008 18:02:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=DBjKoqnWq2kk6/dywBYi6T1KlCOPT/ucpSbeKrhymFk=; b=fGM0aOOuAXJtWczYF7aw900siEdD+4RC86DK5Cr91oe7FnggrldhjUmrF5NQesxhiF ugEdA/254xsrY4FKAGbSnWKSnJ3fzgqp8CJCLfT4mZBgYGo4xyIilh8iRLrkpNpzFHDu rHSfskM7Y2kEpeseTlq+TftbuUoR5yfRAydfE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=HlhSE/gqHOI8b2fSDAZglvnNAFGw/MRub1OQ3iDRpI12/edEF3AD36/7+efKat+zXs BlePzgmVfyMoxn4njyy/74qovouKjGyj9iPJGGbVmKxLeiwkcO+TyVFkOk2Ug8gV9B+w r6e2/CUQ8K3BeD2XSciXr02T+hbVkmK9y9J9Y= Received: by 10.67.23.5 with SMTP id a5mr914356ugj.89.1214442149565; Wed, 25 Jun 2008 18:02:29 -0700 (PDT) Received: from ?192.168.1.100? ( [213.37.137.93]) by mx.google.com with ESMTPS id m1sm74346uge.17.2008.06.25.18.02.27 (version=SSLv3 cipher=RC4-MD5); Wed, 25 Jun 2008 18:02:28 -0700 (PDT) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: <1214430514.11716.19.camel@dv> References: <1214430514.11716.19.camel@dv> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-x5V6pLf8oyLyfqFvMU/9" Date: Thu, 26 Jun 2008 03:02:38 +0200 Message-Id: <1214442159.24653.5.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: Failure to embed core.img is fatal now X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jun 2008 01:02:35 -0000 --=-x5V6pLf8oyLyfqFvMU/9 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable El mi=C3=A9, 25-06-2008 a las 17:48 -0400, Pavel Roskin escribi=C3=B3: > I'm also surprised that the code alternately uses dir and > DEFAULT_DIRECTORY to calculate core_path. core_path is calculated 3 > times in one function! If dir and DEFAULT_DIRECTORY are used correctly, > I suggest that two different variables are used for what is now called > core_path. The core_path variable is indeed reused throughout the code: sometimes it refers to the path as the OS and grub-setup see it, and then it's used to search for core.img as GRUB would. This can be a bit confusing (I've recently fixed a bug in that very function related to core_path construction), so I agree that two different variables ought to be used. Why not create a patch for the occasion? --=-x5V6pLf8oyLyfqFvMU/9 Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASGLqrqSl+Fbdeo72AQKkMQ//X1vNdEfbD1jIQU0WgXZO1iDra/3Dhh16 Dt4aLj9pTQNaQSYtCJImO1lXohpYjPcVu8Ztnqngdsr5ycYpVjnLM9F6KstJR9lm ODl/yiGCq+ZFuzEMa5cZxScxj641t9+fAg3w5wArNF2Nr9tZ1S5gerQL26jbsG6Z j4Lgzuka9CpBm/CezLHKdlDfefD/CskQhI7d0OIOfhpTbijG2U8mKyODwPtzsudn Ui535caBQ04GV9YwmIOG4z5//DQjjFR0S3oWT4h1Gfn2zsgiBf/4Z7kYe2XwX5S9 ybhFCbN4z+z/FQr0T4UttPv0y5NP/o6l5bCL90kTBH43Xg4zUfgdwWkTqgbTuSMh ZQKF8bufDER4Of2l98ZkHiOrFqzJ9vmBUTo5fTFlJsV0pBVACGpJ9xikC0B3SFjU Ff/S3u85Yl/e6LNRfX793CYSLuAtO6qnY/TaokWKJZSA9R9eSPtSr/fl0fcsdfmQ p67Jh2/CbadFD9+/HwgulyAxZQhTuEZdmkfejGUY4Zbf/02FbO1/VrMhAvg0nHou Ufg2J4312Kpac24rNKfwHyhG0fCqAzb1PWSeE+8PJR6Hu+B383DDcwCUbQr48R8E TlhsvziXuMLQoYstgBKCGo2xBNIJl/kcpmuVZvysPXK5lXXNevC4JjvGZs1itc9z wU2yNojPuPw= =YnwC -----END PGP SIGNATURE----- --=-x5V6pLf8oyLyfqFvMU/9--