All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Javier Martín" <lordhabbit@gmail.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] add a counter in grub_dprintf
Date: Thu, 26 Jun 2008 17:20:51 +0200	[thread overview]
Message-ID: <1214493651.24653.10.camel@localhost> (raw)
In-Reply-To: <20080626140836.GB7511@thorin>

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

El jue, 26-06-2008 a las 16:08 +0200, Robert Millan escribió:
> On Sat, Jun 21, 2008 at 04:35:07PM +0200, Javier Martín wrote:
> > 
> > Why not modify the build system to create _two_ instances of kernel.img,
> > one with and another without debugging? grub_mkimage would create the
> > normal, smaller core.img (without dprintf) for installing and embedding;
> > and store a core_dbg.img in the /boot/grub folder,
> 
> This breaks the design and forces grub-mkimage to have:
> 
>   a) knowledge about GRUB paths
> 
>   b) requirement for root perms
> 
> instead of just being an utility to generate images.  I don't think it's
> a good idea.
> 
Whoops, sorry, I meant that grub_mkimage would create two core.img
images, one per kernel.img version, and then grub_install would copy
them as usual. Then grub_setup would embed/set up the normal core.img
or the debug version based on a switch. What I propose is basically
modifying grub_mkimage to allow choosing the kernel.img file used and
then adding some lines to grub_install so that the two versions of
core.img are generated (but only the selected is embedded).

[-- Attachment #2: Esta parte del mensaje está firmada digitalmente --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

  reply	other threads:[~2008-06-26 15:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-19 13:31 [PATCH] add a counter in grub_dprintf Robert Millan
2008-06-19 18:42 ` Isaac Dupree
2008-06-21 14:19   ` Robert Millan
2008-06-21 14:35     ` Javier Martín
2008-06-21 14:51       ` Bram Diederik
2008-06-22 11:30       ` Isaac Dupree
2008-06-26 14:08       ` Robert Millan
2008-06-26 15:20         ` Javier Martín [this message]
2008-06-29 11:22           ` Robert Millan
2008-06-30 17:13             ` Pavel Roskin
2008-06-30 17:33               ` Vesa Jääskeläinen
2008-07-01 15:59                 ` Robert Millan
2008-07-01 15:59               ` Robert Millan
2008-07-01 16:01                 ` Pavel Roskin
2008-07-01 17:19                   ` Robert Millan
2008-07-02  0:13                     ` Pavel Roskin
2008-07-03 18:08 ` Marco Gerards

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214493651.24653.10.camel@localhost \
    --to=lordhabbit@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.