All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Collins <ben.collins@canonical.com>
To: v4l-dvb-maintainer@linuxtv.org
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: saa7134 duplicate device in module, but different device_data?
Date: Thu, 26 Jun 2008 13:24:53 -0400	[thread overview]
Message-ID: <1214501094.7150.29.camel@cunning> (raw)

In the saa7134 module, there are these two entries in
MODULE_DEVICE_TABLE():


        },{
                .vendor       = PCI_VENDOR_ID_PHILIPS,
                .device       = PCI_DEVICE_ID_PHILIPS_SAA7133,
                .subvendor    = 0x185b,
                .subdevice    = 0xc100,
                .driver_data  = SAA7134_BOARD_VIDEOMATE_TV,
        },{
                .vendor       = PCI_VENDOR_ID_PHILIPS,
                .device       = PCI_DEVICE_ID_PHILIPS_SAA7133,
                .subvendor    = 0x185b,
                .subdevice    = 0xc100,
                .driver_data  = SAA7134_BOARD_VIDEOMATE_TV_GOLD_PLUS,
        },{

Both will exactly match, and I assume only the first one will ever be
used, hence the second is just a wasted dupe. At least, I would assume
if not for the differing driver_data. Anyway to clear up this ambiguity?


             reply	other threads:[~2008-06-26 17:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-26 17:24 Ben Collins [this message]
2008-06-26 23:56 ` [v4l-dvb-maintainer] saa7134 duplicate device in module, but different device_data? hermann pitton
2008-06-26 23:56   ` hermann pitton
2008-06-27  0:06   ` Ben Collins
2008-06-27  0:59     ` hermann pitton
2008-06-27  0:59       ` hermann pitton
2008-06-27  1:58       ` hermann pitton
2008-06-27  1:58         ` hermann pitton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214501094.7150.29.camel@cunning \
    --to=ben.collins@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.