From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KDIF2-00062N-1Y for mharc-grub-devel@gnu.org; Mon, 30 Jun 2008 08:12:20 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KDIF0-00060W-BE for grub-devel@gnu.org; Mon, 30 Jun 2008 08:12:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KDIEx-0005y4-PF for grub-devel@gnu.org; Mon, 30 Jun 2008 08:12:17 -0400 Received: from [199.232.76.173] (port=46826 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KDIEx-0005xw-K4 for grub-devel@gnu.org; Mon, 30 Jun 2008 08:12:15 -0400 Received: from ug-out-1314.google.com ([66.249.92.175]:10571) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KDIEx-0003MP-44 for grub-devel@gnu.org; Mon, 30 Jun 2008 08:12:15 -0400 Received: by ug-out-1314.google.com with SMTP id l31so251610ugc.48 for ; Mon, 30 Jun 2008 05:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=nZ2FakdlEjBGvLJe1G3k3BoBaIgJIkEdWwBXJRJwCno=; b=LVW62u0z5G457Edfh3VJYDQOLx2x4wRo8nZ16eVYb0CZZxLGer43gt6xT1yEqBdPKT k5E26UIbN3Rc45le52WWxPZZRV7QrDiVpuAnoSDyxhUKn7mVVRCaoZLsAaO37LjThMGe oNt9SGHDY8PR/io+htOQoK1ju/uvMs4oKDi8A= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=IbRO4LmxncjJp365aaSl94Uf4u3sUaVyRXMvrYTgJuIifbmNVSkVrkFsKPJcOhP3Y+ Hua43Fynf5HXnTMb1Cog0xZs1j2Vg5i5z30Fkht8f10qiCfaqLTF+U4FKrsu6Sc0C0DC ywe4ftLXRviDeaH4yoBBCc2BQ8FYwpRURbnkQ= Received: by 10.210.25.19 with SMTP id 19mr4129410eby.27.1214827934226; Mon, 30 Jun 2008 05:12:14 -0700 (PDT) Received: from ?192.168.1.100? ( [213.37.137.93]) by mx.google.com with ESMTPS id y34sm6488750iky.10.2008.06.30.05.12.12 (version=SSLv3 cipher=RC4-MD5); Mon, 30 Jun 2008 05:12:13 -0700 (PDT) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: <4868C017.8040004@isaac.cedarswampstudios.org> References: <889404A5CBB14C15B464EDBB1AE338A8@fz> <1214765178.6942.2.camel@localhost> <1214769230.6942.11.camel@localhost> <20080629211957.GD24784@thorin> <1214794971.9353.32.camel@localhost> <4868C017.8040004@isaac.cedarswampstudios.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-dJiLFk/7xDIMVCJt8zxG" Date: Mon, 30 Jun 2008 14:12:17 +0200 Message-Id: <1214827937.9353.43.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: grub-probe detects ext4 wronly as ext2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jun 2008 12:12:18 -0000 --=-dJiLFk/7xDIMVCJt8zxG Content-Type: multipart/mixed; boundary="=-VfeCruexRaKi9HY8gvTe" --=-VfeCruexRaKi9HY8gvTe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable El lun, 30-06-2008 a las 07:14 -0400, Isaac Dupree escribi=C3=B3: > > +#define EXT3_FEATURE_INCOMPAT_RECOVER 0x0004 /* Needs recovery */ >=20 > > +#define EXT2_DRIVER_SUPPORTED_INCOMPAT ( EXT2_FEATURE_INCOMPAT_FILETYP= E ) >=20 > I suspect this will mean that journalled ext3 when the system crashed=20 > (so the filesystem "needs recovery" from the journal) won't load. (Of=20 > course, properly speaking that would load grub's code to replay the=20 > journal...) But I think that (without other changes) that would make=20 > the system unbootable every time there was a power outage? (Of course=20 > it was not guaranteed to load correctly when ignoring the journal when=20 > it needed recovery, but it was likely to work, IIUC.) >=20 > -Isaac As I said, I didn't add it because I didn't know whether recovery was supported or not. _Theoretically_ we should focus on correctness and refuse to read such a filesystem, but here goes a workaround for incompatible features that we do not support but still willingly want to ignore for the sake of "compatibility". This new version of the patch adds another macro, EXT2_DRIVER_IGNORED_INCOMPAT where we can put features that we don't fully support, but still want a filesystem with them to be mounted, like the needs_recover flag. Of course, this is risky: INCOMPAT_* features are so for a reason, but it will allow dirty ext3 filesystems to be mounted until we have a working journal implementation. I had thought of adding some kind of warning, but since GRUB mounts and umounts filesystems constantly, it just cluttered the screen and I removed it. --=-VfeCruexRaKi9HY8gvTe Content-Disposition: attachment; filename=ext4_unrecognized.diff Content-Type: text/x-patch; name=ext4_unrecognized.diff; charset=utf-8 Content-Transfer-Encoding: base64 SW5kZXg6IGZzL2V4dDIuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KUkNTIGZpbGU6IC9zb3VyY2VzL2dydWIvZ3J1 YjIvZnMvZXh0Mi5jLHYNCnJldHJpZXZpbmcgcmV2aXNpb24gMS4yNg0KZGlmZiAtdSAtcjEuMjYg ZXh0Mi5jDQotLS0gZnMvZXh0Mi5jCTE2IEp1biAyMDA4IDE5OjAyOjA3IC0wMDAwCTEuMjYNCisr KyBmcy9leHQyLmMJMzAgSnVuIDIwMDggMTI6MDc6NTYgLTAwMDANCkBAIC03MSw3ICs3MSwzNyBA QA0KICAgICAgICAgID8gRVhUMl9HT09EX09MRF9JTk9ERV9TSVpFIFwNCiAgICAgICAgICA6IGdy dWJfbGVfdG9fY3B1MTYgKGRhdGEtPnNibG9jay5pbm9kZV9zaXplKSkNCiANCi0jZGVmaW5lIEVY VDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwJMHgwMDA0DQorLyogU3VwZXJibG9jayBmaWxl c3lzdGVtIGZlYXR1cmUgZmxhZ3MgKFJXIGNvbXBhdGlibGUpICovDQorI2RlZmluZSBFWFQyX0ZF QVRVUkVfQ09NUEFUX0RJUl9QUkVBTExPQwkweDAwMDENCisjZGVmaW5lIEVYVDJfRkVBVFVSRV9D T01QQVRfSU1BR0lDX0lOT0RFUwkweDAwMDINCisjZGVmaW5lIEVYVDNfRkVBVFVSRV9DT01QQVRf SEFTX0pPVVJOQUwJCTB4MDAwNA0KKyNkZWZpbmUgRVhUMl9GRUFUVVJFX0NPTVBBVF9FWFRfQVRU UgkJMHgwMDA4DQorI2RlZmluZSBFWFQyX0ZFQVRVUkVfQ09NUEFUX1JFU0laRV9JTk9ERQkweDAw MTANCisjZGVmaW5lIEVYVDJfRkVBVFVSRV9DT01QQVRfRElSX0lOREVYCQkweDAwMjANCisvKiBT dXBlcmJsb2NrIGZpbGVzeXN0ZW0gZmVhdHVyZSBmbGFncyAoUk8gY29tcGF0aWJsZSkgKi8NCisj ZGVmaW5lIEVYVDJfRkVBVFVSRV9ST19DT01QQVRfU1BBUlNFX1NVUEVSCTB4MDAwMQ0KKyNkZWZp bmUgRVhUMl9GRUFUVVJFX1JPX0NPTVBBVF9MQVJHRV9GSUxFCTB4MDAwMg0KKyNkZWZpbmUgRVhU Ml9GRUFUVVJFX1JPX0NPTVBBVF9CVFJFRV9ESVIJMHgwMDA0DQorI2RlZmluZSBFWFQ0X0ZFQVRV UkVfUk9fQ09NUEFUX0dEVF9DU1VNCQkweDAwMTANCisjZGVmaW5lIEVYVDRfRkVBVFVSRV9ST19D T01QQVRfRElSX05MSU5LCTB4MDAyMA0KKyNkZWZpbmUgRVhUNF9GRUFUVVJFX1JPX0NPTVBBVF9F WFRSQV9JU0laRQkweDAwNDANCisvKiBTdXBlcmJsb2NrIGZpbGVzeXN0ZW0gZmVhdHVyZSBmbGFn cyAoYmFjay1pbmNvbXBhdGlibGUpICovDQorI2RlZmluZSBFWFQyX0ZFQVRVUkVfSU5DT01QQVRf Q09NUFJFU1NJT04JMHgwMDAxDQorI2RlZmluZSBFWFQyX0ZFQVRVUkVfSU5DT01QQVRfRklMRVRZ UEUJCTB4MDAwMg0KKyNkZWZpbmUgRVhUM19GRUFUVVJFX0lOQ09NUEFUX1JFQ09WRVIJCTB4MDAw NCAvKiBOZWVkcyByZWNvdmVyeSAqLw0KKyNkZWZpbmUgRVhUM19GRUFUVVJFX0lOQ09NUEFUX0pP VVJOQUxfREVWCTB4MDAwOCAvKiBKb3VybmFsIGRldmljZSAqLw0KKyNkZWZpbmUgRVhUMl9GRUFU VVJFX0lOQ09NUEFUX01FVEFfQkcJCTB4MDAxMA0KKyNkZWZpbmUgRVhUNF9GRUFUVVJFX0lOQ09N UEFUX0VYVEVOVFMJCTB4MDA0MCAvKiBleHRlbnRzIHN1cHBvcnQgKi8NCisjZGVmaW5lIEVYVDRf RkVBVFVSRV9JTkNPTVBBVF82NEJJVAkJMHgwMDgwDQorI2RlZmluZSBFWFQ0X0ZFQVRVUkVfSU5D T01QQVRfRkxFWF9CRwkJMHgwMjAwDQorDQorLyogVGhlIHNldCBvZiBiYWNrLWluY29tcGF0aWJs ZSBmZWF0dXJlcyB0aGlzIGRyaXZlciBET0VTIHN1cHBvcnQuIEFkZCAoT1IpDQorICogZmxhZ3Mg aGVyZSBhcyB0aGUgcmVsYXRlZCBmZWF0dXJlcyBhcmUgaW1wbGVtZW50ZWQgaW50byB0aGUgZHJp dmVyICovDQorI2RlZmluZSBFWFQyX0RSSVZFUl9TVVBQT1JURURfSU5DT01QQVQgKCBFWFQyX0ZF QVRVUkVfSU5DT01QQVRfRklMRVRZUEUgKQ0KKy8qIFRoZSBzZXQgb2YgYmFjay1pbmNvbXBhdGli bGUgZmVhdHVyZXMgdGhpcyBkcml2ZXIgRE9FUyBOT1Qgc3VwcG9ydCBidXQgYXJlDQorICogaWdu b3JlZCBmb3Igc29tZSBoYWNraXNoIHJlYXNvbi4gRmxhZ3MgaGVyZSBzaG91bGQgYmUgaGVyZSBf dGVtcG9yYXJpbHlfIQ0KKyAqIFJlbWVtYmVyIHRoYXQgSU5DT01QQVRfKiBmZWF0dXJlcyBhcmUg c28gZm9yIGEgcmVhc29uISAqLw0KKyNkZWZpbmUgRVhUMl9EUklWRVJfSUdOT1JFRF9JTkNPTVBB VCAoIEVYVDNfRkVBVFVSRV9JTkNPTVBBVF9SRUNPVkVSICkNCiANCiAjZGVmaW5lIEVYVDNfSk9V Uk5BTF9NQUdJQ19OVU1CRVIJMHhjMDNiMzk5OFUNCiANCkBAIC0zOTQsNiArNDI0LDExIEBADQog ICBpZiAoZ3J1Yl9sZV90b19jcHUxNiAoZGF0YS0+c2Jsb2NrLm1hZ2ljKSAhPSBFWFQyX01BR0lD KQ0KICAgICBnb3RvIGZhaWw7DQogICANCisgIC8qIENoZWNrIHRoZSBGUyBkb2Vzbid0IGhhdmUg ZmVhdHVyZSBiaXRzIGVuYWJsZWQgdGhhdCB3ZSBkb24ndCBzdXBwb3J0ICovDQorICBpZiAoZ3J1 Yl9sZV90b19jcHUzMiAoZGF0YS0+c2Jsb2NrLmZlYXR1cmVfaW5jb21wYXQpDQorICAgICAgJiB+ KEVYVDJfRFJJVkVSX1NVUFBPUlRFRF9JTkNPTVBBVCB8IEVYVDJfRFJJVkVSX0lHTk9SRURfSU5D T01QQVQpKQ0KKyAgICBnb3RvIGZhaWw7DQorICANCiAgIGRhdGEtPmRpc2sgPSBkaXNrOw0KIA0K ICAgZGF0YS0+ZGlyb3Blbi5kYXRhID0gZGF0YTsNCkBAIC00MDksNyArNDQ0LDggQEANCiAgIHJl dHVybiBkYXRhOw0KIA0KICBmYWlsOg0KLSAgZ3J1Yl9lcnJvciAoR1JVQl9FUlJfQkFEX0ZTLCAi bm90IGFuIGV4dDIgZmlsZXN5c3RlbSIpOw0KKyAgZ3J1Yl9lcnJvciAoR1JVQl9FUlJfQkFEX0ZT LCAibm90IGFuIGV4dDIgZmlsZXN5c3RlbSwgb3IgaW5jb21wYXRpYmxlIg0KKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAiZmVhdHVyZXMgZW5hYmxlZCAoZXh0ZW50cywgZXRjLikiKTsN CiAgIGdydWJfZnJlZSAoZGF0YSk7DQogICByZXR1cm4gMDsNCiB9DQo= --=-VfeCruexRaKi9HY8gvTe-- --=-dJiLFk/7xDIMVCJt8zxG Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASGjNoKSl+Fbdeo72AQIePxAArmGAP//4hGOIJ+GYs3BLrzZz1+cm2JME OZZg7q6QAK8s9/s38drB34dGeCw5Y0Zzfj9xGwMYiSh1aMpqLqkJ8Wf/2R0KvXu8 jFLb8sEAqc9p90akg3b0DDEXnxtwY4ggDYlLPKBGzSuVMOKmkfcmB5w8ocFOKGlf lpJ2T/ynaMQ8PPryq+9j51WAgXvA1dsmXmzoicZsg/roj0nqjgTs4g3AmEybBUB+ dwFGIhK+jh28T3ix9B3xQSYW45p+hvc/LbWwUZ60/zGRySkrp/N6iTSTUPYslWPV IIP0fxkWFHnyKEucQd9u91rWw/B5ORs8du6x0hRTBriYme0/yrGujft1GDcsAvh0 A0ozOybYr2GZQy8bR4kcFeqzJOliokLs3ReIuxpUbXTdW/aFGzu/UkYTDwJIREKV XElSn81HOq4/dHFMDrN2G6zGL0TzhCevarRYVvO6nLIAaaUnAeNdDK5OPWQmcoZG UbMu4kFCbc363XfUeO6+gKVEZvZpz3FqwcgWgO3BnABtRKaioFehJ2dKhHDUciAj prMc1CORwdVwcNmjkxNOyi3p/iOdad3h3uRfMqMxj5Z5bKrGFVDXLSirhAK+6tt7 dFmiSoMnC5TchBMpTzGjTubPIoV5fv1Ia9DZJMy6Ht1hMVe7vsVFFj1Q0Wg1wp/I NphqEf2naUY= =C1hM -----END PGP SIGNATURE----- --=-dJiLFk/7xDIMVCJt8zxG--