From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KDMwe-0005iO-DW for mharc-grub-devel@gnu.org; Mon, 30 Jun 2008 13:13:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KDMwc-0005gc-Oy for grub-devel@gnu.org; Mon, 30 Jun 2008 13:13:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KDMwb-0005eW-HP for grub-devel@gnu.org; Mon, 30 Jun 2008 13:13:37 -0400 Received: from [199.232.76.173] (port=54517 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KDMwb-0005eF-Bv for grub-devel@gnu.org; Mon, 30 Jun 2008 13:13:37 -0400 Received: from c60.cesmail.net ([216.154.195.49]:35706) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KDMwb-0001Xx-6e for grub-devel@gnu.org; Mon, 30 Jun 2008 13:13:37 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 30 Jun 2008 13:13:35 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id C3CF8618F22 for ; Mon, 30 Jun 2008 13:13:35 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080629112241.GA2347@thorin> References: <20080619133147.GA5018@thorin> <485AA89A.5030404@isaac.cedarswampstudios.org> <20080621141907.GC24465@thorin> <1214058907.10018.39.camel@localhost> <20080626140836.GB7511@thorin> <1214493651.24653.10.camel@localhost> <20080629112241.GA2347@thorin> Content-Type: text/plain; charset=ISO-8859-1 Date: Mon, 30 Jun 2008 13:13:34 -0400 Message-Id: <1214846014.17554.6.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 8bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] add a counter in grub_dprintf X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jun 2008 17:13:39 -0000 On Sun, 2008-06-29 at 13:22 +0200, Robert Millan wrote: > On Thu, Jun 26, 2008 at 05:20:51PM +0200, Javier Martín wrote: > > Whoops, sorry, I meant that grub_mkimage would create two core.img > > images, one per kernel.img version, and then grub_install would copy > > them as usual. Then grub_setup would embed/set up the normal core.img > > or the debug version based on a switch. What I propose is basically > > modifying grub_mkimage to allow choosing the kernel.img file used and > > then adding some lines to grub_install so that the two versions of > > core.img are generated (but only the selected is embedded). > > Ah; then it sounds fine, I guess. Sorry for entering this discussion so late. I can tell from my experience that most debug code is only useful to debug once specific problem. Once the problem is fixed, the debug code is not needed. If another problem is found, then some new debug code should be written to debug that problem. Generic debug code may be useful to get information from users if only they can reproduce the problem. But even then, if may be better to add a few lines to test certain assumptions rather than try to glean useful pieces of information from a long generic log. Adding a complicated mechanism for having debug and non-debug images looks like an overkill to me. It could create more problems than it would fix. -- Regards, Pavel Roskin