All of lore.kernel.org
 help / color / mirror / Atom feed
From: Travis Place <wishie@wishie.net>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Add some system information to	alsa-info.sh output
Date: Tue, 01 Jul 2008 03:36:00 +1000	[thread overview]
Message-ID: <1214847360.11032.9.camel@temp-fallen> (raw)
In-Reply-To: <20080630164210.GC21804@sirena.org.uk>

I think i was a bit quick/excited about getting this info in
there..Tested on my 2 machines here (both running 2.6.24 though) without
issues.. Will have to look into it further (after taking your advice)
and rework this patch.

On Mon, 2008-06-30 at 17:42 +0100, Mark Brown wrote:
> On Tue, Jul 01, 2008 at 02:31:37AM +1000, Travis Place wrote:
> 
> > +if [ -d $SYSFS ]
> > +then
> > +BOARD_VENDOR=`cat /sys/devices/virtual/dmi/id/board_vendor`
> > +PRODUCT_VERSION=`cat /sys/devices/virtual/dmi/id/product_version`
> > +PRODUCT_NAME=`cat /sys/devices/virtual/dmi/id/product_name`
> 
> This produces visible errors if the information isn't present (which
> would be reasonable enough).  It might be better to check for errors and
> include something about being unable to read DMI information in the
> report - that'd be a bit less scary.
> 
> Also, on my system the DMI information is under /sys/class/dmi rather
> than /sys/devices/virtual (this is with 2.6.25).

This will certainly be a pain, if the info keep moving around.. unless
we do some quick 'search' for the 'dmi' dir.
> 
> > +fi
> 
> How about bios_vendor, bios_date and bios_version as well?
> 
How useful is the BIOS information going to be, in most cases ?

> For embedded devices the relevant information is often in /proc/cpuinfo
> so it might be worth adding that too.

Can i get an example output or 'cpuinfo' on an embedded device (if you
have one available) so i can see what im looking for.

Thanks,
Travis Place

  reply	other threads:[~2008-06-30 17:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30 16:31 [PATCH] Add some system information to alsa-info.sh output Travis Place
2008-06-30 16:42 ` Mark Brown
2008-06-30 17:36   ` Travis Place [this message]
2008-07-01  9:34     ` Mark Brown
2008-07-01  9:50       ` Takashi Iwai
2008-07-01  9:52         ` Mark Brown
2008-07-01  9:48     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214847360.11032.9.camel@temp-fallen \
    --to=wishie@wishie.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.