From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KDQfm-0005W9-Rh for mharc-grub-devel@gnu.org; Mon, 30 Jun 2008 17:12:30 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KDQfk-0005Vg-KK for grub-devel@gnu.org; Mon, 30 Jun 2008 17:12:28 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KDQfi-0005VU-7Z for grub-devel@gnu.org; Mon, 30 Jun 2008 17:12:27 -0400 Received: from [199.232.76.173] (port=56733 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KDQfi-0005VR-2P for grub-devel@gnu.org; Mon, 30 Jun 2008 17:12:26 -0400 Received: from c60.cesmail.net ([216.154.195.49]:50015) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KDQfi-0007t4-24 for grub-devel@gnu.org; Mon, 30 Jun 2008 17:12:26 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 30 Jun 2008 17:12:24 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 94F9D618F22 for ; Mon, 30 Jun 2008 17:12:24 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1214791114.9353.4.camel@localhost> References: <1214791114.9353.4.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1 Date: Mon, 30 Jun 2008 17:12:23 -0400 Message-Id: <1214860343.19717.3.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 8bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Small fix in grub-setup X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jun 2008 21:12:29 -0000 On Mon, 2008-06-30 at 03:58 +0200, Javier Martín wrote: > Here goes a small fix to a grub-setup error that has driven /me crazy > for the last 4 hours: in the recent split between core_path and > core_path_dev, one occurrence of the former that should have been turned > into the latter was not, thus making grub-setup spit lots of nonsensical > (to me) "error: file not found" messages. I spent a big deal of time > trying to debug the wrong piece of code, since I stubbornly thought that > the error was in the "read-and-check" loop, while it really was later in > the file... Sigh I understand you were trying to install GRUB to a non-default root. I'm sorry for not testing that. > The fix is so simple that I post it directly here. If a ChangeLog entry > is necessary, I'd propose "complete core_path variable split" or > something along that lines. Actually, it's a real bug, so ChangeLog shouldn't be worded like it's another cosmetic change like the original patch was meant to be. I've applied your patch. Thank you! -- Regards, Pavel Roskin