From: David Howells <dhowells@redhat.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: dhowells@redhat.com, torvalds@linux-foundation.org,
linux-kernel@vger.kernel.org, linux-next@vger.kernel.org,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>
Subject: Re: [PATCH v2] avr32: fix nop compile fails from system.h split up
Date: Wed, 04 Apr 2012 05:01:41 +0100 [thread overview]
Message-ID: <12149.1333512101@redhat.com> (raw)
In-Reply-To: <1333494844-3802-1-git-send-email-paul.gortmaker@windriver.com>
Paul Gortmaker <paul.gortmaker@windriver.com> wrote:
> To fix:
>
> In file included from kernel/exit.c:61:
> arch/avr32/include/asm/mmu_context.h: In function 'enable_mmu':
> arch/avr32/include/asm/mmu_context.h:135: error: implicit
> declaration of function 'nop'
>
> It needs an include of the new file created in:
>
> commit ae473946586680b01c13975a3b674de23ad7c93e
>
> "Disintegrate asm/system.h for AVR32"
>
> But since that file only contains "nop", and since other
> arch already have precedent of putting nop in asm/barrier.h
> we should just delete the new file and put nop in barrier.h
>
> Suggested-by: David Howells <dhowells@redhat.com>
> Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2012-04-04 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 23:14 [PATCH v2] avr32: fix nop compile fails from system.h split up Paul Gortmaker
2012-04-04 4:01 ` David Howells [this message]
2012-04-07 10:10 ` Hans-Christian Egtvedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12149.1333512101@redhat.com \
--to=dhowells@redhat.com \
--cc=egtvedt@samfundet.no \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.