From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KDig8-0003UM-TD for mharc-grub-devel@gnu.org; Tue, 01 Jul 2008 12:26:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KDig6-0003Tw-O7 for grub-devel@gnu.org; Tue, 01 Jul 2008 12:26:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KDig1-0003TE-Tw for grub-devel@gnu.org; Tue, 01 Jul 2008 12:26:02 -0400 Received: from [199.232.76.173] (port=38368 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KDig1-0003TB-NS for grub-devel@gnu.org; Tue, 01 Jul 2008 12:25:57 -0400 Received: from c60.cesmail.net ([216.154.195.49]:26296) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KDify-0003jk-RG for grub-devel@gnu.org; Tue, 01 Jul 2008 12:25:57 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 01 Jul 2008 12:25:46 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id E7219618F22 for ; Tue, 1 Jul 2008 12:25:45 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080701160827.GF6985@thorin> References: <889404A5CBB14C15B464EDBB1AE338A8@fz> <1214765178.6942.2.camel@localhost> <1214769230.6942.11.camel@localhost> <20080629211957.GD24784@thorin> <1214794971.9353.32.camel@localhost> <4868C017.8040004@isaac.cedarswampstudios.org> <1214827937.9353.43.camel@localhost> <20080701160827.GF6985@thorin> Content-Type: text/plain Date: Tue, 01 Jul 2008 12:25:45 -0400 Message-Id: <1214929545.13432.19.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: grub-probe detects ext4 wronly as ext2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jul 2008 16:26:03 -0000 On Tue, 2008-07-01 at 18:08 +0200, Robert Millan wrote: > > We must not quit if the journal flag is set, even if we don't handle > > it. grub-setup runs in a active system, the journal wouldn't be empty. > > If we just quit, we can't even install. > > I think we should be more conservative here, and only reject a filesystem > when we know _for sure_ that GRUB won't be able to access it. Otherwise > we may be disabling filesystems that are probably fine. I agree. Rules for read-only access should be more permissive than those for read-write access. Rules for bootloader read-only access should be relaxed even more. For example, we don't really care about permissions and timestamps. It would be nice to get them right, but failure to boot because of a nanosecond timestamp would be too much. Likewise, we don't care if some files are compressed or use a file size representation we don't support and long as the files we need don't use it. -- Regards, Pavel Roskin