From: Zhu Yi <yi.zhu@intel.com>
To: Ivo van Doorn <ivdoorn@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
Adel Gadllah <adel.gadllah@gmail.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Fabien Crespel <fcrespel@gmail.com>
Subject: Re: [PATCH] iwlwifi: remove input device from iwl3945
Date: Wed, 02 Jul 2008 14:25:14 +0800 [thread overview]
Message-ID: <1214979914.14590.453.camel@debian.sh.intel.com> (raw)
In-Reply-To: <200807011613.43501.IvDoorn@gmail.com>
On Tue, 2008-07-01 at 16:13 +0200, Ivo van Doorn wrote:
> How is the changed rfkill state of the driver reported to rfkill?
> I see that the patch to remove the input device doesn't remove the
> call input_report_key() by which I assume such call was never made.
> This would mean rfkill support in iwlwifi has always been broken and
> the entire input device wasn't used at all.
Yes, we don't use the input device before and I believe we shouldn't.
The patch just removes it.
> From what I gather from the code itself is the function responsible
> for changing the state iwl_rfkill_set_hw_state() but that only updates
> the state, and doesn't report anything to the rfkill layer.
Right, we will switch to use rfkill_force_state() instead.
Thanks,
-yi
prev parent reply other threads:[~2008-07-02 6:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 7:44 [PATCH 1/1] iwlwifi: fix error path of iwl_rfkill_init Tomas Winkler
2008-07-01 7:44 ` [PATCH 1/2] mac80211: add bar capability Tomas Winkler
2008-07-01 7:44 ` [PATCH 1/1] mac80211: fix warning: unused variable ifsta Tomas Winkler
2008-07-01 7:44 ` [PATCH 2/2] iwlwifi: request Tx of bar if necessary Tomas Winkler
2008-07-01 8:04 ` [PATCH 1/1] mac80211: fix warning: unused variable ifsta Johannes Berg
2008-07-01 8:03 ` [PATCH 1/2] mac80211: add bar capability Johannes Berg
2008-07-01 8:30 ` Tomas Winkler
2008-07-01 8:52 ` Johannes Berg
2008-07-01 9:17 ` Tomas Winkler
2008-07-01 9:41 ` [PATCH 1/1] iwlwifi: fix error path of iwl_rfkill_init Zhu, Yi
2008-07-01 13:23 ` [PATCH] iwlwifi: remove input device from iwl3945 John W. Linville
2008-07-01 14:13 ` Ivo van Doorn
2008-07-02 6:25 ` Zhu Yi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214979914.14590.453.camel@debian.sh.intel.com \
--to=yi.zhu@intel.com \
--cc=adel.gadllah@gmail.com \
--cc=fcrespel@gmail.com \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.