From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KETZB-0001yk-NU for mharc-grub-devel@gnu.org; Thu, 03 Jul 2008 14:30:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KETZ9-0001yK-JI for grub-devel@gnu.org; Thu, 03 Jul 2008 14:29:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KETZ8-0001y7-8L for grub-devel@gnu.org; Thu, 03 Jul 2008 14:29:59 -0400 Received: from [199.232.76.173] (port=60845 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KETZ8-0001xu-05 for grub-devel@gnu.org; Thu, 03 Jul 2008 14:29:58 -0400 Received: from c60.cesmail.net ([216.154.195.49]:23654) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KETZ7-0005Bl-U3 for grub-devel@gnu.org; Thu, 03 Jul 2008 14:29:58 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 03 Jul 2008 14:29:56 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id CC36C618F22 for ; Thu, 3 Jul 2008 14:29:56 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <87bq1e7so2.fsf@xs4all.nl> References: <1214964880.7362.17.camel@dv> <1214966028.9353.95.camel@localhost> <20080702002031.7gkuoel14wg80c0k-cebfxv@webmail.spamcop.net> <486BBEF1.6000105@nic.fi> <1215021108.29069.4.camel@dv> <87bq1e7so2.fsf@xs4all.nl> Content-Type: text/plain Date: Thu, 03 Jul 2008 14:29:55 -0400 Message-Id: <1215109795.4585.17.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Eliminating grub_size_t X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jul 2008 18:29:59 -0000 On Thu, 2008-07-03 at 20:02 +0200, Marco Gerards wrote: > > I know what it is. I believe int should be as good as size_t for most > > purposes is we are not working with very large structures or read > > gigabytes of data from files at once. > > Perhaps, but it doesn't hurt either. I think it is a good thing to > have a type such that it is clear what kind of variable is used. I mean, we can have the type, but make it 32-bit on all systems. Anyway, the warnings have been fixed. In some cases, grub_size_t was used for offsets, which is wrong because we want to support large files on 32-bit systems. I think I'll try to make grub_size_t 32-bit everywhere and see if it's going to make any difference or help discover some issues. -- Regards, Pavel Roskin