From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95CF1C27C76 for ; Sat, 28 Jan 2023 16:48:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229530AbjA1Qsw (ORCPT ); Sat, 28 Jan 2023 11:48:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234562AbjA1Qsv (ORCPT ); Sat, 28 Jan 2023 11:48:51 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA4A92917D for ; Sat, 28 Jan 2023 08:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674924484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I1EjAIx8G7GhvdK7BBuhDAeV72p2jMNx9oprxbDgh0U=; b=cnMowFjW4BZitNwDlZynJRgzxQQn5OuMj1Z1JzMv/K8KYoEQrFRbsBV+1+3qPsvzAlq33J hh6NotfILkYYLFDcdyc2jMJNSY70Qo7x8rUkJC72IchJnGut2T4aTOhBCEgtXa7he3k6dD NvulspZm2dYKYhre2Y1a521Zsyr9KVk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-274-uGIAixPTNFWHG9av_Chc4Q-1; Sat, 28 Jan 2023 11:47:58 -0500 X-MC-Unique: uGIAixPTNFWHG9av_Chc4Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 30A03185A78B; Sat, 28 Jan 2023 16:47:58 +0000 (UTC) Received: from x2.localnet (unknown [10.22.8.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 82425400F8F0; Sat, 28 Jan 2023 16:47:57 +0000 (UTC) From: Steve Grubb To: Jens Axboe , Paul Moore Cc: Richard Guy Briggs , Linux-Audit Mailing List , LKML , io-uring@vger.kernel.org, Eric Paris , Stefan Roesch , Christian Brauner , Pavel Begunkov Subject: Re: [PATCH v1 0/2] two suggested iouring op audit updates Date: Sat, 28 Jan 2023 11:47:56 -0500 Message-ID: <12151218.O9o76ZdvQC@x2> Organization: Red Hat In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: io-uring@vger.kernel.org On Friday, January 27, 2023 5:53:24 PM EST Paul Moore wrote: > On Fri, Jan 27, 2023 at 5:46 PM Jens Axboe wrote: > > On 1/27/23 3:38=E2=80=AFPM, Paul Moore wrote: > > > On Fri, Jan 27, 2023 at 2:43 PM Jens Axboe wrote: > > >> On 1/27/23 12:42=E2=80=AFPM, Paul Moore wrote: > > >>> On Fri, Jan 27, 2023 at 12:40 PM Jens Axboe wrote: > > >>>> On 1/27/23 10:23=E2=80=AFAM, Richard Guy Briggs wrote: > > >>>>> A couple of updates to the iouring ops audit bypass selections > > >>>>> suggested in consultation with Steve Grubb. > > >>>>>=20 > > >>>>> Richard Guy Briggs (2): > > >>>>> io_uring,audit: audit IORING_OP_FADVISE but not IORING_OP_MADVI= SE > > >>>>> io_uring,audit: do not log IORING_OP_*GETXATTR > > >>>>> =20 > > >>>>> io_uring/opdef.c | 4 +++- > > >>>>> 1 file changed, 3 insertions(+), 1 deletion(-) > > >>>>=20 > > >>>> Look fine to me - we should probably add stable to both of them, > > >>>> just to keep things consistent across releases. I can queue them up > > >>>> for 6.3. > > >>>=20 > > >>> Please hold off until I've had a chance to look them over ... > > >>=20 > > >> I haven't taken anything yet, for things like this I always let it > > >> simmer until people have had a chance to do so. > > >=20 > > > Thanks. FWIW, that sounds very reasonable to me, but I've seen lots > > > of different behaviors across subsystems and wanted to make sure we > > > were on the same page. > >=20 > > Sounds fair. BTW, can we stop CC'ing closed lists on patch > > submissions? Getting these: > >=20 > > Your message to Linux-audit awaits moderator approval > >=20 > > on every reply is really annoying. >=20 > We kinda need audit related stuff on the linux-audit list, that's our > mailing list for audit stuff. >=20 > However, I agree that it is crap that the linux-audit list is > moderated, but unfortunately that isn't something I control (I haven't > worked for RH in years, and even then the list owner was really weird > about managing the list). Occasionally I grumble about moving the > kernel audit development to a linux-audit list on vger but haven't > bothered yet, perhaps this is as good a reason as any. >=20 > Richard, Steve - any chance of opening the linux-audit list? Unfortunately, it really has to be this way. I deleted 10 spam emails=20 yesterday. It seems like some people subscribed to this list are compromise= d.=20 Because everytime there is a legit email, it's followed in a few seconds by= a=20 spam email. Anyways, all legit email will be approved without needing to be subscribed. =2DSteve From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9AFA2C27C76 for ; Sat, 28 Jan 2023 16:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674924485; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=pyiDnoL0Tk3x88xcPhsKGudH4h1zKf64SaZtwRr6Vho=; b=KP8TOuX9BW5pjZe1v2W46fcndkOw0bflXbqwqOz+5AcflJJTw2BIV8CgoNBC5Q6KLzD8Sp IkD3mYVkFNNDQKopx2VDW6vLUugj27anRFXKKlRkGBX4tno77FIt5BhFINjRi8z471OVOC mlKDea0YTuviUL0upd0anRkBDpH4nzU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-394-sgf9hPXmPJS5Wye8GMru9g-1; Sat, 28 Jan 2023 11:48:02 -0500 X-MC-Unique: sgf9hPXmPJS5Wye8GMru9g-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5167C800B30; Sat, 28 Jan 2023 16:48:01 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id C8E0B492B01; Sat, 28 Jan 2023 16:47:59 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id A20401946588; Sat, 28 Jan 2023 16:47:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 761EA1946587 for ; Sat, 28 Jan 2023 16:47:58 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id 33E4C400D795; Sat, 28 Jan 2023 16:47:58 +0000 (UTC) Received: from x2.localnet (unknown [10.22.8.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 82425400F8F0; Sat, 28 Jan 2023 16:47:57 +0000 (UTC) From: Steve Grubb To: Jens Axboe , Paul Moore Subject: Re: [PATCH v1 0/2] two suggested iouring op audit updates Date: Sat, 28 Jan 2023 11:47:56 -0500 Message-ID: <12151218.O9o76ZdvQC@x2> Organization: Red Hat In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Brauner , Richard Guy Briggs , LKML , Pavel Begunkov , Linux-Audit Mailing List , Stefan Roesch , Eric Paris , io-uring@vger.kernel.org Errors-To: linux-audit-bounces@redhat.com Sender: "Linux-audit" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gRnJpZGF5LCBKYW51YXJ5IDI3LCAyMDIzIDU6NTM6MjQgUE0gRVNUIFBhdWwgTW9vcmUgd3Jv dGU6Cj4gT24gRnJpLCBKYW4gMjcsIDIwMjMgYXQgNTo0NiBQTSBKZW5zIEF4Ym9lIDxheGJvZUBr ZXJuZWwuZGs+IHdyb3RlOgo+ID4gT24gMS8yNy8yMyAzOjM44oCvUE0sIFBhdWwgTW9vcmUgd3Jv dGU6Cj4gPiA+IE9uIEZyaSwgSmFuIDI3LCAyMDIzIGF0IDI6NDMgUE0gSmVucyBBeGJvZSA8YXhi b2VAa2VybmVsLmRrPiB3cm90ZToKPiA+ID4+IE9uIDEvMjcvMjMgMTI6NDLigK9QTSwgUGF1bCBN b29yZSB3cm90ZToKPiA+ID4+PiBPbiBGcmksIEphbiAyNywgMjAyMyBhdCAxMjo0MCBQTSBKZW5z IEF4Ym9lIDxheGJvZUBrZXJuZWwuZGs+IHdyb3RlOgo+ID4gPj4+PiBPbiAxLzI3LzIzIDEwOjIz 4oCvQU0sIFJpY2hhcmQgR3V5IEJyaWdncyB3cm90ZToKPiA+ID4+Pj4+IEEgY291cGxlIG9mIHVw ZGF0ZXMgdG8gdGhlIGlvdXJpbmcgb3BzIGF1ZGl0IGJ5cGFzcyBzZWxlY3Rpb25zCj4gPiA+Pj4+ PiBzdWdnZXN0ZWQgaW4gY29uc3VsdGF0aW9uIHdpdGggU3RldmUgR3J1YmIuCj4gPiA+Pj4+PiAK PiA+ID4+Pj4+IFJpY2hhcmQgR3V5IEJyaWdncyAoMik6Cj4gPiA+Pj4+PiAgIGlvX3VyaW5nLGF1 ZGl0OiBhdWRpdCBJT1JJTkdfT1BfRkFEVklTRSBidXQgbm90IElPUklOR19PUF9NQURWSVNFCj4g PiA+Pj4+PiAgIGlvX3VyaW5nLGF1ZGl0OiBkbyBub3QgbG9nIElPUklOR19PUF8qR0VUWEFUVFIK PiA+ID4+Pj4+ICAKPiA+ID4+Pj4+ICBpb191cmluZy9vcGRlZi5jIHwgNCArKystCj4gPiA+Pj4+ PiAgMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gPj4+ PiAKPiA+ID4+Pj4gTG9vayBmaW5lIHRvIG1lIC0gd2Ugc2hvdWxkIHByb2JhYmx5IGFkZCBzdGFi bGUgdG8gYm90aCBvZiB0aGVtLAo+ID4gPj4+PiBqdXN0IHRvIGtlZXAgdGhpbmdzIGNvbnNpc3Rl bnQgYWNyb3NzIHJlbGVhc2VzLiBJIGNhbiBxdWV1ZSB0aGVtIHVwCj4gPiA+Pj4+IGZvciA2LjMu Cj4gPiA+Pj4gCj4gPiA+Pj4gUGxlYXNlIGhvbGQgb2ZmIHVudGlsIEkndmUgaGFkIGEgY2hhbmNl IHRvIGxvb2sgdGhlbSBvdmVyIC4uLgo+ID4gPj4gCj4gPiA+PiBJIGhhdmVuJ3QgdGFrZW4gYW55 dGhpbmcgeWV0LCBmb3IgdGhpbmdzIGxpa2UgdGhpcyBJIGFsd2F5cyBsZXQgaXQKPiA+ID4+IHNp bW1lciB1bnRpbCBwZW9wbGUgaGF2ZSBoYWQgYSBjaGFuY2UgdG8gZG8gc28uCj4gPiA+IAo+ID4g PiBUaGFua3MuICBGV0lXLCB0aGF0IHNvdW5kcyB2ZXJ5IHJlYXNvbmFibGUgdG8gbWUsIGJ1dCBJ J3ZlIHNlZW4gbG90cwo+ID4gPiBvZiBkaWZmZXJlbnQgYmVoYXZpb3JzIGFjcm9zcyBzdWJzeXN0 ZW1zIGFuZCB3YW50ZWQgdG8gbWFrZSBzdXJlIHdlCj4gPiA+IHdlcmUgb24gdGhlIHNhbWUgcGFn ZS4KPiA+IAo+ID4gU291bmRzIGZhaXIuIEJUVywgY2FuIHdlIHN0b3AgQ0MnaW5nIGNsb3NlZCBs aXN0cyBvbiBwYXRjaAo+ID4gc3VibWlzc2lvbnM/IEdldHRpbmcgdGhlc2U6Cj4gPiAKPiA+IFlv dXIgbWVzc2FnZSB0byBMaW51eC1hdWRpdCBhd2FpdHMgbW9kZXJhdG9yIGFwcHJvdmFsCj4gPiAK PiA+IG9uIGV2ZXJ5IHJlcGx5IGlzIHJlYWxseSBhbm5veWluZy4KPiAKPiBXZSBraW5kYSBuZWVk IGF1ZGl0IHJlbGF0ZWQgc3R1ZmYgb24gdGhlIGxpbnV4LWF1ZGl0IGxpc3QsIHRoYXQncyBvdXIK PiBtYWlsaW5nIGxpc3QgZm9yIGF1ZGl0IHN0dWZmLgo+IAo+IEhvd2V2ZXIsIEkgYWdyZWUgdGhh dCBpdCBpcyBjcmFwIHRoYXQgdGhlIGxpbnV4LWF1ZGl0IGxpc3QgaXMKPiBtb2RlcmF0ZWQsIGJ1 dCB1bmZvcnR1bmF0ZWx5IHRoYXQgaXNuJ3Qgc29tZXRoaW5nIEkgY29udHJvbCAoSSBoYXZlbid0 Cj4gd29ya2VkIGZvciBSSCBpbiB5ZWFycywgYW5kIGV2ZW4gdGhlbiB0aGUgbGlzdCBvd25lciB3 YXMgcmVhbGx5IHdlaXJkCj4gYWJvdXQgbWFuYWdpbmcgdGhlIGxpc3QpLiAgT2NjYXNpb25hbGx5 IEkgZ3J1bWJsZSBhYm91dCBtb3ZpbmcgdGhlCj4ga2VybmVsIGF1ZGl0IGRldmVsb3BtZW50IHRv IGEgbGludXgtYXVkaXQgbGlzdCBvbiB2Z2VyIGJ1dCBoYXZlbid0Cj4gYm90aGVyZWQgeWV0LCBw ZXJoYXBzIHRoaXMgaXMgYXMgZ29vZCBhIHJlYXNvbiBhcyBhbnkuCj4gCj4gUmljaGFyZCwgU3Rl dmUgLSBhbnkgY2hhbmNlIG9mIG9wZW5pbmcgdGhlIGxpbnV4LWF1ZGl0IGxpc3Q/CgpVbmZvcnR1 bmF0ZWx5LCBpdCByZWFsbHkgaGFzIHRvIGJlIHRoaXMgd2F5LiBJIGRlbGV0ZWQgMTAgc3BhbSBl bWFpbHMgCnllc3RlcmRheS4gSXQgc2VlbXMgbGlrZSBzb21lIHBlb3BsZSBzdWJzY3JpYmVkIHRv IHRoaXMgbGlzdCBhcmUgY29tcHJvbWlzZWQuIApCZWNhdXNlIGV2ZXJ5dGltZSB0aGVyZSBpcyBh IGxlZ2l0IGVtYWlsLCBpdCdzIGZvbGxvd2VkIGluIGEgZmV3IHNlY29uZHMgYnkgYSAKc3BhbSBl bWFpbC4KCkFueXdheXMsIGFsbCBsZWdpdCBlbWFpbCB3aWxsIGJlIGFwcHJvdmVkIHdpdGhvdXQg bmVlZGluZyB0byBiZSBzdWJzY3JpYmVkLgoKLVN0ZXZlCgoKLS0KTGludXgtYXVkaXQgbWFpbGlu ZyBsaXN0CkxpbnV4LWF1ZGl0QHJlZGhhdC5jb20KaHR0cHM6Ly9saXN0bWFuLnJlZGhhdC5jb20v bWFpbG1hbi9saXN0aW5mby9saW51eC1hdWRpdAo=