From: <gregkh@suse.de>
To: oliver@neukum.org, gregkh@suse.de, greg@kroah.com,
linux-kernel@vger.kernel.org, oneukum@suse.de,
randy.dunlap@oracle.com, sfr@canb.auug.org.au,
stern@rowland.harvard.edu
Subject: patch usb-fix-build-error-in-cdc-acm-for-config_pm-n.patch added to gregkh-2.6 tree
Date: Thu, 03 Jul 2008 15:52:48 -0700 [thread overview]
Message-ID: <12151255682099@kroah.org> (raw)
In-Reply-To: <200807011910.09251.oliver@neukum.org>
This is a note to let you know that I've just added the patch titled
Subject: USB: fix build error in cdc-acm for CONFIG_PM=n
to my gregkh-2.6 tree. Its filename is
usb-fix-build-error-in-cdc-acm-for-config_pm-n.patch
This tree can be found at
http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
>From oliver@neukum.org Thu Jul 3 15:36:51 2008
From: Oliver Neukum <oliver@neukum.org>
Date: Tue, 1 Jul 2008 19:10:08 +0200
Subject: USB: fix build error in cdc-acm for CONFIG_PM=n
To: Greg KH <greg@kroah.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>, Alan Stern <stern@rowland.harvard.edu>, Stephen Rothwell <sfr@canb.auug.org.au>, linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Message-ID: <200807011910.09251.oliver@neukum.org>
Content-Disposition: inline
Here's the fix. cdc-wdm has the same problem. The fix is the same.
Signed-off-by: Oliver Neukum <oneukum@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/usb/class/cdc-acm.c | 7 +++++++
drivers/usb/class/cdc-wdm.c | 4 ++++
2 files changed, 11 insertions(+)
--- a/drivers/usb/class/cdc-acm.c
+++ b/drivers/usb/class/cdc-acm.c
@@ -1255,6 +1255,7 @@ static void acm_disconnect(struct usb_in
tty_hangup(acm->tty);
}
+#ifdef CONFIG_PM
static int acm_suspend(struct usb_interface *intf, pm_message_t message)
{
struct acm *acm = usb_get_intfdata(intf);
@@ -1320,6 +1321,8 @@ err_out:
mutex_unlock(&acm->mutex);
return rv;
}
+
+#endif /* CONFIG_PM */
/*
* USB driver structure.
*/
@@ -1375,10 +1378,14 @@ static struct usb_driver acm_driver = {
.name = "cdc_acm",
.probe = acm_probe,
.disconnect = acm_disconnect,
+#ifdef CONFIG_PM
.suspend = acm_suspend,
.resume = acm_resume,
+#endif
.id_table = acm_ids,
+#ifdef CONFIG_PM
.supports_autosuspend = 1,
+#endif
};
/*
--- a/drivers/usb/class/cdc-wdm.c
+++ b/drivers/usb/class/cdc-wdm.c
@@ -750,12 +750,16 @@ static int wdm_suspend(struct usb_interf
dev_dbg(&desc->intf->dev, "wdm%d_suspend\n", intf->minor);
mutex_lock(&desc->plock);
+#ifdef CONFIG_PM
if (interface_to_usbdev(desc->intf)->auto_pm && test_bit(WDM_IN_USE, &desc->flags)) {
rv = -EBUSY;
} else {
+#endif
cancel_work_sync(&desc->rxwork);
kill_urbs(desc);
+#ifdef CONFIG_PM
}
+#endif
mutex_unlock(&desc->plock);
return rv;
Patches currently in gregkh-2.6 which might be from oliver@neukum.org are
bad/ldp.next/usb-add-option-hso-driver.patch
usb/usb-fix-double-kfree-in-ipaq-in-error-case.patch
usb/usb-cdc-wdm-cleanup.patch
usb/usb-fix-build-error-in-cdc-acm-for-config_pm-n.patch
usb/usb-additional-power-savings-for-cdc-acm-devices-that-support-remote-wakeup.patch
usb/usb-autosuspend-for-cdc-wdm.patch
usb/usb-fix-disconnect-bug-in-cdc-acm.patch
usb/usb-fix-usb-serial-pm-counter-decrement-for-disconnected-interfaces.patch
usb.current/usb-fix-cdc-acm-resume.patch
usb.current/usb-adding-comment-for-ipaq-forcing-number-of-ports.patch
usb.current/usb-fix-oops-on-loading-ipaq-module-since-2.6.26.patch
prev parent reply other threads:[~2008-07-03 22:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-30 14:16 linux-next: Tree for June 30 Stephen Rothwell
2008-06-30 16:02 ` [BUILD-FAILURE] " Kamalesh Babulal
2008-06-30 16:43 ` Kamalesh Babulal
2008-06-30 18:59 ` Sam Ravnborg
2008-06-30 19:26 ` Ingo Molnar
2008-06-30 19:47 ` Sam Ravnborg
2008-06-30 20:06 ` Ingo Molnar
2008-06-30 20:11 ` Ingo Molnar
2008-06-30 20:25 ` Sam Ravnborg
2008-06-30 20:37 ` H. Peter Anvin
2008-06-30 20:42 ` H. Peter Anvin
2008-06-30 21:46 ` H. Peter Anvin
2008-07-01 2:10 ` Vivek Goyal
2008-07-01 6:56 ` Ingo Molnar
2008-07-01 8:15 ` Eric W. Biederman
2008-07-01 9:21 ` Kamalesh Babulal
2008-06-30 17:59 ` Jens Axboe
2008-06-30 18:21 ` Kamalesh Babulal
2008-06-30 18:25 ` [BUILD-FAILURE] linux-next: Tree for June 30 - powerpc - build failure at arch_add_memory() Kamalesh Babulal
2008-06-30 18:25 ` Kamalesh Babulal
2008-07-01 1:34 ` Tony Breeds
2008-07-01 1:34 ` Tony Breeds
2008-07-01 8:04 ` Kamalesh Babulal
2008-07-01 8:04 ` Kamalesh Babulal
2008-06-30 18:43 ` linux-next: Tree for June 30 (USB: cdc-acm) Randy Dunlap
2008-06-30 19:01 ` Greg KH
2008-06-30 19:32 ` Alan Stern
2008-06-30 19:32 ` Alan Stern
2008-07-01 12:22 ` Oliver Neukum
2008-07-01 17:10 ` Oliver Neukum
2008-07-03 22:52 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12151255682099@kroah.org \
--to=gregkh@suse.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=oneukum@suse.de \
--cc=randy.dunlap@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.