From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KEid3-0000tY-NB for mharc-grub-devel@gnu.org; Fri, 04 Jul 2008 06:35:01 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEid1-0000sQ-2j for grub-devel@gnu.org; Fri, 04 Jul 2008 06:34:59 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEicn-0000l9-UL for grub-devel@gnu.org; Fri, 04 Jul 2008 06:34:58 -0400 Received: from [199.232.76.173] (port=46395 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEicn-0000l3-Mj for grub-devel@gnu.org; Fri, 04 Jul 2008 06:34:45 -0400 Received: from yw-out-1718.google.com ([74.125.46.156]:8894) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KEicm-0006dm-Ij for grub-devel@gnu.org; Fri, 04 Jul 2008 06:34:45 -0400 Received: by yw-out-1718.google.com with SMTP id 9so468737ywk.66 for ; Fri, 04 Jul 2008 03:34:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=4w749YGPbpfkD7xenHHiDKYWiKyfWlAauU4aj2e9Ubc=; b=UinNPpD4srTxL9HB4TAqPeoS4BGH/7KKn4U2iI3v5b/qCanIxIe9MPM1D+csV7o4+C /B39XYAcNgCSdkSugLjG29DF7PvMK9q1UBo0MHhMJRFUaA+PBtu0fou6G2IoFi9zZr3F ByVWdQs45DhPaUYkoqF6OM2LVcAVkYYdMLbV0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=uDYfizEAOxy3PtzkZ+xtdoDM+r5I/NUA0vF3ZU0tTCKRRzmK/D734wTk+HjY+/kmKk Leg0A2TuvBkjTQY4l/X2jM7MY+yBb8vVy8yEVj7X9PwjwmWMVCS3kQ2PP/2/CS7DykiD FYiHLwfU8cVlFVDtlJfKy+HAHXDBfvE22IoWw= Received: by 10.151.142.16 with SMTP id u16mr1649121ybn.177.1215167676894; Fri, 04 Jul 2008 03:34:36 -0700 (PDT) Received: from ?192.168.1.100? ( [213.37.137.93]) by mx.google.com with ESMTPS id k29sm347260qba.7.2008.07.04.03.34.35 (version=SSLv3 cipher=RC4-MD5); Fri, 04 Jul 2008 03:34:36 -0700 (PDT) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: References: <1214937759.9353.64.camel@localhost> <20080701204816.GA31206@thorin> <1214954927.9353.91.camel@localhost> <20080702142245.GA21064@thorin> <1215027160.9353.125.camel@localhost> <20080703140211.GA19341@thorin> <1215104875.8123.23.camel@localhost> <20080704000829.GE4074@thorin> <1215135163.26019.44.camel@localhost> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-i8x+HjoeOMCKstbUf4Mr" Date: Fri, 04 Jul 2008 12:34:50 +0200 Message-Id: <1215167690.26019.78.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: grub-probe detects ext4 wronly as ext2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jul 2008 10:34:59 -0000 --=-i8x+HjoeOMCKstbUf4Mr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I know I promised not to keep posting but... I just cannot xD El vie, 04-07-2008 a las 14:49 +0800, Bean escribi=C3=B3: > Hi, >=20 > This is an example of good practice, which check the driver > by function, not by flags.=20 This will find and check core.img. As my previous post showed, one file being readable in a partition with an incompatible flag does not guarantee that every file will be. Thus, the conservative policy for grub-probe would be to also check that the FS is "theoretically" accesible (i.e. the ext2/whatever driver is fine with its flags) in addition to the current "practical" check. > > The flags are a little vague, for example, > if they change btree structure in the future, this would introduce > another flag, but we don't need to worry about it, because we don't > use it at all. The btree flag (and any of its modifications) is ROCOMPAT, which indeed allows us not to worry about it at all, because our driver is read only. The proposed patch addresses only INCOMPAT flags, and it even adds a mechanism to ignore some of them because we deem them not to create real incompatibilities (like needs-recovery). >=20 > If we can ensure the boot partition can be accessed, then the problem > is solved. Yes, there may be other partition using ext4 that we can't > access, but remember that linux loader will check for signatures as > well, a corrupted kernel would not be loaded. So the difference is > merely the error message users sees, unknown filesystem or invalid > kernel. I didn't know the "linux" loader checked signatures. Do the "multiboot", "multiboot2" and "bsd" loaders do the same? In the platforms where it is able to load a file, does the "chainloader" loader perform any checks? So in that cases difference would be between "unknown filesystem" and "the FSM knows what". >=20 > And, grub WILL follow the evolution the extN, because it's the primary > boot loader for linux. The only reason we don't have ext4 support at > present is because it's not stable. If major distro starts to use it > as default, we would have to support it as well. Please... ReiserFS was used for long in many distros and GRUB2 didn't support it until 1.96 - even with GRUB Legacy having implemented it long ago. I literally waited years for it to be included! Besides, as I already said, we cannot win in a race against the future: new features, some of them incompatible, are introduced ""constantly"" (every few years) in extN, and until we get to know about them and at least decide whether they can be safely ignored, the sane behavior is to obey them and reject access (except if the user override is enabled). Yes, we can implement ext4 and possibly even before it's released as stable, but could you please start implementing ext7 so that we don't have to worry about its incompatibilities when it comes? --=-i8x+HjoeOMCKstbUf4Mr Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASG38yqSl+Fbdeo72AQIdNg//cImvnlNW/wZrbRUS1/t0xaI0RzhiS84n pIHh4gaGAh2DSkyWTBLpQzD6+sENZmPZ3pjEyeRhdxhJsdFAp4lnEXLrm+V/eCXU 2qrIjeSvAnCzVns7zeBJfCMKLNBtVo/ZqmQe4QG/V4Aqk3DfjPLab9X1rR2drefJ sSL/CQtc1jDWkAzyhFxOSQQ94ICMCBDo+fwHdqMotEebyEcJZpolt8RW22k+7LmP EEkmeJddqbqje5dAcIcsbewV9qTMpwfe6uLlOxtwKymT0WeDjZQ28XteJGXmlB1N UrACk2SAGVYTAN4tBca8fU1Fq5VR/a4ZJHxjaO++reBU3EbvmmBKfAu4kUO76vHI HZ9ycxIyrwwVjB5Zycp3Y2bg+A+0kGwj5v2zW6s1krCHQcjnHqcq26MBGCVWx13D fuIwwFSDo6yCpe5fhF2Ej336rRCMZa6jVg00Sk0nBv8DvMBh/H/LJyHeMEvknG1d pSMAKAzEBA5UbRkNkY8uHHHCxpWPAu0jSt1fYbTZWGuIrb8MZ35zyiUR3g0Mc3bN jTS+iwkVvxKFVEkou/ZumjtAspOWjmHlw8RnTZH4dl3B56dHmcZuXMNCl/fdcGCI TJoxqArz9eZVrlhNrKhGxgUO2oj/meUbFJXImDKW4rVd4WKq2QEZpAwMXhilu29U hahT8coauPI= =acwm -----END PGP SIGNATURE----- --=-i8x+HjoeOMCKstbUf4Mr--