From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KEmWr-0008Tg-GY for mharc-grub-devel@gnu.org; Fri, 04 Jul 2008 10:44:53 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEmWq-0008Sj-FP for grub-devel@gnu.org; Fri, 04 Jul 2008 10:44:52 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEmWp-0008Rn-2A for grub-devel@gnu.org; Fri, 04 Jul 2008 10:44:51 -0400 Received: from [199.232.76.173] (port=45174 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEmWo-0008Rk-Uk for grub-devel@gnu.org; Fri, 04 Jul 2008 10:44:50 -0400 Received: from nf-out-0910.google.com ([64.233.182.191]:8647) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KEmWo-0005YB-Cf for grub-devel@gnu.org; Fri, 04 Jul 2008 10:44:50 -0400 Received: by nf-out-0910.google.com with SMTP id c7so342300nfi.26 for ; Fri, 04 Jul 2008 07:44:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=rcl8YRBPGpaeGQfaLCAxe7SFdyHUpaVoicj5Yco+Kic=; b=ITl3Dm5lehh/mreQmlduxMRKj/F5+C9TISv6wdEFaFTcTYMhnfMQRLaxKjSuxHQo+t wq34GnYHukDkXQTOhGsrA2rIHVvETOf+vESFTh7BmFTCpLyGmXT+7VyjNRCUj3SIR0xW p374cF+gCDl2TZZY5zFDpEw+G6LezqIBMnLCs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=VsUPx3eshEvEinWp4v/NsRWJIX4TppR85z7VKbJd9APDQ8LcJCx5/xI4ydnteXUpGF JhFQkUIF2vXVflXw0IwOy96Ao4slkCFO/neOVX9htp9+QOjkZCLS7ReMhg340YClLZ5R 7R0eiul189AVbiQANgZZVlEVq47jD1Hk+aYBQ= Received: by 10.210.125.7 with SMTP id x7mr403933ebc.45.1215182688108; Fri, 04 Jul 2008 07:44:48 -0700 (PDT) Received: from ?192.168.1.100? ( [213.37.137.93]) by mx.google.com with ESMTPS id i6sm509016gve.4.2008.07.04.07.44.45 (version=SSLv3 cipher=RC4-MD5); Fri, 04 Jul 2008 07:44:46 -0700 (PDT) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: <20080704142125.GC2663@thorin> References: <1214929545.13432.19.camel@dv> <1214937759.9353.64.camel@localhost> <20080701204816.GA31206@thorin> <1214954927.9353.91.camel@localhost> <20080702142245.GA21064@thorin> <1215027160.9353.125.camel@localhost> <20080703140211.GA19341@thorin> <1215104875.8123.23.camel@localhost> <20080704000829.GE4074@thorin> <1215135163.26019.44.camel@localhost> <20080704142125.GC2663@thorin> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-7kvT9mqsuyOjZYi92Y/A" Date: Fri, 04 Jul 2008 16:45:02 +0200 Message-Id: <1215182702.26019.130.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: grub-probe detects ext4 wronly as ext2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jul 2008 14:44:52 -0000 --=-7kvT9mqsuyOjZYi92Y/A Content-Type: multipart/mixed; boundary="=-L/uQAB8CDBKB00tBsHfM" --=-L/uQAB8CDBKB00tBsHfM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable El vie, 04-07-2008 a las 16:21 +0200, Robert Millan escribi=C3=B3: > If you wish to send a patch for the user environment check you proposed, > could send it separately? I'm inclined to commit the flag check, but not > the environment stuff. Ok, here is the old version of the patch without the user override thingy (and the extents reference removed). >=20 > Afterwards if you like we could discuss about whether we should be > "best-effort" in real GRUB or not. It's really not such a big deal, > as long as we don't end up cluttering the user interface because of it. By the way, it's true that UI should be carefully thought of and we should exercise great care not to end like GRUB Legacy with its quirks and such, but... this is a bootloader, not Mac OS X! Even though it should have simple paths, it's supposed to be complex (within reason) >=20 > On Fri, Jul 04, 2008 at 03:32:43AM +0200, Javier Mart=C3=ADn wrote: > > - grub_error (GRUB_ERR_BAD_FS, "not an ext2 filesystem"); > > + grub_error (GRUB_ERR_BAD_FS, "not an ext2 filesystem, or incompatibl= e" > > + "features enabled (extents, etc.)"); >=20 > I would avoid referring explicitly to the features involved, because it > means the message will end up being obsolete when extents are supported > (and we will likely forget to update it). >=20 True - parenthesized part removed form the patch. By the way, I'm already using SVN (and thus svn diff) for this patch. Is that right? Was the migration completed already? --=-L/uQAB8CDBKB00tBsHfM Content-Disposition: attachment; filename=ext4_unrecognized.patch Content-Type: text/x-patch; name=ext4_unrecognized.patch; charset=utf-8 Content-Transfer-Encoding: base64 SW5kZXg6IGZzL2V4dDIuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIGZzL2V4dDIuYwkocmV2aXNpw7NuOiAx Njg3KQ0KKysrIGZzL2V4dDIuYwkoY29waWEgZGUgdHJhYmFqbykNCkBAIC03MSw4ICs3MSwzOSBA QA0KICAgICAgICAgID8gRVhUMl9HT09EX09MRF9JTk9ERV9TSVpFIFwNCiAgICAgICAgICA6IGdy dWJfbGVfdG9fY3B1MTYgKGRhdGEtPnNibG9jay5pbm9kZV9zaXplKSkNCiANCi0jZGVmaW5lIEVY VDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwJMHgwMDA0DQorLyogU3VwZXJibG9jayBmaWxl c3lzdGVtIGZlYXR1cmUgZmxhZ3MgKFJXIGNvbXBhdGlibGUpICovDQorI2RlZmluZSBFWFQyX0ZF QVRVUkVfQ09NUEFUX0RJUl9QUkVBTExPQwkweDAwMDENCisjZGVmaW5lIEVYVDJfRkVBVFVSRV9D T01QQVRfSU1BR0lDX0lOT0RFUwkweDAwMDINCisjZGVmaW5lIEVYVDNfRkVBVFVSRV9DT01QQVRf SEFTX0pPVVJOQUwJCTB4MDAwNA0KKyNkZWZpbmUgRVhUMl9GRUFUVVJFX0NPTVBBVF9FWFRfQVRU UgkJMHgwMDA4DQorI2RlZmluZSBFWFQyX0ZFQVRVUkVfQ09NUEFUX1JFU0laRV9JTk9ERQkweDAw MTANCisjZGVmaW5lIEVYVDJfRkVBVFVSRV9DT01QQVRfRElSX0lOREVYCQkweDAwMjANCisvKiBT dXBlcmJsb2NrIGZpbGVzeXN0ZW0gZmVhdHVyZSBmbGFncyAoUk8gY29tcGF0aWJsZSkgKi8NCisj ZGVmaW5lIEVYVDJfRkVBVFVSRV9ST19DT01QQVRfU1BBUlNFX1NVUEVSCTB4MDAwMQ0KKyNkZWZp bmUgRVhUMl9GRUFUVVJFX1JPX0NPTVBBVF9MQVJHRV9GSUxFCTB4MDAwMg0KKyNkZWZpbmUgRVhU Ml9GRUFUVVJFX1JPX0NPTVBBVF9CVFJFRV9ESVIJMHgwMDA0DQorI2RlZmluZSBFWFQ0X0ZFQVRV UkVfUk9fQ09NUEFUX0dEVF9DU1VNCQkweDAwMTANCisjZGVmaW5lIEVYVDRfRkVBVFVSRV9ST19D T01QQVRfRElSX05MSU5LCTB4MDAyMA0KKyNkZWZpbmUgRVhUNF9GRUFUVVJFX1JPX0NPTVBBVF9F WFRSQV9JU0laRQkweDAwNDANCisvKiBTdXBlcmJsb2NrIGZpbGVzeXN0ZW0gZmVhdHVyZSBmbGFn cyAoYmFjay1pbmNvbXBhdGlibGUpICovDQorI2RlZmluZSBFWFQyX0ZFQVRVUkVfSU5DT01QQVRf Q09NUFJFU1NJT04JMHgwMDAxDQorI2RlZmluZSBFWFQyX0ZFQVRVUkVfSU5DT01QQVRfRklMRVRZ UEUJCTB4MDAwMg0KKyNkZWZpbmUgRVhUM19GRUFUVVJFX0lOQ09NUEFUX1JFQ09WRVIJCTB4MDAw NCAvKiBOZWVkcyByZWNvdmVyeSAqLw0KKyNkZWZpbmUgRVhUM19GRUFUVVJFX0lOQ09NUEFUX0pP VVJOQUxfREVWCTB4MDAwOCAvKiBKb3VybmFsIGRldmljZSAqLw0KKyNkZWZpbmUgRVhUMl9GRUFU VVJFX0lOQ09NUEFUX01FVEFfQkcJCTB4MDAxMA0KKyNkZWZpbmUgRVhUNF9GRUFUVVJFX0lOQ09N UEFUX0VYVEVOVFMJCTB4MDA0MCAvKiBleHRlbnRzIHN1cHBvcnQgKi8NCisjZGVmaW5lIEVYVDRf RkVBVFVSRV9JTkNPTVBBVF82NEJJVAkJMHgwMDgwDQorI2RlZmluZSBFWFQ0X0ZFQVRVUkVfSU5D T01QQVRfRkxFWF9CRwkJMHgwMjAwDQogDQorLyogVGhlIHNldCBvZiBiYWNrLWluY29tcGF0aWJs ZSBmZWF0dXJlcyB0aGlzIGRyaXZlciBET0VTIHN1cHBvcnQuIEFkZCAoT1IpDQorICogZmxhZ3Mg aGVyZSBhcyB0aGUgcmVsYXRlZCBmZWF0dXJlcyBhcmUgaW1wbGVtZW50ZWQgaW50byB0aGUgZHJp dmVyICovDQorI2RlZmluZSBFWFQyX0RSSVZFUl9TVVBQT1JURURfSU5DT01QQVQgKCBFWFQyX0ZF QVRVUkVfSU5DT01QQVRfRklMRVRZUEUgKQ0KKy8qIFRoZSBzZXQgb2YgYmFjay1pbmNvbXBhdGli bGUgZmVhdHVyZXMgdGhpcyBkcml2ZXIgRE9FUyBOT1Qgc3VwcG9ydCBidXQgYXJlDQorICogaWdu b3JlZCBmb3Igc29tZSBoYWNraXNoIHJlYXNvbi4gRmxhZ3MgaGVyZSBzaG91bGQgYmUgaGVyZSBf dGVtcG9yYXJpbHlfIQ0KKyAqIFJlbWVtYmVyIHRoYXQgSU5DT01QQVRfKiBmZWF0dXJlcyBhcmUg c28gZm9yIGEgcmVhc29uISAqLw0KKyNkZWZpbmUgRVhUMl9EUklWRVJfSUdOT1JFRF9JTkNPTVBB VCAoIEVYVDNfRkVBVFVSRV9JTkNPTVBBVF9SRUNPVkVSICkNCisNCisNCiAjZGVmaW5lIEVYVDNf Sk9VUk5BTF9NQUdJQ19OVU1CRVIJMHhjMDNiMzk5OFUNCiANCiAjZGVmaW5lIEVYVDNfSk9VUk5B TF9ERVNDUklQVE9SX0JMT0NLCTENCkBAIC0zOTQsNiArNDI1LDEyIEBADQogICBpZiAoZ3J1Yl9s ZV90b19jcHUxNiAoZGF0YS0+c2Jsb2NrLm1hZ2ljKSAhPSBFWFQyX01BR0lDKQ0KICAgICBnb3Rv IGZhaWw7DQogICANCisgIC8qIENoZWNrIHRoZSBGUyBkb2Vzbid0IGhhdmUgZmVhdHVyZSBiaXRz IGVuYWJsZWQgdGhhdCB3ZSBkb24ndCBzdXBwb3J0LiAqLw0KKyAgaWYgKGdydWJfbGVfdG9fY3B1 MzIgKGRhdGEtPnNibG9jay5mZWF0dXJlX2luY29tcGF0KQ0KKyAgICAgICAgJiB+KEVYVDJfRFJJ VkVSX1NVUFBPUlRFRF9JTkNPTVBBVCB8IEVYVDJfRFJJVkVSX0lHTk9SRURfSU5DT01QQVQpKQ0K KyAgICBnb3RvIGZhaWw7DQorICAgIA0KKyAgDQogICBkYXRhLT5kaXNrID0gZGlzazsNCiANCiAg IGRhdGEtPmRpcm9wZW4uZGF0YSA9IGRhdGE7DQpAQCAtNDA5LDcgKzQ0Niw4IEBADQogICByZXR1 cm4gZGF0YTsNCiANCiAgZmFpbDoNCi0gIGdydWJfZXJyb3IgKEdSVUJfRVJSX0JBRF9GUywgIm5v dCBhbiBleHQyIGZpbGVzeXN0ZW0iKTsNCisgIGdydWJfZXJyb3IgKEdSVUJfRVJSX0JBRF9GUywg Im5vdCBhbiBleHQyIGZpbGVzeXN0ZW0sIG9yIGluY29tcGF0aWJsZSINCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgImZlYXR1cmVzIGVuYWJsZWQiKTsNCiAgIGdydWJfZnJlZSAoZGF0 YSk7DQogICByZXR1cm4gMDsNCiB9DQo= --=-L/uQAB8CDBKB00tBsHfM-- --=-7kvT9mqsuyOjZYi92Y/A Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASG43bqSl+Fbdeo72AQJJQQ/+LS+gBqRv6W7trm1BQfrX+8nxxcxeP5ZL fBytSdXPLaoJvhZPZnileFSZdZruSITQO0Kb1gwrv1GJ96y/X4uqGgbgVdJBx0Nw 1ELwdKxsmjiQc9dbaFveZU2LNuALAePapd0R82pL3pwA6mOM6ckWE3pxoWdLSBk/ qdOhcGUmIJzuBR9ngUZ/LBGahpTcWh+lOEBTpGe2MDBw3pOabBW+jm2CNBHeC9OP KIbmhdZsamfF6gCeJUZk7wJ7QBO2qe2y++8YhWVGu0I6BDg3YDi38eCm5H4ssQBg NRqJxZYX2mwDsQ5rkQpM2OtuJMLvS8u1vsBd7o8NH28udJKe29V7gnG3jk9Yp+80 rU3AZMxwpTwOKqb+FBO7mn5clrWFoQ6sqdgC+HBFNuQHbhgzuRMI3ZZjaDMOE5h1 kBhCJApHObH40mE5fkoByIXpgkxgde8Z3UUHTq3AqOiyIO92aKmZlqVLXNWsJMIE M17E2HOzTG2Z5ycNEio9KcdkyQbAakijFIzQUVN3WPazPzdMelAHQdnvLL3QTCw4 jyvcfUgwKe2ZZ2+3rQvBsUrVoeKtDHDlHy1+Thyc70HIT9KYKbC3hScILu1HqiUY v47vEBy1P6WumlHfm2S8eqjozVeoCMrFSDsWlD3RuDTDwWYMt4w6SOU4DeYzqCHr 3ZooZzuBJeI= =lg13 -----END PGP SIGNATURE----- --=-7kvT9mqsuyOjZYi92Y/A--