From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KEs5s-0003Na-AR for mharc-grub-devel@gnu.org; Fri, 04 Jul 2008 16:41:24 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEs5p-0003NV-RP for grub-devel@gnu.org; Fri, 04 Jul 2008 16:41:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEs5n-0003NJ-V5 for grub-devel@gnu.org; Fri, 04 Jul 2008 16:41:20 -0400 Received: from [199.232.76.173] (port=53195 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEs5n-0003NG-Nw for grub-devel@gnu.org; Fri, 04 Jul 2008 16:41:19 -0400 Received: from nf-out-0910.google.com ([64.233.182.187]:52432) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KEs5n-0000oz-GV for grub-devel@gnu.org; Fri, 04 Jul 2008 16:41:19 -0400 Received: by nf-out-0910.google.com with SMTP id c7so369714nfi.26 for ; Fri, 04 Jul 2008 13:41:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=7L+uJeYfVHYMkRMbSS0qMcjHA9Fpr91RxDybYzZ8Ia4=; b=tlpWLf5VL6ntMFwmSv2gT1rXrzD2Nn3GON1vGo5BonQKQ3izksq5+AO6/OZm6AE9HK W2bET6sYHy0jFnC3ZacsxMFt4JfCENhYhs9EAPuLSoywOqTUDbDCmOZf8QmxFwBvbUAA pQqbkE6hHOOlUu3cO+TWsH1apOKUIXFmJhe6E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=FCGp0mtHwkoa9Yfcm8aSf/t6X2U4CJUsjAxCLDp+QdiPjp1Whnjb2c24c+aY9FrXdu IMjU787TRXpC7BQFtzKEKB/zeoioGxxafmOoqegjOr36tXQnTL4rD0hhfQEBeJkHTXbR lbDMvkHrDJCHu6y0ipjgUyzC9sM4XKqF3aiAA= Received: by 10.210.80.17 with SMTP id d17mr648328ebb.163.1215204077217; Fri, 04 Jul 2008 13:41:17 -0700 (PDT) Received: from ?192.168.1.100? ( [213.37.137.93]) by mx.google.com with ESMTPS id p10sm1036106gvf.7.2008.07.04.13.41.14 (version=SSLv3 cipher=RC4-MD5); Fri, 04 Jul 2008 13:41:16 -0700 (PDT) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: <20080704185723.GB32625@thorin> References: <20080701204816.GA31206@thorin> <1214954927.9353.91.camel@localhost> <20080702142245.GA21064@thorin> <1215027160.9353.125.camel@localhost> <20080703140211.GA19341@thorin> <1215104875.8123.23.camel@localhost> <20080704000829.GE4074@thorin> <1215135163.26019.44.camel@localhost> <20080704142125.GC2663@thorin> <1215182702.26019.130.camel@localhost> <20080704185723.GB32625@thorin> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-YeyFZAn1L+SH21kqsJYW" Date: Fri, 04 Jul 2008 22:41:35 +0200 Message-Id: <1215204095.26019.142.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: grub-probe detects ext4 wronly as ext2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jul 2008 20:41:22 -0000 --=-YeyFZAn1L+SH21kqsJYW Content-Type: multipart/mixed; boundary="=-7tjs6vL8xP8ZvgpspydO" --=-7tjs6vL8xP8ZvgpspydO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable OK, I've addressed all your concerns and here is a new version of the patch. With it, the delta-size of the compiled ext2.mod against a completely unpatched one is just 148 bytes. El vie, 04-07-2008 a las 20:57 +0200, Robert Millan escribi=C3=B3: > On Fri, Jul 04, 2008 at 04:45:02PM +0200, Javier Mart=C3=ADn wrote: > >=20 > > By the way, I'm already using SVN (and thus svn diff) for this patch. I= s > > that right? Was the migration completed already? >=20 > Yep. Wonderful! I was sick of jumping through hoops with cvs diff. > I'd suggest making the "RW compatible" etc notes a bit more ellaborate to= make > it clear what they mean (I'm confused myself). Done, though now I might have over-elaborated > > +/* The set of back-incompatible features this driver DOES support. Add= (OR) > > + * flags here as the related features are implemented into the driver = */ > > +#define EXT2_DRIVER_SUPPORTED_INCOMPAT ( EXT2_FEATURE_INCOMPAT_FILETYP= E ) >=20 > I suppose we'll want to have EXT4_FEATURE_INCOMPAT_EXTENTS here, now that= it's > been implemented (Bean just sent a patch, which will probably be merged f= irst). Done too and checked that ext4 filesystems w/o other incompatible features like 64BIT are now recognized (though I did not check reading since I haven't yet applied Bean's patch to my tree). > > +/* The set of back-incompatible features this driver DOES NOT support = but are > > + * ignored for some hackish reason. Flags here should be here _tempora= rily_! > > + * Remember that INCOMPAT_* features are so for a reason! */ > > +#define EXT2_DRIVER_IGNORED_INCOMPAT ( EXT3_FEATURE_INCOMPAT_RECOVER ) >=20 > Instead of this can we have an explanation of what EXT3_FEATURE_INCOMPAT_= RECOVER > is doing here? I think the reason was that our code for this feature was= n't > as mature as it should be, and it appears that not handling it brings bet= ter > results in the short term. Done - explained why RECOVER is ignored even though it's "incompatible" > Since we know which one applies, why not tell grub_error about it? We co= uld > leave the "not an ext2 filesystem" call unmodified and add another one fo= r > this particular error. >=20 I may have overstepped a bit, but I've thought it more sensible to replace all "goto fail;"s for calls to a new macro MOUNT_FAIL taking a string argument which is saved in the new variable err_msg, and then jumps to fail which shows _that_ message instead of the old one. Then, I wrote informative messages for each error condition instead of just "not an ext2 filesystem". --=-7tjs6vL8xP8ZvgpspydO Content-Disposition: attachment; filename=ext2_incompat.patch.3 Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name=ext2_incompat.patch.3; charset=utf-8 SW5kZXg6IGZzL2V4dDIuYw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIGZzL2V4dDIuYwkocmV2aXNpw7NuOiAx NjkxKQ0KKysrIGZzL2V4dDIuYwkoY29waWEgZGUgdHJhYmFqbykNCkBAIC03MSw4ICs3MSw1MyBA QA0KICAgICAgICAgID8gRVhUMl9HT09EX09MRF9JTk9ERV9TSVpFIFwNCiAgICAgICAgICA6IGdy dWJfbGVfdG9fY3B1MTYgKGRhdGEtPnNibG9jay5pbm9kZV9zaXplKSkNCiANCi0jZGVmaW5lIEVY VDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwJMHgwMDA0DQorLyogU3VwZXJibG9jayBmaWxl c3lzdGVtIGZlYXR1cmUgZmxhZ3MgKFJXIGNvbXBhdGlibGUpDQorICogQSBmaWxlc3lzdGVtIHdp dGggYW55IG9mIHRoZXNlIGVuYWJsZWQgY2FuIGJlIHJlYWQgYW5kIHdyaXR0ZW4gYnkgYSBkcml2 ZXINCisgKiB0aGF0IGRvZXMgbm90IHVuZGVyc3RhbmQgdGhlbSB3aXRob3V0IGNhdXNpbmcgbWV0 YWRhdGEvZGF0YSBjb3JydXB0aW9uICovDQorI2RlZmluZSBFWFQyX0ZFQVRVUkVfQ09NUEFUX0RJ Ul9QUkVBTExPQwkweDAwMDENCisjZGVmaW5lIEVYVDJfRkVBVFVSRV9DT01QQVRfSU1BR0lDX0lO T0RFUwkweDAwMDINCisjZGVmaW5lIEVYVDNfRkVBVFVSRV9DT01QQVRfSEFTX0pPVVJOQUwJCTB4 MDAwNA0KKyNkZWZpbmUgRVhUMl9GRUFUVVJFX0NPTVBBVF9FWFRfQVRUUgkJMHgwMDA4DQorI2Rl ZmluZSBFWFQyX0ZFQVRVUkVfQ09NUEFUX1JFU0laRV9JTk9ERQkweDAwMTANCisjZGVmaW5lIEVY VDJfRkVBVFVSRV9DT01QQVRfRElSX0lOREVYCQkweDAwMjANCisvKiBTdXBlcmJsb2NrIGZpbGVz eXN0ZW0gZmVhdHVyZSBmbGFncyAoUk8gY29tcGF0aWJsZSkNCisgKiBBIGZpbGVzeXN0ZW0gd2l0 aCBhbnkgb2YgdGhlc2UgZW5hYmxlZCBjYW4gYmUgc2FmZWx5IHJlYWQgYnkgYSBkcml2ZXIgdGhh dA0KKyAqIGRvZXMgbm90IHVuZGVyc3RhbmQgdGhlbSwgYnV0IHNob3VsZCBub3QgYmUgd3JpdHRl biB0bywgdXN1YWxseSBiZWNhdXNlDQorICogYWRkaXRpb25hbCBtZXRhZGF0YSBpcyByZXF1aXJl ZCAqLw0KKyNkZWZpbmUgRVhUMl9GRUFUVVJFX1JPX0NPTVBBVF9TUEFSU0VfU1VQRVIJMHgwMDAx DQorI2RlZmluZSBFWFQyX0ZFQVRVUkVfUk9fQ09NUEFUX0xBUkdFX0ZJTEUJMHgwMDAyDQorI2Rl ZmluZSBFWFQyX0ZFQVRVUkVfUk9fQ09NUEFUX0JUUkVFX0RJUgkweDAwMDQNCisjZGVmaW5lIEVY VDRfRkVBVFVSRV9ST19DT01QQVRfR0RUX0NTVU0JCTB4MDAxMA0KKyNkZWZpbmUgRVhUNF9GRUFU VVJFX1JPX0NPTVBBVF9ESVJfTkxJTksJMHgwMDIwDQorI2RlZmluZSBFWFQ0X0ZFQVRVUkVfUk9f Q09NUEFUX0VYVFJBX0lTSVpFCTB4MDA0MA0KKy8qIFN1cGVyYmxvY2sgZmlsZXN5c3RlbSBmZWF0 dXJlIGZsYWdzIChiYWNrLWluY29tcGF0aWJsZSkNCisgKiBBIGZpbGVzeXN0ZW0gd2l0aCBhbnkg b2YgdGhlc2UgZW5hYmxlZCBzaG91bGQgbm90IGJlIGF0dGVtcHRlZCB0byBiZSByZWFkDQorICog YnkgYSBkcml2ZXIgdGhhdCBkb2VzIG5vdCB1bmRlcnN0YW5kIHRoZW0sIHNpbmNlIHRoZXkgdXN1 YWxseSBpbmRpY2F0ZQ0KKyAqIG1ldGFkYXRhIGZvcm1hdCBjaGFuZ2VzIHRoYXQgbWlnaHQgY29u ZnVzZSB0aGUgcmVhZGVyLiAqLw0KKyNkZWZpbmUgRVhUMl9GRUFUVVJFX0lOQ09NUEFUX0NPTVBS RVNTSU9OCTB4MDAwMQ0KKyNkZWZpbmUgRVhUMl9GRUFUVVJFX0lOQ09NUEFUX0ZJTEVUWVBFCQkw eDAwMDINCisjZGVmaW5lIEVYVDNfRkVBVFVSRV9JTkNPTVBBVF9SRUNPVkVSCQkweDAwMDQgLyog TmVlZHMgcmVjb3ZlcnkgKi8NCisjZGVmaW5lIEVYVDNfRkVBVFVSRV9JTkNPTVBBVF9KT1VSTkFM X0RFVgkweDAwMDggLyogVm9sdW1lIGlzIGpvdXJuYWwgZGV2aWNlICovDQorI2RlZmluZSBFWFQy X0ZFQVRVUkVfSU5DT01QQVRfTUVUQV9CRwkJMHgwMDEwDQorI2RlZmluZSBFWFQ0X0ZFQVRVUkVf SU5DT01QQVRfRVhURU5UUwkJMHgwMDQwIC8qIEV4dGVudHMgdXNlZCAqLw0KKyNkZWZpbmUgRVhU NF9GRUFUVVJFX0lOQ09NUEFUXzY0QklUCQkweDAwODANCisjZGVmaW5lIEVYVDRfRkVBVFVSRV9J TkNPTVBBVF9GTEVYX0JHCQkweDAyMDANCiANCisvKiBUaGUgc2V0IG9mIGJhY2staW5jb21wYXRp YmxlIGZlYXR1cmVzIHRoaXMgZHJpdmVyIERPRVMgc3VwcG9ydC4gQWRkIChPUikNCisgKiBmbGFn cyBoZXJlIGFzIHRoZSByZWxhdGVkIGZlYXR1cmVzIGFyZSBpbXBsZW1lbnRlZCBpbnRvIHRoZSBk cml2ZXIgKi8NCisjZGVmaW5lIEVYVDJfRFJJVkVSX1NVUFBPUlRFRF9JTkNPTVBBVCAoIEVYVDJf RkVBVFVSRV9JTkNPTVBBVF9GSUxFVFlQRSBcDQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCBFWFQ0X0ZFQVRVUkVfSU5DT01QQVRfRVhURU5UUyApDQorLyogTGlzdCBv ZiByYXRpb25hbGVzIGZvciB0aGUgaWdub3JlZCAiaW5jb21wYXRpYmxlIiBmZWF0dXJlczoNCisg KiBuZWVkc19yZWNvdmVyeTogTm90IHJlYWxseSBiYWNrLWluY29tcGF0aWJsZSAtIHdhcyBhZGRl ZCBhcyBzdWNoIHRvIGZvcmJpZA0KKyAqICAgICAgICAgICAgICAgICBleHQyIGRyaXZlcnMgZnJv bSBtb3VudGluZyBhbiBleHQzIHZvbHVtZSB3aXRoIGEgZGlydHkNCisgKiAgICAgICAgICAgICAg ICAgam91cm5hbCBiZWNhdXNlIHRoZXkgd2lsbCBpZ25vcmUgdGhlIGpvdXJuYWwsIGJ1dCB0aGUg bmV4dA0KKyAqICAgICAgICAgICAgICAgICBleHQzIGRyaXZlciB0byBtb3VudCB0aGUgdm9sdW1l IHdpbGwgZmluZCB0aGUgam91cm5hbCBhbmQNCisgKiAgICAgICAgICAgICAgICAgcmVwbGF5IGl0 LCBwb3RlbnRpYWxseSBjb3JydXB0aW5nIHRoZSBtZXRhZGF0YSB3cml0dGVuIGJ5DQorICogICAg ICAgICAgICAgICAgIHRoZSBleHQyIGRyaXZlcnMNCisgKi8NCisjZGVmaW5lIEVYVDJfRFJJVkVS X0lHTk9SRURfSU5DT01QQVQgKCBFWFQzX0ZFQVRVUkVfSU5DT01QQVRfUkVDT1ZFUiApDQorDQor DQogI2RlZmluZSBFWFQzX0pPVVJOQUxfTUFHSUNfTlVNQkVSCTB4YzAzYjM5OThVDQogDQogI2Rl ZmluZSBFWFQzX0pPVVJOQUxfREVTQ1JJUFRPUl9CTE9DSwkxDQpAQCAtMzc1LDEwICs0MjAsMTIg QEANCiAgIHJldHVybiAwOw0KIH0NCiANCisjZGVmaW5lIEVYVDJfRFJJVkVSX01PVU5UX0ZBSUwo bWVzc2FnZSkgeyBlcnJfbXNnID0gKG1lc3NhZ2UpOyBnb3RvIGZhaWw7IH0NCiBzdGF0aWMgc3Ry dWN0IGdydWJfZXh0Ml9kYXRhICoNCiBncnViX2V4dDJfbW91bnQgKGdydWJfZGlza190IGRpc2sp DQogew0KICAgc3RydWN0IGdydWJfZXh0Ml9kYXRhICpkYXRhOw0KKyAgY29uc3QgY2hhciAqZXJy X21zZyA9IDA7DQogDQogICBkYXRhID0gZ3J1Yl9tYWxsb2MgKHNpemVvZiAoc3RydWN0IGdydWJf ZXh0Ml9kYXRhKSk7DQogICBpZiAoIWRhdGEpDQpAQCAtMzg4LDEyICs0MzUsMTggQEANCiAgIGdy dWJfZGlza19yZWFkIChkaXNrLCAxICogMiwgMCwgc2l6ZW9mIChzdHJ1Y3QgZ3J1Yl9leHQyX3Ni bG9jayksDQogICAgICAgICAgICAgICAgICAgKGNoYXIgKikgJmRhdGEtPnNibG9jayk7DQogICBp ZiAoZ3J1Yl9lcnJubykNCi0gICAgZ290byBmYWlsOw0KKyAgICBFWFQyX0RSSVZFUl9NT1VOVF9G QUlMKCJjb3VsZCBub3QgcmVhZCB0aGUgc3VwZXJibG9jayIpDQogDQogICAvKiBNYWtlIHN1cmUg dGhpcyBpcyBhbiBleHQyIGZpbGVzeXN0ZW0uICAqLw0KICAgaWYgKGdydWJfbGVfdG9fY3B1MTYg KGRhdGEtPnNibG9jay5tYWdpYykgIT0gRVhUMl9NQUdJQykNCi0gICAgZ290byBmYWlsOw0KKyAg ICBFWFQyX0RSSVZFUl9NT1VOVF9GQUlMKCJub3QgYW4gZXh0MiBmaWxlc3lzdGVtIChzdXBlcmJs b2NrIG1hZ2ljIG1pc21hdGNoKSIpDQogICANCisgIC8qIENoZWNrIHRoZSBGUyBkb2Vzbid0IGhh dmUgZmVhdHVyZSBiaXRzIGVuYWJsZWQgdGhhdCB3ZSBkb24ndCBzdXBwb3J0LiAqLw0KKyAgaWYg KGdydWJfbGVfdG9fY3B1MzIgKGRhdGEtPnNibG9jay5mZWF0dXJlX2luY29tcGF0KQ0KKyAgICAg ICAgJiB+KEVYVDJfRFJJVkVSX1NVUFBPUlRFRF9JTkNPTVBBVCB8IEVYVDJfRFJJVkVSX0lHTk9S RURfSU5DT01QQVQpKQ0KKyAgICBFWFQyX0RSSVZFUl9NT1VOVF9GQUlMKCJmaWxlc3lzdGVtIGhh cyB1bnN1cHBvcnRlZCBpbmNvbXBhdGlibGUgZmVhdHVyZXMiKQ0KKyAgICANCisgIA0KICAgZGF0 YS0+ZGlzayA9IGRpc2s7DQogDQogICBkYXRhLT5kaXJvcGVuLmRhdGEgPSBkYXRhOw0KQEAgLTQw NCwxMiArNDU3LDE0IEBADQogDQogICBncnViX2V4dDJfcmVhZF9pbm9kZSAoZGF0YSwgMiwgZGF0 YS0+aW5vZGUpOw0KICAgaWYgKGdydWJfZXJybm8pDQotICAgIGdvdG8gZmFpbDsNCisgICAgRVhU Ml9EUklWRVJfTU9VTlRfRkFJTCgiY291bGQgbm90IHJlYWQgdGhlIHJvb3QgZGlyZWN0b3J5IGlu b2RlIikNCiAgIA0KICAgcmV0dXJuIGRhdGE7DQogDQogIGZhaWw6DQotICBncnViX2Vycm9yIChH UlVCX0VSUl9CQURfRlMsICJub3QgYW4gZXh0MiBmaWxlc3lzdGVtIik7DQorICBpZiAoIWVycl9t c2cpDQorICAgIGVycl9tc2cgPSAiREVCVUc6IG1vdW50IGZhaWxlZCBidXQgbm8gZXJyb3IgbWVz c2FnZSBzdXBwbGllZCEiOw0KKyAgZ3J1Yl9lcnJvciAoR1JVQl9FUlJfQkFEX0ZTLCBlcnJfbXNn KTsNCiAgIGdydWJfZnJlZSAoZGF0YSk7DQogICByZXR1cm4gMDsNCiB9DQo= --=-7tjs6vL8xP8ZvgpspydO-- --=-YeyFZAn1L+SH21kqsJYW Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASG6K/6Sl+Fbdeo72AQL2KA/6AzJ3Zy4Fyu2tHansvWADeePsUcVRYXwp 04FzdOQKTn+ct2gpmoHkcPhGibhnOD4vKPwxZsTFuQ3dRcnu0HtzS5be21B9VA0p vpY9+xO25Xz6EHKzRj24IlO4sITM8CvBKHHXNc7C8nAmMJj1ttiU09Vh423qJyHo wHSKDA74UhXBn5P4Na48oxDfqb+r03X9rTwDcszufMAWLMHEUJmU9hr6ATSjk7qD c6D7pRLh40V/AhLJG3EXB/T4umylRR3f9hKFSRaawdwdcSygj9YS9T7fjJgb3vf9 xCTr27zMghgQko+yAqKyal6JEPi1JndfpjH5gjI6/WBV98yn7D709+JcfVCnY5Y2 8SMSMGj+DOiBNEqtx1pq6oZ82siJVALqpI3cms8d5MA2o5l2yd72Hgtned3xmENG C4QwwTF9QKIeOhmxd0KkKGJCjsUT03Ng5/4+sAuklDOAlPepz+1VXxMNXGZn0Bve DDKa8gH+f/uOe32a6v3rhy0PDLV8GfVJget+9m2+bxz/9DdA/eBBXa7qZCro+bSJ AEh0EmOZpprjU5MnIrNegzNk+pgF7T083uNlfaWEC1iXwNqYpc1KP1gOfEu2UXbU Nc0egbQej1+8nvRoGxUbMbVQQal8jMdHITR7Zd5k4G6M7zJTbIeUSxhrPXAdcsEj pfCyO/wTZhs= =mpKQ -----END PGP SIGNATURE----- --=-YeyFZAn1L+SH21kqsJYW--