From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KFFL1-00057r-NW for mharc-grub-devel@gnu.org; Sat, 05 Jul 2008 17:30:35 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KFFKz-00057k-TO for grub-devel@gnu.org; Sat, 05 Jul 2008 17:30:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KFFKx-00055R-SL for grub-devel@gnu.org; Sat, 05 Jul 2008 17:30:33 -0400 Received: from [199.232.76.173] (port=44072 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KFFKx-000554-K7 for grub-devel@gnu.org; Sat, 05 Jul 2008 17:30:31 -0400 Received: from c60.cesmail.net ([216.154.195.49]:42788) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KFFKx-00016e-Ad for grub-devel@gnu.org; Sat, 05 Jul 2008 17:30:31 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 05 Jul 2008 17:30:30 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 1D424618F22 for ; Sat, 5 Jul 2008 17:30:30 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1215264476.26019.160.camel@localhost> References: <1215264476.26019.160.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1 Date: Sat, 05 Jul 2008 17:30:27 -0400 Message-Id: <1215293427.17114.2.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 8bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Endianness macros capitalization X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jul 2008 21:30:34 -0000 On Sat, 2008-07-05 at 15:27 +0200, Javier Martín wrote: > Just my two (euro) cents: why are the endianness macros written like > functions? I'm talking about the grub_Xe_to_cpuNN family, which look > like function calls instead of the macros they are. Shouldn't they be > capitalized to GRUB_LE_TO_CPU32 and such? They probably should be functions. We may want to sparse annotate GRUB one day, and then inline functions in the only way to go. I prefer capitalized names only for macros that cannot be functions or have non-trivial size effects. -- Regards, Pavel Roskin