From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KFGeq-0001bT-BO for mharc-grub-devel@gnu.org; Sat, 05 Jul 2008 18:55:08 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KFGeo-0001ZP-7Q for grub-devel@gnu.org; Sat, 05 Jul 2008 18:55:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KFGem-0001X6-93 for grub-devel@gnu.org; Sat, 05 Jul 2008 18:55:05 -0400 Received: from [199.232.76.173] (port=59843 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KFGem-0001Wv-2o for grub-devel@gnu.org; Sat, 05 Jul 2008 18:55:04 -0400 Received: from nf-out-0910.google.com ([64.233.182.185]:2671) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KFGel-0002Te-Mw for grub-devel@gnu.org; Sat, 05 Jul 2008 18:55:03 -0400 Received: by nf-out-0910.google.com with SMTP id c7so451195nfi.26 for ; Sat, 05 Jul 2008 15:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=dfysGYveoM4j3OheM1s/q2wtz4cArZfBxZ2bZfoqfTc=; b=vNPyQUOyTehob7HyXBX95H4bG+jWot6NnldLdxB60gDZGzZ15LhUpCEtrbfWlhgJN1 IPzHweajmzsaCrbxGBQM7AufpVZATGlnPEeFOMlgX++XQb5qr3GGeqil6SEaJ7B7F8cA SHPpCLIeML6qveRDrm4vbyG2joJJkzsfOnUwQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=OwgG1S1+F0P/Tij53ucyKMTSKLCIMXf9zCQvWAxlXFRV7TquVJMu9iOeho3PrUbJ5F GcSQPlU4705nG+pdKzRmbw7T4dIAU88SuJRh+qnZALbSSHC5dTxEr4XLNV1vIAELaVBi 5hAk1FkfROawF2xnTXpTdWKXqywlopzNEfxpM= Received: by 10.210.89.4 with SMTP id m4mr1622913ebb.120.1215298501646; Sat, 05 Jul 2008 15:55:01 -0700 (PDT) Received: from ?192.168.1.100? ( [213.37.137.93]) by mx.google.com with ESMTPS id i6sm3287394gve.4.2008.07.05.15.54.59 (version=SSLv3 cipher=RC4-MD5); Sat, 05 Jul 2008 15:55:00 -0700 (PDT) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: <1215293427.17114.2.camel@dv> References: <1215264476.26019.160.camel@localhost> <1215293427.17114.2.camel@dv> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-NTv2TGkw4wHckF1Q5MQV" Date: Sun, 06 Jul 2008 00:54:58 +0200 Message-Id: <1215298499.26019.192.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: Endianness macros capitalization X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jul 2008 22:55:07 -0000 --=-NTv2TGkw4wHckF1Q5MQV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable El s=C3=A1b, 05-07-2008 a las 17:30 -0400, Pavel Roskin escribi=C3=B3: > They probably should be functions. We may want to sparse annotate GRUB > one day, and then inline functions in the only way to go. Hmm... you mean changing this #define grub_swap_bytes16(x) \ ({ \ grub_uint16_t _x =3D (x); \ (grub_uint16_t) ((_x << 8) | (_x >> 8)); \ }) ...for this inline grub_uint16_t grub_swap_bytes16(uint16_t x) { return (x << 8) | (x >> 8); } and such? The pro is that we get rid of the ugly hack in the macro version that ensures single evaluation, but a con is that we cannot _force_ any random compiler to inline anything, so we might end up with gross numbers of function calls. By the way, what is "sparse annotate"? --=-NTv2TGkw4wHckF1Q5MQV Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASG/7wqSl+Fbdeo72AQKBjw/8CZUmbtOhaG2GAnt6FByIN4NwQN/6O6eb WFgYj5pZHbRQBN35SOZeIrrqXxqTJ6h87Wj8VC2k+2AAArQfiTiBji/dFax2ZLe7 ThgfM3jNuCqPBT61Gp1eStxFHF4VBUm3b7UKGNDBNC3kjDw2Y8bg9AfeP6EU0sfA epiZCfbtLwy4X9eJuh/4m0MjaXcjrUioW0OHxPntx5bb7VPz5FLt8h+4OSq8j9cW Mg99iznr0fo3fi6k+ldZU+ooLEm2eUqLLYF+OdOHsssix//fd0DlTzLEQJ6D1fvX Rq2HGXaPwnaUF2Zxmfg9msxmqMSDrUkvoLX9q8xcVFNY0hzztmeUdo/1yvO7JLSj +EbX0MaB8XEwnC0+0xDZXFVX0H98+jImcVl1iZLtRzp6LJ5UgwF0pbz/Aniggdo7 ywF5sLj2mYxMjqnWYmuuolFhELSnQF/maFchctEj6He5pQOWheke0LJVOevrzjkW mLeXTKrBptIoyR0ztUDEdmSLKjanoaMs1aLFHnsnfe5h3iYjylNjCKUQNJvmz3/2 +sW2X3NQ7cA4BsaaLWYWX+hV8qZoL/FKyqn/VYcCxDFcSbLVbJy27RH82K4XXK75 WEgP0mnMlIZyk3xSB3WaFcGn6Ougb1DGbunv5W0nzpki7ue9/yKzoyqBQ5T7wcO7 kDFwmHLZaXI= =mM33 -----END PGP SIGNATURE----- --=-NTv2TGkw4wHckF1Q5MQV--