From: Harvey Harrison <harvey.harrison@gmail.com>
To: Michael Buesch <mb@bu3sch.de>
Cc: Tomas Winkler <tomas.winkler@intel.com>,
linville@tuxdriver.com, johannes@sipsolutions.net,
yi.zhu@intel.com, linux-wireless@vger.kernel.org,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH 1/1 V2] mac80211: Fix ieee80211_rx_reorder_ampdu: ignore QoS null packets
Date: Mon, 07 Jul 2008 12:26:32 -0700 [thread overview]
Message-ID: <1215458792.14247.7.camel@brick> (raw)
In-Reply-To: <200807071902.51683.mb@bu3sch.de>
On Mon, 2008-07-07 at 19:02 +0200, Michael Buesch wrote:
> On Monday 07 July 2008 18:23:44 Harvey Harrison wrote:
> > On Mon, 2008-07-07 at 15:48 +0300, Tomas Winkler wrote:
> > > From: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> > >=20
> > > This patch fixes the check at the entrance to ieee80211_rx_reorde=
r_ampdu.
> > > This check has been broken by 511fe3f3c4ba0b5b77421336f64a19b6cd0=
0e65f
> > > 'mac80211: rx.c use new helpers'
> > >=20
> > Actually, do we want something like this instead:
> >
Or, after having a coffee and actually engaging brain (similar to=20
ieee80211_is_data_qos)
int ieee80211_is_data_nullfunc(__le16 fc)
{
return (fc & cpu_to_le16(IEEE80211_FCTL_FTYPE | =EF=BB=BFIEEE80211_=EF=
=BB=BFSTYPE_NULLFUNC)) =3D=3D
cpu_to_le16(IEEE80211_FTYPE_DATA | IEEE80211_STYPE_NULLFUNC);
}
Tomas, you want a patch?
Harvey
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-07-07 19:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 12:48 [PATCH 1/1 V2] mac80211: Fix ieee80211_rx_reorder_ampdu: ignore QoS null packets Tomas Winkler
2008-07-07 16:23 ` Harvey Harrison
2008-07-07 17:02 ` Michael Buesch
2008-07-07 19:26 ` Harvey Harrison [this message]
2008-07-07 21:23 ` Tomas Winkler
2008-07-07 21:43 ` Harvey Harrison
2008-07-07 22:16 ` Tomas Winkler
2008-07-07 22:44 ` Harvey Harrison
2008-07-07 23:01 ` Tomas Winkler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215458792.14247.7.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=tomas.winkler@intel.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.