From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: dwg@au1.ibm.com, linuxppc-dev@ozlabs.org, paulus@samba.org,
John Linn <john.linn@xilinx.com>
Subject: Re: [PATCH] [V2] powerpc: legacy_serial: reg-offset & shift aren't used
Date: Tue, 08 Jul 2008 08:00:04 +1000 [thread overview]
Message-ID: <1215468004.8970.118.camel@pasglop> (raw)
In-Reply-To: <20080707070124.73ba794f@zod.rchland.ibm.com>
> > - First if the properties are present but their value match the
> > register layout of a standard UART, we will bail out... not nice.
>
> Why would they be present in that case?
Why not ?
> > - Why don't we just implement support for the reg-shift and
> > offset instead ?
>
> Probably because the last time someone suggested that it spawned a
> lengthy debate about what reg-offset/shift were supposed to do.
That's lame, their definition is already quite there.
Ben.
next prev parent reply other threads:[~2008-07-07 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 17:52 [PATCH] [V2] powerpc: legacy_serial: reg-offset & shift aren't used John Linn
2008-07-07 6:47 ` Benjamin Herrenschmidt
2008-07-07 11:01 ` Josh Boyer
2008-07-07 22:00 ` Benjamin Herrenschmidt [this message]
2008-07-07 14:24 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215468004.8970.118.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=dwg@au1.ibm.com \
--cc=john.linn@xilinx.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.