All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: Endianness macros capitalization
Date: Wed, 09 Jul 2008 13:57:30 -0400	[thread overview]
Message-ID: <1215626250.26246.9.camel@dv> (raw)
In-Reply-To: <1KGZ7b-1EcJsG0@fwd32.aul.t-online.de>

On Wed, 2008-07-09 at 14:50 +0200, Christian Franke wrote:

> Overall size from inline asm would only be smaller if there is any
> benefit from additional optimizations.

Correct.  Function calls use fixed registers for everything, but macros
don't have to.

> Result with the test script from my last mail:
> 
> Debian gcc 4.1.2-7:
> inline (portable)=357, inline (asm)=126, function=104
> 
> Cygwin gcc 3.4.4:
> inline (portable)=340, inline (asm)=124, function=96
> 
> Function call is still better. The only candidate for inline is probably
>  grub_swap_bytes16().

But we are getting closer!

> > .... And if written properly, it could work with any of
> > the registers that allow access to the lower two bytes (%eax, %ebx,
> > %ecx and %edx), thus giving more flexibility to the optimizer.
> > 
> 
> This would require support to access the Rl and Rh parts of eRx for each
> R in [a-d]. Something like:
> 
>    asm (
>         "xchg %0:l,%0:h\n"
>         "roll $0x10,%0\n"
>         "xchg %0:l,%0:h\n"
>         : "=r"(_y) : "0"(_x) \
>     );
> 
> Do gcc or gas provide a syntax to do this?

Yes.  That's %b0 and %h0.  Use "=q" for all registers with "upper
halves" (%ah-%dh).

Also, please be consistent and use width suffixes everywhere.  xchg
should be xchgb.

-- 
Regards,
Pavel Roskin



  reply	other threads:[~2008-07-09 17:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-05 13:27 Endianness macros capitalization Javier Martín
2008-07-05 21:30 ` Pavel Roskin
2008-07-05 22:54   ` Javier Martín
2008-07-05 23:14     ` Pavel Roskin
2008-07-06 18:30     ` Robert Millan
2008-07-06 20:02       ` Javier Martín
2008-07-07 19:25         ` Christian Franke
2008-07-08 18:04           ` Christian Franke
2008-07-09  6:47             ` Pavel Roskin
2008-07-09 12:50               ` Christian Franke
2008-07-09 17:57                 ` Pavel Roskin [this message]
2008-07-10 19:25                   ` Christian Franke
2008-07-10 19:59                     ` Pavel Roskin
2008-07-11  7:06                       ` Jordi Mallach
2008-07-11  8:53                     ` Pavel Roskin
2008-07-11  9:07                       ` Pavel Roskin
2008-07-11 13:21                         ` Christian Franke
2008-07-11 18:33                           ` Pavel Roskin
2008-07-20 13:45                 ` Christian Franke
2008-07-20 23:31                   ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1215626250.26246.9.camel@dv \
    --to=proski@gnu.org \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.