From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KHNH9-0008LJ-46 for mharc-grub-devel@gnu.org; Fri, 11 Jul 2008 14:23:23 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KHNH7-0008LD-BK for grub-devel@gnu.org; Fri, 11 Jul 2008 14:23:21 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KHNH6-0008L1-0W for grub-devel@gnu.org; Fri, 11 Jul 2008 14:23:20 -0400 Received: from [199.232.76.173] (port=57784 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KHNH5-0008Ky-SM for grub-devel@gnu.org; Fri, 11 Jul 2008 14:23:19 -0400 Received: from c60.cesmail.net ([216.154.195.49]:35901) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KHNH5-0002FF-F3 for grub-devel@gnu.org; Fri, 11 Jul 2008 14:23:19 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 11 Jul 2008 14:23:18 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 24BAB4F1869 for ; Fri, 11 Jul 2008 14:23:18 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <200807080018.35215.okuji@enbug.org> <1215584072.31230.9.camel@dv> Content-Type: text/plain; charset=ISO-8859-1 Date: Fri, 11 Jul 2008 14:23:17 -0400 Message-Id: <1215800597.29731.11.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 8bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: a bug in read X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jul 2008 18:23:21 -0000 On Wed, 2008-07-09 at 19:56 +0200, Javier Martín wrote: > Couldn't this have been worked around changing while to do-while and > refactoring the loop instead of creating a new variable, whose > handling takes space? I'm not sure it can be done because I'm on > vacation and reading mail through dialup access, but it might be worth > a try. A new variable was useful anyway to strip the final newline, but changing the loop logic made the code more readable. It's a standard case where the exit condition occurs in the middle of the block, not in the beginning or in the end. The patch has been applied. -- Regards, Pavel Roskin