From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, Srinivasa D S <srinivasa@in.ibm.com>
Subject: Re: [RFC] [PATCH] task_pt_regs for powerpc systems
Date: Mon, 14 Jul 2008 08:40:03 +1000 [thread overview]
Message-ID: <1215988803.7549.214.camel@pasglop> (raw)
In-Reply-To: <18554.33417.542066.185326@cargo.ozlabs.ibm.com>
On Mon, 2008-07-14 at 08:32 +1000, Paul Mackerras wrote:
> Srinivasa D S writes:
>
> > task_pt_regs() macro defines pt_regs for the given task, this macro is
> > currently not defined for powerpc arch. We need this macro for
> > upcoming utrace features.
> > Below attached patch defines this macro for powerpc arch. Please let
> > me know your comments on this.
>
> > +#define task_pt_regs(tsk) ((struct pt_regs *)(tsk)->thread.regs)
>
> The cast is unnecessary since tsk->thread.regs is already a struct
> pt_regs *. Also note that tsk->thread.regs will be NULL for a kernel
> thread.
Hrm.. I stuck that one in powerpc master, but not yet in next. Wonder if
I should back it out, sounds like a minor issue.
Ben.
next prev parent reply other threads:[~2008-07-13 22:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 14:22 [RFC] [PATCH] task_pt_regs for powerpc systems Srinivasa D S
2008-07-08 6:21 ` Benjamin Herrenschmidt
2008-07-13 22:32 ` Paul Mackerras
2008-07-13 22:40 ` Benjamin Herrenschmidt [this message]
2008-07-14 8:31 ` Srinivasa D S
2008-07-14 9:06 ` Benjamin Herrenschmidt
2008-07-15 9:06 ` Srinivasa D S
2008-07-15 9:15 ` Benjamin Herrenschmidt
2008-07-15 10:30 ` Srinivasa DS
2008-07-15 10:37 ` Benjamin Herrenschmidt
2008-07-14 17:21 ` Timur Tabi
2008-07-14 17:36 ` Andreas Schwab
2008-07-15 9:21 ` Srinivasa D S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215988803.7549.214.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=srinivasa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.