From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:42130 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934918AbeBMMSf (ORCPT ); Tue, 13 Feb 2018 07:18:35 -0500 From: Laurent Pinchart To: Kieran Bingham Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham , Jean-Michel Hautbois , Sergei Shtylyov , Lars-Peter Clausen , Kieran Bingham , Hans Verkuil , Mauro Carvalho Chehab Subject: Re: [PATCH v3 4/5] media: adv7604: Add support for i2c_new_secondary_device Date: Tue, 13 Feb 2018 14:19:06 +0200 Message-ID: <12162268.j7DyVD3ArW@avalon> In-Reply-To: <1518473273-6333-5-git-send-email-kbingham@kernel.org> References: <1518473273-6333-1-git-send-email-kbingham@kernel.org> <1518473273-6333-5-git-send-email-kbingham@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:07:52 EET Kieran Bingham wrote: > From: Jean-Michel Hautbois >=20 > The ADV7604 has thirteen 256-byte maps that can be accessed via the main > I=B2C ports. Each map has it own I=B2C address and acts as a standard sla= ve > device on the I=B2C bus. >=20 > Allow a device tree node to override the default addresses so that > address conflicts with other devices on the same bus may be resolved at > the board description level. >=20 > Signed-off-by: Jean-Michel Hautbois > [Kieran: Re-adapted for mainline] > Signed-off-by: Kieran Bingham >=20 > --- > Based upon the original posting : > https://lkml.org/lkml/2014/10/22/469 >=20 > v2: > - Split out DT bindings from driver updates > - Return -EINVAL on error paths from adv76xx_dummy_client() >=20 > drivers/media/i2c/adv7604.c | 62 ++++++++++++++++++++++++++-------------= =2D-- > 1 file changed, 40 insertions(+), 22 deletions(-) >=20 > diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c > index 1544920ec52d..872e124793f8 100644 > --- a/drivers/media/i2c/adv7604.c > +++ b/drivers/media/i2c/adv7604.c > @@ -2734,6 +2734,27 @@ static const struct v4l2_ctrl_config > adv76xx_ctrl_free_run_color =3D { >=20 > /* ---------------------------------------------------------------------= */ >=20 > +struct adv76xx_register { adv76xx_register seems to imply that this describes a particular register,= =20 while the structure describes a registers map. How about adv76xx_register_m= ap,=20 adv76xx_register_bank or adv76xx_register_page ? > + const char *name; > + u8 default_addr; > +}; > + > +static const struct adv76xx_register adv76xx_secondary_names[] =3D { The table doesn't contain secondary names only as there's an entry for the= =20 main map. How about calling it adv76xx_default_addresses or something along= =20 the same line ? > + [ADV76XX_PAGE_IO] =3D { "main", 0x4c }, > + [ADV7604_PAGE_AVLINK] =3D { "avlink", 0x42 }, > + [ADV76XX_PAGE_CEC] =3D { "cec", 0x40 }, > + [ADV76XX_PAGE_INFOFRAME] =3D { "infoframe", 0x3e }, > + [ADV7604_PAGE_ESDP] =3D { "esdp", 0x38 }, > + [ADV7604_PAGE_DPP] =3D { "dpp", 0x3c }, > + [ADV76XX_PAGE_AFE] =3D { "afe", 0x26 }, > + [ADV76XX_PAGE_REP] =3D { "rep", 0x32 }, > + [ADV76XX_PAGE_EDID] =3D { "edid", 0x36 }, > + [ADV76XX_PAGE_HDMI] =3D { "hdmi", 0x34 }, > + [ADV76XX_PAGE_TEST] =3D { "test", 0x30 }, > + [ADV76XX_PAGE_CP] =3D { "cp", 0x22 }, > + [ADV7604_PAGE_VDP] =3D { "vdp", 0x24 }, > +}; > + > static int adv76xx_core_init(struct v4l2_subdev *sd) > { > struct adv76xx_state *state =3D to_state(sd); > @@ -2834,13 +2855,26 @@ static void adv76xx_unregister_clients(struct > adv76xx_state *state) } >=20 > static struct i2c_client *adv76xx_dummy_client(struct v4l2_subdev *sd, > - u8 addr, u8 io_reg) > + unsigned int i) Maybe unsigned int page ? With these fixed, Reviewed-by: Laurent Pinchart > { > struct i2c_client *client =3D v4l2_get_subdevdata(sd); > + struct adv76xx_state *state =3D to_state(sd); > + struct adv76xx_platform_data *pdata =3D &state->pdata; > + unsigned int io_reg =3D 0xf2 + i; > + struct i2c_client *new_client; > + > + if (pdata && pdata->i2c_addresses[i]) > + new_client =3D i2c_new_dummy(client->adapter, > + pdata->i2c_addresses[i]); > + else > + new_client =3D i2c_new_secondary_device(client, > + adv76xx_secondary_names[i].name, > + adv76xx_secondary_names[i].default_addr); >=20 > - if (addr) > - io_write(sd, io_reg, addr << 1); > - return i2c_new_dummy(client->adapter, io_read(sd, io_reg) >> 1); > + if (new_client) > + io_write(sd, io_reg, new_client->addr << 1); > + > + return new_client; > } >=20 > static const struct adv76xx_reg_seq adv7604_recommended_settings_afe[] = =3D { > @@ -3115,20 +3149,6 @@ static int adv76xx_parse_dt(struct adv76xx_state > *state) /* Disable the interrupt for now as no DT-based board uses it. */ > state->pdata.int1_config =3D ADV76XX_INT1_CONFIG_DISABLED; >=20 > - /* Use the default I2C addresses. */ > - state->pdata.i2c_addresses[ADV7604_PAGE_AVLINK] =3D 0x42; > - state->pdata.i2c_addresses[ADV76XX_PAGE_CEC] =3D 0x40; > - state->pdata.i2c_addresses[ADV76XX_PAGE_INFOFRAME] =3D 0x3e; > - state->pdata.i2c_addresses[ADV7604_PAGE_ESDP] =3D 0x38; > - state->pdata.i2c_addresses[ADV7604_PAGE_DPP] =3D 0x3c; > - state->pdata.i2c_addresses[ADV76XX_PAGE_AFE] =3D 0x26; > - state->pdata.i2c_addresses[ADV76XX_PAGE_REP] =3D 0x32; > - state->pdata.i2c_addresses[ADV76XX_PAGE_EDID] =3D 0x36; > - state->pdata.i2c_addresses[ADV76XX_PAGE_HDMI] =3D 0x34; > - state->pdata.i2c_addresses[ADV76XX_PAGE_TEST] =3D 0x30; > - state->pdata.i2c_addresses[ADV76XX_PAGE_CP] =3D 0x22; > - state->pdata.i2c_addresses[ADV7604_PAGE_VDP] =3D 0x24; > - > /* Hardcode the remaining platform data fields. */ > state->pdata.disable_pwrdnb =3D 0; > state->pdata.disable_cable_det_rst =3D 0; > @@ -3478,11 +3498,9 @@ static int adv76xx_probe(struct i2c_client *client, > if (!(BIT(i) & state->info->page_mask)) > continue; >=20 > - state->i2c_clients[i] =3D > - adv76xx_dummy_client(sd, state->pdata.i2c_addresses[i], > - 0xf2 + i); > + state->i2c_clients[i] =3D adv76xx_dummy_client(sd, i); > if (!state->i2c_clients[i]) { > - err =3D -ENOMEM; > + err =3D -EINVAL; > v4l2_err(sd, "failed to create i2c client %u\n", i); > goto err_i2c; > } =2D-=20 Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 4/5] media: adv7604: Add support for i2c_new_secondary_device Date: Tue, 13 Feb 2018 14:19:06 +0200 Message-ID: <12162268.j7DyVD3ArW@avalon> References: <1518473273-6333-1-git-send-email-kbingham@kernel.org> <1518473273-6333-5-git-send-email-kbingham@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id A90FB89624 for ; Tue, 13 Feb 2018 12:18:35 +0000 (UTC) In-Reply-To: <1518473273-6333-5-git-send-email-kbingham@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: Sergei Shtylyov , Kieran Bingham , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Kieran Bingham , Hans Verkuil , Jean-Michel Hautbois , Mauro Carvalho Chehab , linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUdWVzZGF5LCAxMyBGZWJy dWFyeSAyMDE4IDAwOjA3OjUyIEVFVCBLaWVyYW4gQmluZ2hhbSB3cm90ZToKPiBGcm9tOiBKZWFu LU1pY2hlbCBIYXV0Ym9pcyA8amVhbi1taWNoZWwuaGF1dGJvaXNAdm9kYWx5cy5jb20+Cj4gCj4g VGhlIEFEVjc2MDQgaGFzIHRoaXJ0ZWVuIDI1Ni1ieXRlIG1hcHMgdGhhdCBjYW4gYmUgYWNjZXNz ZWQgdmlhIHRoZSBtYWluCj4gScKyQyBwb3J0cy4gRWFjaCBtYXAgaGFzIGl0IG93biBJwrJDIGFk ZHJlc3MgYW5kIGFjdHMgYXMgYSBzdGFuZGFyZCBzbGF2ZQo+IGRldmljZSBvbiB0aGUgScKyQyBi dXMuCj4gCj4gQWxsb3cgYSBkZXZpY2UgdHJlZSBub2RlIHRvIG92ZXJyaWRlIHRoZSBkZWZhdWx0 IGFkZHJlc3NlcyBzbyB0aGF0Cj4gYWRkcmVzcyBjb25mbGljdHMgd2l0aCBvdGhlciBkZXZpY2Vz IG9uIHRoZSBzYW1lIGJ1cyBtYXkgYmUgcmVzb2x2ZWQgYXQKPiB0aGUgYm9hcmQgZGVzY3JpcHRp b24gbGV2ZWwuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmVhbi1NaWNoZWwgSGF1dGJvaXMgPGplYW4t bWljaGVsLmhhdXRib2lzQHZvZGFseXMuY29tPgo+IFtLaWVyYW46IFJlLWFkYXB0ZWQgZm9yIG1h aW5saW5lXQo+IFNpZ25lZC1vZmYtYnk6IEtpZXJhbiBCaW5naGFtIDxraWVyYW4uYmluZ2hhbSty ZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gCj4gLS0tCj4gQmFzZWQgdXBvbiB0aGUgb3JpZ2lu YWwgcG9zdGluZyA6Cj4gICBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxNC8xMC8yMi80NjkKPiAK PiB2MjoKPiAgLSBTcGxpdCBvdXQgRFQgYmluZGluZ3MgZnJvbSBkcml2ZXIgdXBkYXRlcwo+ICAt IFJldHVybiAtRUlOVkFMIG9uIGVycm9yIHBhdGhzIGZyb20gYWR2NzZ4eF9kdW1teV9jbGllbnQo KQo+IAo+ICBkcml2ZXJzL21lZGlhL2kyYy9hZHY3NjA0LmMgfCA2MiArKysrKysrKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlv bnMoKyksIDIyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL2ky Yy9hZHY3NjA0LmMgYi9kcml2ZXJzL21lZGlhL2kyYy9hZHY3NjA0LmMKPiBpbmRleCAxNTQ0OTIw ZWM1MmQuLjg3MmUxMjQ3OTNmOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlhL2kyYy9hZHY3 NjA0LmMKPiArKysgYi9kcml2ZXJzL21lZGlhL2kyYy9hZHY3NjA0LmMKPiBAQCAtMjczNCw2ICsy NzM0LDI3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgdjRsMl9jdHJsX2NvbmZpZwo+IGFkdjc2eHhf Y3RybF9mcmVlX3J1bl9jb2xvciA9IHsKPiAKPiAgLyogLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tICovCj4gCj4gK3N0 cnVjdCBhZHY3Nnh4X3JlZ2lzdGVyIHsKCmFkdjc2eHhfcmVnaXN0ZXIgc2VlbXMgdG8gaW1wbHkg dGhhdCB0aGlzIGRlc2NyaWJlcyBhIHBhcnRpY3VsYXIgcmVnaXN0ZXIsIAp3aGlsZSB0aGUgc3Ry dWN0dXJlIGRlc2NyaWJlcyBhIHJlZ2lzdGVycyBtYXAuIEhvdyBhYm91dCBhZHY3Nnh4X3JlZ2lz dGVyX21hcCwgCmFkdjc2eHhfcmVnaXN0ZXJfYmFuayBvciBhZHY3Nnh4X3JlZ2lzdGVyX3BhZ2Ug PwoKPiArCWNvbnN0IGNoYXIgKm5hbWU7Cj4gKwl1OCBkZWZhdWx0X2FkZHI7Cj4gK307Cj4gKwo+ ICtzdGF0aWMgY29uc3Qgc3RydWN0IGFkdjc2eHhfcmVnaXN0ZXIgYWR2NzZ4eF9zZWNvbmRhcnlf bmFtZXNbXSA9IHsKClRoZSB0YWJsZSBkb2Vzbid0IGNvbnRhaW4gc2Vjb25kYXJ5IG5hbWVzIG9u bHkgYXMgdGhlcmUncyBhbiBlbnRyeSBmb3IgdGhlIAptYWluIG1hcC4gSG93IGFib3V0IGNhbGxp bmcgaXQgYWR2NzZ4eF9kZWZhdWx0X2FkZHJlc3NlcyBvciBzb21ldGhpbmcgYWxvbmcgCnRoZSBz YW1lIGxpbmUgPwoKPiArCVtBRFY3NlhYX1BBR0VfSU9dID0geyAibWFpbiIsIDB4NGMgfSwKPiAr CVtBRFY3NjA0X1BBR0VfQVZMSU5LXSA9IHsgImF2bGluayIsIDB4NDIgfSwKPiArCVtBRFY3NlhY X1BBR0VfQ0VDXSA9IHsgImNlYyIsIDB4NDAgfSwKPiArCVtBRFY3NlhYX1BBR0VfSU5GT0ZSQU1F XSA9IHsgImluZm9mcmFtZSIsIDB4M2UgfSwKPiArCVtBRFY3NjA0X1BBR0VfRVNEUF0gPSB7ICJl c2RwIiwgMHgzOCB9LAo+ICsJW0FEVjc2MDRfUEFHRV9EUFBdID0geyAiZHBwIiwgMHgzYyB9LAo+ ICsJW0FEVjc2WFhfUEFHRV9BRkVdID0geyAiYWZlIiwgMHgyNiB9LAo+ICsJW0FEVjc2WFhfUEFH RV9SRVBdID0geyAicmVwIiwgMHgzMiB9LAo+ICsJW0FEVjc2WFhfUEFHRV9FRElEXSA9IHsgImVk aWQiLCAweDM2IH0sCj4gKwlbQURWNzZYWF9QQUdFX0hETUldID0geyAiaGRtaSIsIDB4MzQgfSwK PiArCVtBRFY3NlhYX1BBR0VfVEVTVF0gPSB7ICJ0ZXN0IiwgMHgzMCB9LAo+ICsJW0FEVjc2WFhf UEFHRV9DUF0gPSB7ICJjcCIsIDB4MjIgfSwKPiArCVtBRFY3NjA0X1BBR0VfVkRQXSA9IHsgInZk cCIsIDB4MjQgfSwKPiArfTsKPiArCj4gIHN0YXRpYyBpbnQgYWR2NzZ4eF9jb3JlX2luaXQoc3Ry dWN0IHY0bDJfc3ViZGV2ICpzZCkKPiAgewo+ICAJc3RydWN0IGFkdjc2eHhfc3RhdGUgKnN0YXRl ID0gdG9fc3RhdGUoc2QpOwo+IEBAIC0yODM0LDEzICsyODU1LDI2IEBAIHN0YXRpYyB2b2lkIGFk djc2eHhfdW5yZWdpc3Rlcl9jbGllbnRzKHN0cnVjdAo+IGFkdjc2eHhfc3RhdGUgKnN0YXRlKSB9 Cj4gCj4gIHN0YXRpYyBzdHJ1Y3QgaTJjX2NsaWVudCAqYWR2NzZ4eF9kdW1teV9jbGllbnQoc3Ry dWN0IHY0bDJfc3ViZGV2ICpzZCwKPiAtCQkJCQkJCXU4IGFkZHIsIHU4IGlvX3JlZykKPiArCQkJ CQkgICAgICAgdW5zaWduZWQgaW50IGkpCgpNYXliZSB1bnNpZ25lZCBpbnQgcGFnZSA/CgpXaXRo IHRoZXNlIGZpeGVkLAoKUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGlu Y2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gIHsKPiAgCXN0cnVjdCBpMmNfY2xpZW50ICpjbGll bnQgPSB2NGwyX2dldF9zdWJkZXZkYXRhKHNkKTsKPiArCXN0cnVjdCBhZHY3Nnh4X3N0YXRlICpz dGF0ZSA9IHRvX3N0YXRlKHNkKTsKPiArCXN0cnVjdCBhZHY3Nnh4X3BsYXRmb3JtX2RhdGEgKnBk YXRhID0gJnN0YXRlLT5wZGF0YTsKPiArCXVuc2lnbmVkIGludCBpb19yZWcgPSAweGYyICsgaTsK PiArCXN0cnVjdCBpMmNfY2xpZW50ICpuZXdfY2xpZW50Owo+ICsKPiArCWlmIChwZGF0YSAmJiBw ZGF0YS0+aTJjX2FkZHJlc3Nlc1tpXSkKPiArCQluZXdfY2xpZW50ID0gaTJjX25ld19kdW1teShj bGllbnQtPmFkYXB0ZXIsCj4gKwkJCQkJICAgcGRhdGEtPmkyY19hZGRyZXNzZXNbaV0pOwo+ICsJ ZWxzZQo+ICsJCW5ld19jbGllbnQgPSBpMmNfbmV3X3NlY29uZGFyeV9kZXZpY2UoY2xpZW50LAo+ ICsJCQkJYWR2NzZ4eF9zZWNvbmRhcnlfbmFtZXNbaV0ubmFtZSwKPiArCQkJCWFkdjc2eHhfc2Vj b25kYXJ5X25hbWVzW2ldLmRlZmF1bHRfYWRkcik7Cj4gCj4gLQlpZiAoYWRkcikKPiAtCQlpb193 cml0ZShzZCwgaW9fcmVnLCBhZGRyIDw8IDEpOwo+IC0JcmV0dXJuIGkyY19uZXdfZHVtbXkoY2xp ZW50LT5hZGFwdGVyLCBpb19yZWFkKHNkLCBpb19yZWcpID4+IDEpOwo+ICsJaWYgKG5ld19jbGll bnQpCj4gKwkJaW9fd3JpdGUoc2QsIGlvX3JlZywgbmV3X2NsaWVudC0+YWRkciA8PCAxKTsKPiAr Cj4gKwlyZXR1cm4gbmV3X2NsaWVudDsKPiAgfQo+IAo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGFk djc2eHhfcmVnX3NlcSBhZHY3NjA0X3JlY29tbWVuZGVkX3NldHRpbmdzX2FmZVtdID0gewo+IEBA IC0zMTE1LDIwICszMTQ5LDYgQEAgc3RhdGljIGludCBhZHY3Nnh4X3BhcnNlX2R0KHN0cnVjdCBh ZHY3Nnh4X3N0YXRlCj4gKnN0YXRlKSAvKiBEaXNhYmxlIHRoZSBpbnRlcnJ1cHQgZm9yIG5vdyBh cyBubyBEVC1iYXNlZCBib2FyZCB1c2VzIGl0LiAqLwo+IHN0YXRlLT5wZGF0YS5pbnQxX2NvbmZp ZyA9IEFEVjc2WFhfSU5UMV9DT05GSUdfRElTQUJMRUQ7Cj4gCj4gLQkvKiBVc2UgdGhlIGRlZmF1 bHQgSTJDIGFkZHJlc3Nlcy4gKi8KPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRkcmVzc2VzW0FEVjc2 MDRfUEFHRV9BVkxJTktdID0gMHg0MjsKPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRkcmVzc2VzW0FE Vjc2WFhfUEFHRV9DRUNdID0gMHg0MDsKPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRkcmVzc2VzW0FE Vjc2WFhfUEFHRV9JTkZPRlJBTUVdID0gMHgzZTsKPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRkcmVz c2VzW0FEVjc2MDRfUEFHRV9FU0RQXSA9IDB4Mzg7Cj4gLQlzdGF0ZS0+cGRhdGEuaTJjX2FkZHJl c3Nlc1tBRFY3NjA0X1BBR0VfRFBQXSA9IDB4M2M7Cj4gLQlzdGF0ZS0+cGRhdGEuaTJjX2FkZHJl c3Nlc1tBRFY3NlhYX1BBR0VfQUZFXSA9IDB4MjY7Cj4gLQlzdGF0ZS0+cGRhdGEuaTJjX2FkZHJl c3Nlc1tBRFY3NlhYX1BBR0VfUkVQXSA9IDB4MzI7Cj4gLQlzdGF0ZS0+cGRhdGEuaTJjX2FkZHJl c3Nlc1tBRFY3NlhYX1BBR0VfRURJRF0gPSAweDM2Owo+IC0Jc3RhdGUtPnBkYXRhLmkyY19hZGRy ZXNzZXNbQURWNzZYWF9QQUdFX0hETUldID0gMHgzNDsKPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRk cmVzc2VzW0FEVjc2WFhfUEFHRV9URVNUXSA9IDB4MzA7Cj4gLQlzdGF0ZS0+cGRhdGEuaTJjX2Fk ZHJlc3Nlc1tBRFY3NlhYX1BBR0VfQ1BdID0gMHgyMjsKPiAtCXN0YXRlLT5wZGF0YS5pMmNfYWRk cmVzc2VzW0FEVjc2MDRfUEFHRV9WRFBdID0gMHgyNDsKPiAtCj4gIAkvKiBIYXJkY29kZSB0aGUg cmVtYWluaW5nIHBsYXRmb3JtIGRhdGEgZmllbGRzLiAqLwo+ICAJc3RhdGUtPnBkYXRhLmRpc2Fi bGVfcHdyZG5iID0gMDsKPiAgCXN0YXRlLT5wZGF0YS5kaXNhYmxlX2NhYmxlX2RldF9yc3QgPSAw Owo+IEBAIC0zNDc4LDExICszNDk4LDkgQEAgc3RhdGljIGludCBhZHY3Nnh4X3Byb2JlKHN0cnVj dCBpMmNfY2xpZW50ICpjbGllbnQsCj4gIAkJaWYgKCEoQklUKGkpICYgc3RhdGUtPmluZm8tPnBh Z2VfbWFzaykpCj4gIAkJCWNvbnRpbnVlOwo+IAo+IC0JCXN0YXRlLT5pMmNfY2xpZW50c1tpXSA9 Cj4gLQkJCWFkdjc2eHhfZHVtbXlfY2xpZW50KHNkLCBzdGF0ZS0+cGRhdGEuaTJjX2FkZHJlc3Nl c1tpXSwKPiAtCQkJCQkgICAgIDB4ZjIgKyBpKTsKPiArCQlzdGF0ZS0+aTJjX2NsaWVudHNbaV0g PSBhZHY3Nnh4X2R1bW15X2NsaWVudChzZCwgaSk7Cj4gIAkJaWYgKCFzdGF0ZS0+aTJjX2NsaWVu dHNbaV0pIHsKPiAtCQkJZXJyID0gLUVOT01FTTsKPiArCQkJZXJyID0gLUVJTlZBTDsKPiAgCQkJ djRsMl9lcnIoc2QsICJmYWlsZWQgdG8gY3JlYXRlIGkyYyBjbGllbnQgJXVcbiIsIGkpOwo+ICAJ CQlnb3RvIGVycl9pMmM7Cj4gIAkJfQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK