All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mundt <lethal@linux-sh.org>
Cc: Grant Likely <grant.likely@secretlab.ca>,
	petkovbb@googlemail.com, jrigby@freescale.com,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] Fix collateral damage to top level Makefile
Date: Thu, 17 Jul 2008 18:50:24 +1000	[thread overview]
Message-ID: <1216284624.7740.326.camel@pasglop> (raw)
In-Reply-To: <20080717072731.GB12273@linux-sh.org>

On Thu, 2008-07-17 at 16:27 +0900, Paul Mundt wrote:
> On Thu, Jul 17, 2008 at 01:06:55AM -0600, Grant Likely wrote:
> > From: Grant Likely <grant.likely@secretlab.ca>
> > 
> > The patch named "powerpc/mpc5121: Add clock driver", also contained
> > an unrelated and bogus change to the top-level makefile.  This patch
> > backs out the bad bit.
> > 
> > SHA1 of offending patch: 137e95906e294913fab02162e8a1948ade49acb5)
> > 
> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> > ---
> > 
> > If the maintainer who picked up this patch (Grant Likely) had done
> > his job, this cack-up never would have happened.  Why do we still
> > have to deal with such sloppy individuals?
> > 
> I think the more important question is why the hell would anyone put that
> in a Makefile, ever? ;-)

Well, it's partially my fault for not spotting it when pulling in
Grant's git and pushing out to Linus.

Anyway, it's a mistake, shit happens, I doubt Grant will do that one
twice :-)

Cheers,
Ben.



  reply	other threads:[~2008-07-17  8:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17  7:06 [PATCH] Fix collateral damage to top level Makefile Grant Likely
2008-07-17  7:27 ` Paul Mundt
2008-07-17  8:50   ` Benjamin Herrenschmidt [this message]
2008-07-17  9:49     ` Boris Petkov
2008-07-17 15:11       ` Grant Likely
2008-07-17 16:01 ` John Rigby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216284624.7740.326.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jrigby@freescale.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petkovbb@googlemail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.