From: jamal <hadi@cyberus.ca>
To: Andreas Henriksson <andreas@fatal.se>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
Johannes Berg <johannes@sipsolutions.net>,
489340@bugs.debian.org, netdev@vger.kernel.org
Subject: Re: iproute2: no error message when link up command fails.
Date: Thu, 17 Jul 2008 06:31:54 -0400 [thread overview]
Message-ID: <1216290714.4638.49.camel@localhost> (raw)
In-Reply-To: <1216254660.31646.54.camel@amd64.fatal.se>
On Thu, 2008-17-07 at 02:31 +0200, Andreas Henriksson wrote:
> Why?
Thats just how it rolls.
> This seems like a really bad idea to me, and none of the callers in
> iproute benefits from this as far as I can see.
The receiver(kernel in this case, but it could be some other user space
user) returning a zero means success. Essentially zero is an (Positive)
ACK.
The receiver returning a non-zero implies a failure. Essentially a
N(egative) ACK.
In the case of a NACK, the kernel must return you the original message
header you sent (similar to the way some icmp messages behave).
The returned error code is a standard errno - if you sent a bad config
you may get an EINVAL back. The sender combines the errno + the header
to figure out what went wrong.
Does that make sense? So the kernel fix is required (as Stephen noted).
cheers,
jamal
prev parent reply other threads:[~2008-07-17 10:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 22:00 Bug#489340: iproute2: no error message when link up command fails Andreas Henriksson
2008-07-16 22:03 ` Stephen Hemminger
2008-07-16 22:27 ` Andreas Henriksson
2008-07-16 22:26 ` Stephen Hemminger
2008-07-16 22:35 ` Johannes Berg
2008-07-16 22:53 ` Stephen Hemminger
2008-07-17 0:31 ` Andreas Henriksson
2008-07-17 9:26 ` Patrick McHardy
2008-07-17 9:59 ` Jarek Poplawski
2008-07-17 10:31 ` jamal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216290714.4638.49.camel@localhost \
--to=hadi@cyberus.ca \
--cc=489340@bugs.debian.org \
--cc=andreas@fatal.se \
--cc=johannes@sipsolutions.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.