From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KJVvP-0000uX-99 for mharc-grub-devel@gnu.org; Thu, 17 Jul 2008 12:01:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KJVvN-0000sg-2d for grub-devel@gnu.org; Thu, 17 Jul 2008 12:01:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KJVvL-0000rr-UQ for grub-devel@gnu.org; Thu, 17 Jul 2008 12:01:44 -0400 Received: from [199.232.76.173] (port=52499 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KJVvL-0000rY-0g for grub-devel@gnu.org; Thu, 17 Jul 2008 12:01:43 -0400 Received: from ug-out-1314.google.com ([66.249.92.173]:63313) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KJVvK-0004TU-9c for grub-devel@gnu.org; Thu, 17 Jul 2008 12:01:42 -0400 Received: by ug-out-1314.google.com with SMTP id l31so749538ugc.48 for ; Thu, 17 Jul 2008 09:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:in-reply-to :references:content-type:date:message-id:mime-version:x-mailer; bh=HRLw19WxW5PIgI3hRtWPoHcWNfRChrodheToIZC7LQ8=; b=V1dkUl4N1ZXeN1ZRIUaeE8b5XOQoTZATYq/liXLTa+OJdNw4+3DSLQgSUgrKWkNvQm 2amJItKtkLKJseLhO2Vwb6VCbCXB+Xz/UMSySjgV+Ztp3j7/c0wzVVrqjriksvdWG1KQ Sq5M+/YdY/JQvCnhiQmPgFh+nMvm5np6KTzb8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:in-reply-to:references:content-type:date:message-id :mime-version:x-mailer; b=wE9ju6h3xRvMjnglu0zX3vXRlBcRZE8QFQzq4dFU3UjRq9waAFNOh2FlKDIfbkoWE1 cDKDII3qwIB5eDX5vEhoE0f1wDjwLn0cnNRttGMyvZpF6K/inE40CD+5XBt+ouIT7r/l sDhQz0yuo9cz0COUtP/EJBR7BwKJUZkQjvB6g= Received: by 10.67.115.12 with SMTP id s12mr4017955ugm.51.1216310497582; Thu, 17 Jul 2008 09:01:37 -0700 (PDT) Received: from ?192.168.1.100? ( [213.37.137.93]) by mx.google.com with ESMTPS id k30sm14334517ugc.31.2008.07.17.09.01.35 (version=SSLv3 cipher=RC4-MD5); Thu, 17 Jul 2008 09:01:36 -0700 (PDT) From: Javier =?ISO-8859-1?Q?Mart=EDn?= To: The development of GRUB 2 In-Reply-To: References: <487392C9.40208@isaac.cedarswampstudios.org> <20080712144131.GE25455@thorin> <1216306949.21767.20.camel@localhost> <1216308135.16120.5.camel@dv> <1216309517.21767.26.camel@localhost> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-bfQLWGMHLbEjICQHAXFS" Date: Thu, 17 Jul 2008 18:01:56 +0200 Message-Id: <1216310516.21767.29.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) Subject: Re: [PATCH] New x86_64 EFI patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jul 2008 16:01:46 -0000 --=-bfQLWGMHLbEjICQHAXFS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable El jue, 17-07-2008 a las 23:50 +0800, Bean escribi=C3=B3: > On Thu, Jul 17, 2008 at 11:45 PM, Javier Mart=C3=ADn wrote: > > El jue, 17-07-2008 a las 23:26 +0800, Bean escribi=C3=B3: > >> On Thu, Jul 17, 2008 at 11:22 PM, Pavel Roskin wrote: > >> > On Thu, 2008-07-17 at 17:02 +0200, Javier Mart=C3=ADn wrote: > >> >> El jue, 17-07-2008 a las 17:50 +0800, Bean escribi=C3=B3: > >> >> > Committed. > >> >> > > >> >> Seemingly, the fact that there is now separate recognition for "x86= _64" > >> >> machine types has borked the current build system in amd64 PCs: > >> >> > >> >> $ make > >> >> ./config.status --recheck > >> >> running CONFIG_SHELL=3D/bin/bash /bin/bash ../src/configure > >> >> --prefix=3D/home/javier/Proyectos/grub/build/out/ --no-create > >> >> --no-recursion > >> >> checking build system type... x86_64-unknown-linux-gnu > >> >> checking host system type... x86_64-unknown-linux-gnu > >> >> checking target system type... x86_64-unknown-linux-gnu > >> >> configure: error: unsupported machine type > >> >> make: *** [config.status] Error 1 > >> > > >> > I've just noticed that. I think x86_64 should default to "i386-pc" > >> > platform. I'll have a look how to do it nicely. > >> > >> I have the following in configure.ac: > >> > >> if test "x$platform" =3D "xefi" ; then > >> case "$target_cpu" in > >> i386) ;; > >> x86_64) target_m64=3D1 ;; > >> *) AC_MSG_ERROR([unsupported CPU type for EFI]) ;; > >> esac > >> else > >> case "$target_cpu" in > >> i386) ;; > >> x86_64) target_cpu=3Di386 target_m32=3D1 ;; > >> powerpc) ;; > >> powerpc64) target_cpu=3Dpowerpc target_m32=3D1;; > >> sparc64) ;; > >> *) AC_MSG_ERROR([unsupported CPU type]) ;; > >> esac > >> fi > >> > >> If platform is not efi, x86_64 will become i386, perhaps there is > >> something I miss ? > >> > > > > It does not reach that point, the "unsupported machine type" message is > > thrown by this earlier check (line 59) >=20 > Hi, >=20 > Oh, you're right, use this patch: >=20 > diff --git a/configure.ac b/configure.ac > index 943b9fe..45eb472 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -61,6 +61,7 @@ if test "x$with_platform" =3D x; then > case "$target_cpu"-"$target_vendor" in > i386-apple) platform=3Defi ;; > i386-*) platform=3Dpc ;; > + x86_64-*) platform=3Dpc ;; > powerpc-*) platform=3Dieee1275 ;; > sparc64-*) platform=3Dieee1275 ;; > *) AC_MSG_ERROR([unsupported machine type]) ;; >=20 >=20 I think this one would be better, as it follows the structure what's done with i386: vendor=3Dapple -> efi; anything_else -> pc. Also, this one errors out with a more understandable message that does not conflict with another check some lines down. Index: configure.ac =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- configure.ac (revisi=C3=B3n: 1714) +++ configure.ac (copia de trabajo) @@ -59,11 +59,11 @@ # Guess the platform if not specified. if test "x$with_platform" =3D x; then case "$target_cpu"-"$target_vendor" in - i386-apple) platform=3Defi ;; - i386-*) platform=3Dpc ;; + i386-apple|x86_64-apple) platform=3Defi ;; + i386-*|x86_64-*) platform=3Dpc ;; powerpc-*) platform=3Dieee1275 ;; sparc64-*) platform=3Dieee1275 ;; - *) AC_MSG_ERROR([unsupported machine type]) ;; + *) AC_MSG_ERROR([unable to guess platform. Use --with-platform]) ;; esac else platform=3D"$with_platform" --=-bfQLWGMHLbEjICQHAXFS Content-Type: application/pgp-signature; name=signature.asc Content-Description: Esta parte del mensaje =?ISO-8859-1?Q?est=E1?= firmada digitalmente -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iQIVAwUASH9s9KSl+Fbdeo72AQLEaQ//YYdt1//y7vt6tIhrdnIdVunVrbRF6k6c PRVvhGoOkyPUYfkLOwnCzxQfAclwszeOzPsWMA7hw/IkJPbyGOGieUa2e9ekmY3L Q2Zzck8DHy4x0AMvnIsQVzNepojx6lLhpzp6iZzuvOcb3YTFXmv75vOR2PMKHOor DOzPy7Zj/IEKgMy1p8KljWFyP+Vqw0ivg5rwbG6R2ONjdt+urNlg48IospbgQydi aYefY14rjfQ/Zpq4S2ovI6McyXoFsWvNrKJT2/mhFxP9xdqCkrANmJTJghbj0G3Z 4HEv/LN/0yl4T8wZl1t6zj+Q4R2mvHdeaIqM+i0SZNkLdpb5bImB+hlDRtcY5KlJ O3n9MU7uZfjhgxc0UNR0DNblbQiLQhiaZwHbjVXoqHMAIrzeDfUxZmC27MGAgTuI 9N6gJYv0qWj0Kqf0K6MzjWIh3CN5AYYQJoxRRxP/isJoRdMQps619wbkAQGY8t4y nLoX7QfVwIE64MnI5a54TOSMXwyNlgH2Z+aGC32hS4n109ZiLmIf4AlcZRo8GiFQ 2b4ujGpMd6fLCEppnNMGs7ujZgQgMwU5dIsEyGK6rv7FN5bdpCGNvnN9Xs6z6Dzu 09Fw0fw2yY+O5MTFfb3qO8z7AeOukcRLPy3QF6MhUOoqMpvRPQf+kxqYFdQY8UDq qO9iNE6ZytQ= =St3n -----END PGP SIGNATURE----- --=-bfQLWGMHLbEjICQHAXFS--