From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KJWAh-0001rE-3n for mharc-grub-devel@gnu.org; Thu, 17 Jul 2008 12:17:35 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KJWAf-0001qm-GE for grub-devel@gnu.org; Thu, 17 Jul 2008 12:17:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KJWAe-0001qJ-NN for grub-devel@gnu.org; Thu, 17 Jul 2008 12:17:33 -0400 Received: from [199.232.76.173] (port=53766 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KJWAe-0001q6-HZ for grub-devel@gnu.org; Thu, 17 Jul 2008 12:17:32 -0400 Received: from c60.cesmail.net ([216.154.195.49]:42147) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KJWAe-0001ck-9c for grub-devel@gnu.org; Thu, 17 Jul 2008 12:17:32 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 17 Jul 2008 12:17:31 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 257154F1869 for ; Thu, 17 Jul 2008 12:17:31 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <1216310516.21767.29.camel@localhost> References: <487392C9.40208@isaac.cedarswampstudios.org> <20080712144131.GE25455@thorin> <1216306949.21767.20.camel@localhost> <1216308135.16120.5.camel@dv> <1216309517.21767.26.camel@localhost> <1216310516.21767.29.camel@localhost> Content-Type: text/plain; charset=ISO-8859-1 Date: Thu, 17 Jul 2008 12:17:30 -0400 Message-Id: <1216311450.16120.24.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 8bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] New x86_64 EFI patch X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jul 2008 16:17:33 -0000 On Thu, 2008-07-17 at 18:01 +0200, Javier Martín wrote: > I think this one would be better, as it follows the structure what's > done with i386: vendor=apple -> efi; anything_else -> pc. That's a good call. I'm working on a more radical patch now. I'll post it for review. > Also, this one > errors out with a more understandable message that does not conflict > with another check some lines down. I agree that the messages should be improved. > Index: configure.ac > =================================================================== > --- configure.ac (revisión: 1714) > +++ configure.ac (copia de trabajo) > @@ -59,11 +59,11 @@ > # Guess the platform if not specified. > if test "x$with_platform" = x; then > case "$target_cpu"-"$target_vendor" in > - i386-apple) platform=efi ;; > - i386-*) platform=pc ;; > + i386-apple|x86_64-apple) platform=efi ;; > + i386-*|x86_64-*) platform=pc ;; > powerpc-*) platform=ieee1275 ;; > sparc64-*) platform=ieee1275 ;; > - *) AC_MSG_ERROR([unsupported machine type]) ;; > + *) AC_MSG_ERROR([unable to guess platform. Use --with-platform]) ;; That's misleading. We can guess platform for any supported CPU (well, we try out best). The real problem is that the CPU is not supported, and that's what the message should say. -- Regards, Pavel Roskin