From: Harvey Harrison <harvey.harrison@gmail.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] nfs: nfs4xdr use C99 array initializers
Date: Fri, 18 Jul 2008 11:02:07 -0700 [thread overview]
Message-ID: <1216404127.6029.149.camel@brick> (raw)
In-Reply-To: <20080718180115.GJ8035@fieldses.org>
On Fri, 2008-07-18 at 14:01 -0400, J. Bruce Fields wrote:
> On Thu, Jul 17, 2008 at 09:33:03PM -0700, Harvey Harrison wrote:
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
>
> OK, thanks. But I'd rather just skip the macro:
>
> > +#define NFSD4_DEC_OP(idx, op) [(idx)] = (nfsd4_dec)(op)
> > - [OP_ACCESS] (nfsd4_dec)nfsd4_decode_access,
> > - [OP_CLOSE] (nfsd4_dec)nfsd4_decode_close,
> > - [OP_COMMIT] (nfsd4_dec)nfsd4_decode_commit,
> > - [OP_CREATE] (nfsd4_dec)nfsd4_decode_create,
> > - [OP_DELEGPURGE] (nfsd4_dec)nfsd4_decode_notsupp,
> ...
> > + NFSD4_DEC_OP(OP_ACCESS, nfsd4_decode_access),
> > + NFSD4_DEC_OP(OP_CLOSE, nfsd4_decode_close),
> > + NFSD4_DEC_OP(OP_COMMIT, nfsd4_decode_commit),
> > + NFSD4_DEC_OP(OP_CREATE, nfsd4_decode_create),
> > + NFSD4_DEC_OP(OP_DELEGPURGE, nfsd4_decode_notsupp),
>
> and just add equals signs, if there's no substantial objection.
>
None here.
Harvey
next prev parent reply other threads:[~2008-07-18 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 4:33 [PATCH 1/2] nfs: nfs4xdr use C99 array initializers Harvey Harrison
2008-07-18 18:01 ` J. Bruce Fields
2008-07-18 18:02 ` Harvey Harrison [this message]
2008-07-18 19:12 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216404127.6029.149.camel@brick \
--to=harvey.harrison@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.