From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KKfVo-0000cs-TK for mharc-grub-devel@gnu.org; Sun, 20 Jul 2008 16:28:08 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KKfVn-0000cj-SQ for grub-devel@gnu.org; Sun, 20 Jul 2008 16:28:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KKfVn-0000cX-DB for grub-devel@gnu.org; Sun, 20 Jul 2008 16:28:07 -0400 Received: from [199.232.76.173] (port=57151 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KKfVn-0000cU-6v for grub-devel@gnu.org; Sun, 20 Jul 2008 16:28:07 -0400 Received: from c60.cesmail.net ([216.154.195.49]:28036) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KKfVn-0006xm-8E for grub-devel@gnu.org; Sun, 20 Jul 2008 16:28:07 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 20 Jul 2008 16:28:06 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 0FCC2618F22 for ; Sun, 20 Jul 2008 16:28:06 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <87prp8ie41.fsf@xs4all.nl> References: <20080702001046.7554.37059.stgit@dv.roinet.com> <87tzf66d6w.fsf@xs4all.nl> <1215110887.4585.35.camel@dv> <87prp8ie41.fsf@xs4all.nl> Content-Type: text/plain Date: Sun, 20 Jul 2008 16:28:05 -0400 Message-Id: <1216585685.14762.11.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fix warning in fs/xfs.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2008 20:28:08 -0000 On Sun, 2008-07-20 at 20:50 +0200, Marco Gerards wrote: > Pavel Roskin writes: > > i4 and i8 are generally used by Linux XFS code to describe 32-bit and > > 64-bit values if either can be used. The "smallino" field was highly > > misleading because it had to be negated. It's the number of "big" (i8 > > or 64-bit) entries. If it's 0, then the entries are "small". > > > > So it was natural to call it "i8count". And once it was "i8count", it > > was natural to call the first value "count". > > > > If you prefer another naming convention, let's rename the entries > > according to it. I was thinking having 2 32-bit integers "parent_hi" > > and "parent_lo" or something like that. Anyway, let's not use > > "smallino" - "bigentries" would be better. > > What I suggest is that you pick the names yourself or from a standard, > instead of from Linux code. OK, I'll try to be more creative. -- Regards, Pavel Roskin