From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nick Piggin <npiggin@suse.de>
Cc: linuxppc-dev@ozlabs.org,
Andrew Morton <akpm@linux-foundation.org>,
Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Subject: Re: [patch] powerpc: implement pte_special for 64K pages
Date: Mon, 21 Jul 2008 10:57:55 +1000 [thread overview]
Message-ID: <1216601875.11027.59.camel@pasglop> (raw)
In-Reply-To: <20080717104426.GA25083@wotan.suse.de>
On Thu, 2008-07-17 at 12:44 +0200, Nick Piggin wrote:
> This can be folded into powerpc-implement-pte_special.patch
>
> --
> Ben has now freed up a pte bit on 64k pages. Use it for special pte bit.
>
> Signed-off-by: Nick Piggin <npiggin@suse.de>
> ---
Ack.
Andrew, will you merge this or do you want me to ?
Cheers,
Ben.
> Index: linux-2.6/include/asm-powerpc/pgtable-64k.h
> ===================================================================
> --- linux-2.6.orig/include/asm-powerpc/pgtable-64k.h 2008-07-17 18:53:03.000000000 +1000
> +++ linux-2.6/include/asm-powerpc/pgtable-64k.h 2008-07-17 20:30:06.000000000 +1000
> @@ -70,11 +70,12 @@
> #define PGDIR_MASK (~(PGDIR_SIZE-1))
>
> /* Additional PTE bits (don't change without checking asm in hash_low.S) */
> +#define __HAVE_ARCH_PTE_SPECIAL
> +#define _PAGE_SPECIAL 0x00000400 /* software: special page */
> #define _PAGE_HPTE_SUB 0x0ffff000 /* combo only: sub pages HPTE bits */
> #define _PAGE_HPTE_SUB0 0x08000000 /* combo only: first sub page */
> #define _PAGE_COMBO 0x10000000 /* this is a combo 4k page */
> #define _PAGE_4K_PFN 0x20000000 /* PFN is for a single 4k page */
> -#define _PAGE_SPECIAL 0x0 /* don't have enough room for this yet */
>
> /* For 64K page, we don't have a separate _PAGE_HASHPTE bit. Instead,
> * we set that to be the whole sub-bits mask. The C code will only
next prev parent reply other threads:[~2008-07-21 1:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 10:44 [patch] powerpc: implement pte_special for 64K pages Nick Piggin
2008-07-17 10:53 ` [patch] powerpc: lockless get_user_pages Nick Piggin
2008-07-21 0:57 ` Benjamin Herrenschmidt [this message]
2008-07-21 1:16 ` [patch] powerpc: implement pte_special for 64K pages Andrew Morton
2008-07-21 1:27 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216601875.11027.59.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=npiggin@suse.de \
--cc=shaggy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.