All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: kernel BUG at extent_map.c:275!
Date: Tue, 22 Jul 2008 14:12:58 -0400	[thread overview]
Message-ID: <1216750378.6932.131.camel@think.oraclecorp.com> (raw)
In-Reply-To: <1216748498.3019.9.camel@shinybook.infradead.org>

On Tue, 2008-07-22 at 13:41 -0400, David Woodhouse wrote:
> On Tue, 2008-07-22 at 13:03 -0400, Chris Mason wrote:
> > Well, the test is there to make sure the caller is doing the right
> > thing.  Before we remove it, I'd like to understand why it is failing.
> 
> Because this is a uniprocessor kernel. So spin_lock() and spin_unlock()
> both do absolutely nothing, and spin_trylock() _always_ returns 1.
> 

Duh, sorry that's what you were saying all along.  For some reason I saw
UP machine on SMP kernel in your email.

Thanks for the patch, I'll pull it in.

-chris



  parent reply	other threads:[~2008-07-22 18:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22  3:32 [PATCH] Use do_div() instead of native 64-bit division in btrfs_ordered_sum_size() David Woodhouse
2008-07-22  3:36 ` kernel BUG at extent_map.c:275! David Woodhouse
2008-07-22 10:21   ` Chris Mason
2008-07-22 14:35     ` David Woodhouse
2008-07-22 17:03       ` Chris Mason
2008-07-22 17:41         ` David Woodhouse
2008-07-22 17:42           ` Zach Brown
2008-07-22 18:04             ` David Woodhouse
2008-07-24 14:34               ` Chris Mason
2008-07-22 18:12           ` Chris Mason [this message]
2008-07-22 14:43   ` [PATCH] Remove BUG_ON(spin_trylock()) checks which have false positives on UP David Woodhouse
2008-07-23 11:13 ` [PATCH] Use do_div() instead of native 64-bit division in btrfs_ordered_sum_size() Christoph Hellwig
2008-07-23 13:28   ` Chris Mason
2008-07-23 21:07     ` David Woodhouse
2008-07-24  0:19       ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216750378.6932.131.camel@think.oraclecorp.com \
    --to=chris.mason@oracle.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.