From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KLMud-0005N9-Eb for mharc-grub-devel@gnu.org; Tue, 22 Jul 2008 14:48:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLMub-0005MN-MV for grub-devel@gnu.org; Tue, 22 Jul 2008 14:48:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLMua-0005M4-6n for grub-devel@gnu.org; Tue, 22 Jul 2008 14:48:37 -0400 Received: from [199.232.76.173] (port=53210 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLMua-0005M1-14 for grub-devel@gnu.org; Tue, 22 Jul 2008 14:48:36 -0400 Received: from c60.cesmail.net ([216.154.195.49]:51480) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KLMua-00010M-2s for grub-devel@gnu.org; Tue, 22 Jul 2008 14:48:36 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 22 Jul 2008 14:48:32 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id B63BF618F22 for ; Tue, 22 Jul 2008 14:48:32 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080722084347.53863920@gibibit.com> References: <20080722084347.53863920@gibibit.com> Content-Type: text/plain Date: Tue, 22 Jul 2008 14:48:31 -0400 Message-Id: <1216752511.5029.4.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] File readahead buffering X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jul 2008 18:48:37 -0000 On Tue, 2008-07-22 at 08:43 -0700, Colin D Bennett wrote: > This patch speeds up loading a TGA image on my test system from 29 > seconds to approximately 1 second. > > I noticed that on my 1 GHz test system running from an IDE CompactFlash > drive, loading a certain TGA image in GRUB takes about 29 seconds. I'm sorry for straying from your point, but maybe we should drop TGA support. It was the first image format for GRUB to support, but now PNG is supported, and it should be better in all aspects. > It turns out that when booting GRUB from IDE, if file buffering is > used, GRUB hangs right after the "GRUB" message, early in the boot > process. So I added a flag that allows grub_main() to enable buffering > when it is safe to do so. It always worked file from an ISO image > (generated with grub-mkrescue) in VMware and QEMU, but when I actually > installed GRUB to my CompactFlash drive and booted it, it hung after > "GRUB" if file buffering was enabled at the start. I think we should be prefer simple and reliable code, rather than add complexity and risks of failure to achieve higher speeds. -- Regards, Pavel Roskin