From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 8C990DDECA for ; Wed, 23 Jul 2008 08:05:29 +1000 (EST) Subject: Re: latest tree build failure -- cpm uart & gpio From: Benjamin Herrenschmidt To: avorontsov@ru.mvista.com In-Reply-To: <20080722145330.GA2315@polina.dev.rtsoft.ru> References: <20080722145330.GA2315@polina.dev.rtsoft.ru> Content-Type: text/plain Date: Wed, 23 Jul 2008 08:05:09 +1000 Message-Id: <1216764309.11027.211.camel@pasglop> Mime-Version: 1.0 Cc: David Brownell , linuxppc-dev list , Kumar Gala , Linux Kernel list , Alan Cox Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2008-07-22 at 18:53 +0400, Anton Vorontsov wrote: > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote: > > can someone look at the following compile failure in linus's tree. I'm > > guessing part of this has to do with Alan's tty changes (and might > > already be addressed?). > > > > include/asm-generic/gpio.h:131: error: implicit declaration of function > > 'gpio_get_value' > > include/asm-generic/gpio.h:137: error: implicit declaration of function > > 'gpio_set_value' > > I think this patch should help: > > [OF] of_gpio: should use new header > http://patchwork.ozlabs.org/linuxppc/patch?id=18750 > > David, can you please Ack it? See Benjamin's mail: > http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html > Hrm.. I though I had that one in my latest batch. In fact, I just checked and it got merged. Ben. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755313AbYGVWFt (ORCPT ); Tue, 22 Jul 2008 18:05:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751797AbYGVWFl (ORCPT ); Tue, 22 Jul 2008 18:05:41 -0400 Received: from gate.crashing.org ([63.228.1.57]:52816 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751404AbYGVWFk (ORCPT ); Tue, 22 Jul 2008 18:05:40 -0400 Subject: Re: latest tree build failure -- cpm uart & gpio From: Benjamin Herrenschmidt Reply-To: benh@kernel.crashing.org To: avorontsov@ru.mvista.com Cc: Kumar Gala , linuxppc-dev list , Linux Kernel list , Alan Cox , David Brownell In-Reply-To: <20080722145330.GA2315@polina.dev.rtsoft.ru> References: <20080722145330.GA2315@polina.dev.rtsoft.ru> Content-Type: text/plain Date: Wed, 23 Jul 2008 08:05:09 +1000 Message-Id: <1216764309.11027.211.camel@pasglop> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2008-07-22 at 18:53 +0400, Anton Vorontsov wrote: > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote: > > can someone look at the following compile failure in linus's tree. I'm > > guessing part of this has to do with Alan's tty changes (and might > > already be addressed?). > > > > include/asm-generic/gpio.h:131: error: implicit declaration of function > > 'gpio_get_value' > > include/asm-generic/gpio.h:137: error: implicit declaration of function > > 'gpio_set_value' > > I think this patch should help: > > [OF] of_gpio: should use new header > http://patchwork.ozlabs.org/linuxppc/patch?id=18750 > > David, can you please Ack it? See Benjamin's mail: > http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html > Hrm.. I though I had that one in my latest batch. In fact, I just checked and it got merged. Ben.