From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KLpPC-0002Pe-GF for mharc-grub-devel@gnu.org; Wed, 23 Jul 2008 21:14:06 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLpPA-0002PA-Hu for grub-devel@gnu.org; Wed, 23 Jul 2008 21:14:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLpP8-0002Oe-75 for grub-devel@gnu.org; Wed, 23 Jul 2008 21:14:03 -0400 Received: from [199.232.76.173] (port=34179 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLpP8-0002OS-0z for grub-devel@gnu.org; Wed, 23 Jul 2008 21:14:02 -0400 Received: from c60.cesmail.net ([216.154.195.49]:36874) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KLpP7-0007mF-Lg for grub-devel@gnu.org; Wed, 23 Jul 2008 21:14:01 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 23 Jul 2008 21:13:59 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id D2F7A4F1869 for ; Wed, 23 Jul 2008 21:13:58 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080724005259.GA16237@spacedout.fries.net> References: <20080724005259.GA16237@spacedout.fries.net> Content-Type: text/plain Date: Wed, 23 Jul 2008 21:13:58 -0400 Message-Id: <1216862038.30436.8.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] hold shift or control to disable timeout even timeout=0 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2008 01:14:04 -0000 On Wed, 2008-07-23 at 19:52 -0500, David Fries wrote: > This calls the getshiftflags BIOS int 16h function 2 in startup.S, to > find out the status of the shift and control keys (among others). The > required header and source files were modified to expose > grub_getshiftflags. menu.c checks grub_getshiftflags and will disable > the timeout. Cannot we avoid adding code to core.img that it not called from core.img? Just because it's written in assembly it doesn't mean it should be in the in the core. Sure, we are better off now that we are using lzma, but it we start adding stuff mindlessly, core.img can again grow too large for some setups. -- Regards, Pavel Roskin