From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KLptY-0000ee-Mu for mharc-grub-devel@gnu.org; Wed, 23 Jul 2008 21:45:28 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLptW-0000eI-JQ for grub-devel@gnu.org; Wed, 23 Jul 2008 21:45:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLptV-0000dt-6D for grub-devel@gnu.org; Wed, 23 Jul 2008 21:45:26 -0400 Received: from [199.232.76.173] (port=36918 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLptV-0000dq-1J for grub-devel@gnu.org; Wed, 23 Jul 2008 21:45:25 -0400 Received: from c60.cesmail.net ([216.154.195.49]:20189) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KLptU-0002kT-Np for grub-devel@gnu.org; Wed, 23 Jul 2008 21:45:24 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 23 Jul 2008 21:45:23 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id E9C4E618F22 for ; Wed, 23 Jul 2008 21:45:22 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080724013607.GA5621@spacedout.fries.net> References: <20080724005259.GA16237@spacedout.fries.net> <1216862038.30436.8.camel@dv> <20080724013607.GA5621@spacedout.fries.net> Content-Type: text/plain Date: Wed, 23 Jul 2008 21:45:22 -0400 Message-Id: <1216863922.30436.16.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] hold shift or control to disable timeout even timeout=0 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2008 01:45:27 -0000 On Wed, 2008-07-23 at 20:36 -0500, David Fries wrote: > I could make the argument that it is ten assmebly instructions, but I > think the stronger case is the other two keyboard reading routines are > right there in the same file. > > I suppose the grub_checkkey and the new grub_getshiftflags could both > be moved out of core.img, but where would they go and how would they > get assigned to the grub_term structure? I think they should be in normal.mod, and should be assigned in the normal.mod initialization. Maybe it could be a new file with architecture specific code needed for normal.mod support. -- Regards, Pavel Roskin