From: Pavel Roskin <proski@gnu.org>
To: Nick Kossifidis <mick@madwifi.org>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, jirislaby@gmail.com, mcgrof@gmail.com
Subject: Re: [PATCH 2/12] ath5k: Restore saved initval after POST
Date: Thu, 24 Jul 2008 17:26:28 -0400 [thread overview]
Message-ID: <1216934788.3094.8.camel@dv> (raw)
In-Reply-To: <20080720033232.GB7440@makis>
On Sun, 2008-07-20 at 06:32 +0300, Nick Kossifidis wrote:
> * Restore saved initial value after POST
...
> @@ -170,6 +172,10 @@ static int ath5k_hw_post(struct ath5k_hw *ah)
> var_pattern = 0x003b080f;
> ath5k_hw_reg_write(ah, var_pattern, cur_reg);
> }
> +
> + /* Restore previous value */
> + ath5k_hw_reg_write(ah, init_val, cur_reg);
> +
> }
Perhaps "at the end of POST"? Anyway, the code looks good to me.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-07-24 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 3:32 [PATCH 2/12] ath5k: Restore saved initval after POST Nick Kossifidis
2008-07-24 21:26 ` Pavel Roskin [this message]
2008-07-24 21:36 ` Nick Kossifidis
2008-07-24 21:40 ` Pavel Roskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216934788.3094.8.camel@dv \
--to=proski@gnu.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=mick@madwifi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.