From: Pavel Roskin <proski@gnu.org>
To: Nick Kossifidis <mick@madwifi.org>
Cc: ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, jirislaby@gmail.com, mcgrof@gmail.com
Subject: Re: [PATCH 3/12] ath5k: Misc hw_attach fixes
Date: Thu, 24 Jul 2008 17:28:53 -0400 [thread overview]
Message-ID: <1216934933.3094.11.camel@dv> (raw)
In-Reply-To: <20080720033439.GC7440@makis>
On Sun, 2008-07-20 at 06:34 +0300, Nick Kossifidis wrote:
> #define AR5K_SREV_RAD_5112A 0x35
> +#define AR5K_SREV_RAD_5112B 0x36
Please avoid tabs after "#define"
Apart from that, it looks good.
--
Regards,
Pavel Roskin
prev parent reply other threads:[~2008-07-24 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 3:34 [PATCH 3/12] ath5k: Misc hw_attach fixes Nick Kossifidis
2008-07-24 21:28 ` Pavel Roskin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216934933.3094.11.camel@dv \
--to=proski@gnu.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=mick@madwifi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.