From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KMV9w-0005Dk-EM for mharc-grub-devel@gnu.org; Fri, 25 Jul 2008 17:49:08 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KMV9v-0005DL-DR for grub-devel@gnu.org; Fri, 25 Jul 2008 17:49:07 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KMV9t-0005B6-UQ for grub-devel@gnu.org; Fri, 25 Jul 2008 17:49:06 -0400 Received: from [199.232.76.173] (port=43961 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KMV9t-0005B0-QJ for grub-devel@gnu.org; Fri, 25 Jul 2008 17:49:05 -0400 Received: from c60.cesmail.net ([216.154.195.49]:52757) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KMV9t-0002HO-Ff for grub-devel@gnu.org; Fri, 25 Jul 2008 17:49:05 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 25 Jul 2008 17:49:04 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 7088C618F22 for ; Fri, 25 Jul 2008 17:49:04 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080725203751.GC18149@thorin> References: <4888158C.1070506@t-online.de> <20080725203751.GC18149@thorin> Content-Type: text/plain Date: Fri, 25 Jul 2008 17:49:03 -0400 Message-Id: <1217022543.3957.6.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Abort grub-install if prefix cannot be determined X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jul 2008 21:49:07 -0000 On Fri, 2008-07-25 at 22:37 +0200, Robert Millan wrote: > On Thu, Jul 24, 2008 at 07:39:24AM +0200, Christian Franke wrote: > > grub-install does not check error return from > > make_system_path_relative_to_its_root() fails. > > > > BTW: Unlike the other scripts, grub-install does not 'set -e'. Is this > > intentional or historic ?-) > > I think it's historic. Wouldn't mind moving it to 'set -e' (although one > would have to check which grub-probe calls are allowed to fail). What > do others think? I agree with you. It's better to add explicit "|| :" to a few commands that can fail than to allow every command to fail. -- Regards, Pavel Roskin