From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nathan Lynch <ntl@pobox.com>
Cc: ppc-dev <Linuxppc-dev@ozlabs.org>
Subject: Re: can't boot mpc5200, powerpc: Enable AT_BASE_PLATFORM aux vector
Date: Sat, 26 Jul 2008 08:15:08 +1000 [thread overview]
Message-ID: <1217024108.11188.117.camel@pasglop> (raw)
In-Reply-To: <20080725220038.GI9594@localdomain>
On Fri, 2008-07-25 at 17:00 -0500, Nathan Lynch wrote:
> Jon Smirl wrote:
> > I've lost my ability to boot on the mpc5200. Reverting this patch fixes it.
>
> How does it fail?
>
>
> > @@ -1652,6 +1655,14 @@ struct cpu_spec * __init identify_cpu(unsigned
> > long offset, unsigned int pvr)
> > } else
> > *t = *s;
> > *PTRRELOC(&cur_cpu_spec) = &the_cpu_spec;
> > +
> > + /*
> > + * Set the base platform string once; assumes
> > + * we're called with real pvr first.
> > + */
> > + if (powerpc_base_platform == NULL)
> > + powerpc_base_platform = t->platform;
> > +
>
> Hmm, maybe this needs RELOC/PTRRELOC tricks?
Hrm... indeed.
if (RELOC(powerpc_base_platform))
RELOC(powerpc_base_platform) = t->platform;
try that.
Ben.
next prev parent reply other threads:[~2008-07-25 22:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 21:51 can't boot mpc5200, powerpc: Enable AT_BASE_PLATFORM aux vector Jon Smirl
2008-07-25 22:00 ` Nathan Lynch
2008-07-25 22:15 ` Benjamin Herrenschmidt [this message]
2008-07-25 22:46 ` Jon Smirl
2008-07-25 22:51 ` Jon Smirl
2008-07-25 22:50 ` Nathan Lynch
2008-07-25 22:52 ` Jon Smirl
2008-07-25 22:58 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217024108.11188.117.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=Linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.