From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KMYHL-0001Di-JH for mharc-grub-devel@gnu.org; Fri, 25 Jul 2008 21:08:59 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KMYHK-0001D3-8A for grub-devel@gnu.org; Fri, 25 Jul 2008 21:08:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KMYHH-0001BZ-Qw for grub-devel@gnu.org; Fri, 25 Jul 2008 21:08:57 -0400 Received: from [199.232.76.173] (port=50049 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KMYHH-0001B5-Au for grub-devel@gnu.org; Fri, 25 Jul 2008 21:08:55 -0400 Received: from c60.cesmail.net ([216.154.195.49]:60491) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KMYHH-0000Mf-2j for grub-devel@gnu.org; Fri, 25 Jul 2008 21:08:55 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 25 Jul 2008 21:08:57 -0400 Received: from [192.168.0.21] (static-72-92-88-10.phlapa.fios.verizon.net [72.92.88.10]) by relay.cesmail.net (Postfix) with ESMTP id 4AD00618F22 for ; Fri, 25 Jul 2008 21:08:53 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <20080725221050.GA31179@thorin> References: <20080722133416.GB5524@archvile> <20080722095021.p15u40gtyc88csco-cebfxv@webmail.spamcop.net> <3FA357AE49694559941A663191155DE2@fz> <5A50C2D990914B3F8A73A02D520E8DED@fz> <1216918145.22586.14.camel@dv> <20080725210840.GA19505@thorin> <1217022420.3957.3.camel@dv> <20080725221050.GA31179@thorin> Content-Type: text/plain Date: Fri, 25 Jul 2008 21:08:52 -0400 Message-Id: <1217034532.6376.13.camel@dv> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 (2.22.3.1-1.fc9) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] use UUIDs for cross-disk installs (Re: Issue with boot != root and chainloading) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Jul 2008 01:08:58 -0000 On Sat, 2008-07-26 at 00:10 +0200, Robert Millan wrote: > See attached patch. I'm afraid it doesn't make kernel smaller as promised; > I expected to get rid of make_install_device() in kernel, but later noticed > that this is still needed for non-cross installs. I like your patch. We should try to move more logic to scripts. As for single drive installs, we could also encode the prefix in the text form, like "(hd0,5)/boot/grub" and obsolete the numerical partition data. That would make make_install_device() unnecessary. The only problem is that we should avoid hardcoding the drive. We need a notation for partitions on the boot or the current drive, perhaps by removing the drive name e.g. "(,5)/boot/grub" We could also use UUID for single-drive installs and fallback to the partition prefix only if UUID is unsupported or the user requests not to use UUID. Then it won't be a big deal if we hardcode the drive. -- Regards, Pavel Roskin