From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KMy0E-0003TS-HE for mharc-grub-devel@gnu.org; Sun, 27 Jul 2008 00:37:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KMy0D-0003TE-DE for grub-devel@gnu.org; Sun, 27 Jul 2008 00:37:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KMy0A-0003T2-U7 for grub-devel@gnu.org; Sun, 27 Jul 2008 00:37:00 -0400 Received: from [199.232.76.173] (port=43325 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KMy0A-0003Sz-NP for grub-devel@gnu.org; Sun, 27 Jul 2008 00:36:58 -0400 Received: from c60.cesmail.net ([216.154.195.49]:56663) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_SHA1:16) (Exim 4.60) (envelope-from ) id 1KMy0A-0005RB-Cj for grub-devel@gnu.org; Sun, 27 Jul 2008 00:36:58 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 27 Jul 2008 00:36:57 -0400 Received: from [192.168.1.225] (pool-71-185-138-248.phlapa.east.verizon.net [71.185.138.248]) by relay.cesmail.net (Postfix) with ESMTP id D9678618F22 for ; Sun, 27 Jul 2008 00:36:56 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: <200807251458.23483.Chris.Knadle@coredump.us> References: <200807251319.38699.Chris.Knadle@coredump.us> <200807251458.23483.Chris.Knadle@coredump.us> Content-Type: text/plain Date: Sun, 27 Jul 2008 00:36:43 -0400 Message-Id: <1217133403.15984.4.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.23.4 (2.23.4-3.fc10) Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Misc patches for grub2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2008 04:37:01 -0000 On Fri, 2008-07-25 at 14:58 -0400, Chris Knadle wrote: > On Friday 25 July 2008, Bean wrote: > > On Sat, Jul 26, 2008 at 1:19 AM, Chris Knadle > wrote: > > > On Friday 25 July 2008, Bean wrote: > > >> 4. rename appleloader command to bootcamp > > >> > > >> The name appleloader may be a little confusing, bootcamp seems to be a > > >> better choice. > > > > > > Rather than patching all of the content from appleloader.c to > > > bootcamp.c you may want to consider doing a 'git-mv' to rename the file > > > instead. > > > > Yes, i do use git-mv to rename files, but when i use git-diff to > > generate the patch, it looks like this. > > Oh... Okay I think I understand why. 'git-diff -M' can detect the renames > and just list them, but the 'patch' command can't use that to incorporate the > renames, which is probably why the -M behavior isn't the default. > > So... nevermind. ;-) Our main repository is in Subversion, so whoever applies the patch should use "svn move" to keep the contiguous file history. Unlike git, which trusts the contents in the first place, Subversion is more sensitive to whatever users are telling it. -- Regards, Pavel Roskin