From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KN0ks-00030T-4c for mharc-grub-devel@gnu.org; Sun, 27 Jul 2008 03:33:22 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KN0kq-00030K-HO for grub-devel@gnu.org; Sun, 27 Jul 2008 03:33:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KN0kp-0002ya-0n for grub-devel@gnu.org; Sun, 27 Jul 2008 03:33:20 -0400 Received: from [199.232.76.173] (port=56667 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KN0ko-0002yE-P7 for grub-devel@gnu.org; Sun, 27 Jul 2008 03:33:18 -0400 Received: from mx20.gnu.org ([199.232.41.8]:49222) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KN0ko-0002f5-K1 for grub-devel@gnu.org; Sun, 27 Jul 2008 03:33:18 -0400 Received: from c60.cesmail.net ([216.154.195.49]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KN0kn-0004u3-P2 for grub-devel@gnu.org; Sun, 27 Jul 2008 03:33:17 -0400 Received: from unknown (HELO relay.cesmail.net) ([192.168.1.81]) by c60.cesmail.net with ESMTP; 27 Jul 2008 03:33:15 -0400 Received: from [192.168.1.225] (pool-71-185-138-248.phlapa.east.verizon.net [71.185.138.248]) by relay.cesmail.net (Postfix) with ESMTP id 76970618F22 for ; Sun, 27 Jul 2008 03:33:14 -0400 (EDT) From: Pavel Roskin To: The development of GRUB 2 In-Reply-To: References: <20080725205339.GH18149@thorin> <1217134545.15984.13.camel@ct> <1217142302.16601.40.camel@ct> <1217143244.16601.45.camel@ct> Content-Type: text/plain Date: Sun, 27 Jul 2008 03:33:07 -0400 Message-Id: <1217143987.16601.47.camel@ct> Mime-Version: 1.0 X-Mailer: Evolution 2.23.4 (2.23.4-3.fc10) Content-Transfer-Encoding: 7bit X-detected-kernel: by mx20.gnu.org: Genre and OS details not recognized. X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) Subject: Re: [PATCH] Misc patches for grub2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 Jul 2008 07:33:21 -0000 On Sun, 2008-07-27 at 15:30 +0800, Bean wrote: > On Sun, Jul 27, 2008 at 3:20 PM, Pavel Roskin wrote: > >> >> BTW, any comment about the other changes ? > >> > > >> > Why do we need "crc"? If there are chances that it will be used for > >> > security, we should be using SHA-1. > >> > >> crc is useful in many place. For example, png, jffs2, etc. > > > > But why make it a command? > > There are two parts, one is lib/crc.c, which contains only the crc > function, the other is command/crc.c, which is a command to calculate > the crc of selected file. Although it's not necessary to have a > command, but it can 1) serve as an example of how to use the crc > function, 2) as a cheap way to verify if a file is read correctly by > the fs driver. OK, then it's probably a good idea. -- Regards, Pavel Roskin