From: Pavel Roskin <proski@gnu.org>
To: Nick Kossifidis <mickflemm@gmail.com>
Cc: Jiri Slaby <jirislaby@gmail.com>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
linville@tuxdriver.com, mcgrof@gmail.com
Subject: Re: [ath5k-devel] [PATCH 12/12] ath5k: Fix a compilation error after reg list update
Date: Mon, 28 Jul 2008 09:10:01 -0400 [thread overview]
Message-ID: <1217250601.2441.20.camel@dv> (raw)
In-Reply-To: <40f31dec0807280604m19a8c511nf2568bb7aa357b90@mail.gmail.com>
On Mon, 2008-07-28 at 16:04 +0300, Nick Kossifidis wrote:
> > Please amend this to the patch 1 to not break bisectability.
>
> I see your point but this series is meant to be applied as a whole, i
> didn't notice this bug until i tested the code with debugging enabled
> (which is off by default), that's why it's "last minute fix". Is it
> really that much needed to repost the first patch ? I mean the patch
> series works and doesn't introduce any problems...
The reason is that git-bisect divides the number of commits in half and
checks out the middle commit. That commit make be a broken one.
Hitting one bug while hunting another is not nice.
Besides, nobody wants to apply a known bad patch.
It would be great if you repost fixed patches. If you are not using
stgit, please try it. I would make it easy to return to older patches
and change them. "stg edit -d" even allows editing the patch.
--
Regards,
Pavel Roskin
next prev parent reply other threads:[~2008-07-28 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 3:52 [PATCH 12/12] ath5k: Fix a compilation error after reg list update Nick Kossifidis
2008-07-22 14:36 ` Jiri Slaby
2008-07-28 13:04 ` [ath5k-devel] " Nick Kossifidis
2008-07-28 13:10 ` Pavel Roskin [this message]
2008-07-28 14:44 ` Nick Kossifidis
2008-07-22 14:53 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217250601.2441.20.camel@dv \
--to=proski@gnu.org \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.